QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-05-30 07:49:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(savings_goals): replace hero card with KPI strip + differentiate empty states

Browse Source 
P1: drop the sparkline + the single mixed hero. Hero became 3 separate
KPI cards (Contributed last 30d, Needs this month, Goals on track),
matching the Transactions page pattern. Each KPI answers a question the
user opens the page asking — saving rate, this-month action, overall
health.

P3: empty state copy + CTA now reflect the reason it is empty. Search
returns 0 → "No goals match X" + Clear search. Chip set to non-all → "No
goals match this filter" + Show all. Both → both reasons + both
buttons.

Drop: total_savings_balance, savings_balance_series,
savings_balance_30d_delta on Family (no other consumers).
Add: Family#contribution_velocity(range:).
This commit is contained in:
Guillem Arias
2026-05-11 14:14:37 +02:00
parent 69c45d4714
commit 8ba6cbcdc8
6 changed files with 198 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
app/javascript/controllers/savings_goals_filter_controller.js
View File

@@ -5,8 +5,24 @@ import { Controller } from "@hotwired/stimulus";
// and data-goal-status; the controller toggles `.hidden` on cards
// based on the active query/chip.
export default class extends Controller {
static targets = ["input", "chip", "card", "empty", "grid", "count"];
static values = { status: { type: String, default: "all" } };
static targets = [
"input",
"chip",
"card",
"empty",
"emptyCopy",
"emptyClearSearch",
"emptyClearFilter",
"grid",
"count",
];
static values = {
status: { type: String, default: "all" },
emptyQuery: { type: String, default: "" },
emptyFilter: { type: String, default: "" },
emptyBoth: { type: String, default: "" },
emptyDefault: { type: String, default: "" },
};
connect() {
this.syncChipState();
@@ -38,6 +54,46 @@ export default class extends Controller {
if (this.hasCountTarget) {
this.countTarget.textContent = visible;
}
this.updateEmptyState(visible, query, active);
}
updateEmptyState(visible, query, active) {
if (visible > 0 || !this.hasEmptyCopyTarget) return;
const rawQuery = this.hasInputTarget ? this.inputTarget.value.trim() : "";
const hasQuery = rawQuery.length > 0;
const hasFilter = active !== "all";
let copy;
if (hasQuery && hasFilter) {
copy = this.emptyBothValue.replace("__QUERY__", rawQuery);
} else if (hasQuery) {
copy = this.emptyQueryValue.replace("__QUERY__", rawQuery);
} else if (hasFilter) {
copy = this.emptyFilterValue;
} else {
copy = this.emptyDefaultValue;
}
this.emptyCopyTarget.textContent = copy;
if (this.hasEmptyClearSearchTarget) {
this.emptyClearSearchTarget.classList.toggle("hidden", !hasQuery);
}
if (this.hasEmptyClearFilterTarget) {
this.emptyClearFilterTarget.classList.toggle("hidden", !hasFilter);
}
}
clearSearch() {
if (this.hasInputTarget) {
this.inputTarget.value = "";
this.inputTarget.focus();
}
this.filter();
}
clearFilter() {
this.statusValue = "all";
this.syncChipState();
this.filter();
}
selectChip(event) {

110
app/javascript/controllers/savings_sparkline_controller.js
View File

@@ -1,110 +0,0 @@
import { Controller } from "@hotwired/stimulus";
import * as d3 from "d3";
// Sparkline area chart for the savings hero card. Tiny, axis-less,
// labelless — just the green line + soft area fill + end dot.
// Data: [{ date: "YYYY-MM-DD", value: Number }, ...]
export default class extends Controller {
static values = { series: Array };
connect() {
this._draw();
this._resize = this._draw.bind(this);
window.addEventListener("resize", this._resize);
}
disconnect() {
window.removeEventListener("resize", this._resize);
}
_draw() {
const root = this.element;
root.innerHTML = "";
const series = (this.seriesValue || []).map((p) => ({
date: new Date(p.date),
value: Number(p.value || 0),
}));
if (series.length < 2) return;
const width = root.clientWidth || 600;
const height = root.clientHeight || 140;
if (width <= 0 || height <= 0) return;
const margin = { top: 8, right: 12, bottom: 4, left: 8 };
const innerWidth = width - margin.left - margin.right;
const innerHeight = height - margin.top - margin.bottom;
const x = d3
.scaleTime()
.domain(d3.extent(series, (d) => d.date))
.range([margin.left, margin.left + innerWidth]);
const yMin = Math.min(...series.map((d) => d.value));
const yMax = Math.max(...series.map((d) => d.value));
// Don't clamp to 0 — savings totals can be negative under certain
// demo / edge conditions, and clamping pushes the line off-canvas.
const range = yMax - yMin;
const padding = range > 0 ? range * 0.15 : Math.abs(yMax) * 0.05 || 1;
const y = d3
.scaleLinear()
.domain([yMin - padding, yMax + padding])
.range([margin.top + innerHeight, margin.top]);
const svg = d3
.select(root)
.append("svg")
.attr("width", width)
.attr("height", height)
.attr("viewBox", `0 0 ${width} ${height}`)
.attr("preserveAspectRatio", "none");
const gradId = `sparkline-fill-${Math.random().toString(36).slice(2, 8)}`;
const defs = svg.append("defs");
const grad = defs
.append("linearGradient")
.attr("id", gradId)
.attr("x1", 0).attr("y1", 0).attr("x2", 0).attr("y2", 1);
grad.append("stop").attr("offset", "0%").attr("stop-color", "var(--color-green-500)").attr("stop-opacity", 0.18);
grad.append("stop").attr("offset", "100%").attr("stop-color", "var(--color-green-500)").attr("stop-opacity", 0);
const area = d3
.area()
.x((d) => x(d.date))
.y0(margin.top + innerHeight)
.y1((d) => y(d.value))
.curve(d3.curveMonotoneX);
const line = d3
.line()
.x((d) => x(d.date))
.y((d) => y(d.value))
.curve(d3.curveMonotoneX);
svg
.append("path")
.datum(series)
.attr("fill", `url(#${gradId})`)
.attr("d", area);
svg
.append("path")
.datum(series)
.attr("fill", "none")
.attr("stroke", "var(--color-green-600)")
.attr("stroke-width", 2)
.attr("stroke-linejoin", "round")
.attr("stroke-linecap", "round")
.attr("d", line);
const last = series[series.length - 1];
svg
.append("circle")
.attr("cx", x(last.date))
.attr("cy", y(last.value))
.attr("r", 4)
.attr("fill", "var(--color-green-600)")
.attr("stroke", "var(--bg-container)")
.attr("stroke-width", 2);
}
}