QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 12:04:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Langfuse client trace upsert API (#1041)

Browse Source 
Replace direct trace.update calls with client trace upserts so OpenAI provider is compatible with langfuse-ruby 0.1.6 behavior. Add richer warning logs that include full exception details for trace creation, trace upserts, and generation logging failures. Add tests for client-based trace upserts and detailed error logging.
This commit is contained in:
Juan José Mata
2026-02-23 09:29:21 -05:00
committed by GitHub
parent 1f9a934c59
commit 90e94f0ad1
2 changed files with 68 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
app/models/provider/openai.rb
View File

@@ -82,7 +82,7 @@ class Provider::Openai < Provider
json_mode: json_mode
).auto_categorize
trace&.update(output: result.map(&:to_h))
upsert_langfuse_trace(trace: trace, output: result.map(&:to_h))
result
end
@@ -110,7 +110,7 @@ class Provider::Openai < Provider
json_mode: json_mode
).auto_detect_merchants
trace&.update(output: result.map(&:to_h))
upsert_langfuse_trace(trace: trace, output: result.map(&:to_h))
result
end
@@ -147,7 +147,7 @@ class Provider::Openai < Provider
family: family
).process
trace&.update(output: result.to_h)
upsert_langfuse_trace(trace: trace, output: result.to_h)
result
end
@@ -168,7 +168,7 @@ class Provider::Openai < Provider
model: effective_model
).extract
trace&.update(output: { transaction_count: result[:transactions].size })
upsert_langfuse_trace(trace: trace, output: { transaction_count: result[:transactions].size })
result
end
@@ -480,7 +480,7 @@ class Provider::Openai < Provider
environment: Rails.env
)
rescue => e
Rails.logger.warn("Langfuse trace creation failed: #{e.message}")
Rails.logger.warn("Langfuse trace creation failed: #{e.message}\n#{e.full_message}")
nil
end
@@ -505,16 +505,32 @@ class Provider::Openai < Provider
output: { error: error.message, details: error.respond_to?(:details) ? error.details : nil },
level: "ERROR"
)
trace&.update(
upsert_langfuse_trace(
trace: trace,
output: { error: error.message },
level: "ERROR"
)
else
generation&.end(output: output, usage: usage)
trace&.update(output: output)
upsert_langfuse_trace(trace: trace, output: output)
end
rescue => e
Rails.logger.warn("Langfuse logging failed: #{e.message}")
Rails.logger.warn("Langfuse logging failed: #{e.message}\n#{e.full_message}")
end
def upsert_langfuse_trace(trace:, output:, level: nil)
return unless langfuse_client && trace&.id
payload = {
id: trace.id,
output: output
}
payload[:level] = level if level.present?
langfuse_client.trace(**payload)
rescue => e
Rails.logger.warn("Langfuse trace upsert failed for trace_id=#{trace&.id}: #{e.message}\n#{e.full_message}")
nil
end
def record_llm_usage(family:, model:, operation:, usage: nil, error: nil)