Centralize entry naming (#2454)

* Centralize entry naming

* Lint fixes, code style

test/controllers/valuations_controller_test.rb

@@ -23,7 +23,7 @@ class ValuationsControllerTest < ActionDispatch::IntegrationTest
     end
 
     created_entry = Entry.order(created_at: :desc).first
-    assert_equal "Manual account value update", created_entry.name
+    assert_equal "Manual value update", created_entry.name
     assert_equal Date.current, created_entry.date
     assert_equal account.balance + 100, created_entry.amount_money.to_f
 

test/models/trade_test.rb

@@ -0,0 +1,23 @@
+require "test_helper"
+
+class TradeTest < ActiveSupport::TestCase
+  test "build_name generates buy trade name" do
+    name = Trade.build_name("buy", 10, "AAPL")
+    assert_equal "Buy 10.0 shares of AAPL", name
+  end
+
+  test "build_name generates sell trade name" do
+    name = Trade.build_name("sell", 5, "MSFT")
+    assert_equal "Sell 5.0 shares of MSFT", name
+  end
+
+  test "build_name handles absolute value for negative quantities" do
+    name = Trade.build_name("sell", -5, "GOOGL")
+    assert_equal "Sell 5.0 shares of GOOGL", name
+  end
+
+  test "build_name handles decimal quantities" do
+    name = Trade.build_name("buy", 0.25, "BTC")
+    assert_equal "Buy 0.25 shares of BTC", name
+  end
+end

test/models/valuation/name_test.rb

@@ -0,0 +1,66 @@
+require "test_helper"
+
+class Valuation::NameTest < ActiveSupport::TestCase
+  # Opening anchor tests
+  test "generates opening anchor name for Property" do
+    name = Valuation::Name.new("opening_anchor", "Property")
+    assert_equal "Original purchase price", name.to_s
+  end
+
+  test "generates opening anchor name for Loan" do
+    name = Valuation::Name.new("opening_anchor", "Loan")
+    assert_equal "Original principal", name.to_s
+  end
+
+  test "generates opening anchor name for Investment" do
+    name = Valuation::Name.new("opening_anchor", "Investment")
+    assert_equal "Opening account value", name.to_s
+  end
+
+  test "generates opening anchor name for other account types" do
+    name = Valuation::Name.new("opening_anchor", "Depository")
+    assert_equal "Opening balance", name.to_s
+  end
+
+  # Current anchor tests
+  test "generates current anchor name for Property" do
+    name = Valuation::Name.new("current_anchor", "Property")
+    assert_equal "Current market value", name.to_s
+  end
+
+  test "generates current anchor name for Loan" do
+    name = Valuation::Name.new("current_anchor", "Loan")
+    assert_equal "Current loan balance", name.to_s
+  end
+
+  test "generates current anchor name for Investment" do
+    name = Valuation::Name.new("current_anchor", "Investment")
+    assert_equal "Current account value", name.to_s
+  end
+
+  test "generates current anchor name for other account types" do
+    name = Valuation::Name.new("current_anchor", "Depository")
+    assert_equal "Current balance", name.to_s
+  end
+
+  # Reconciliation tests
+  test "generates recon name for Property" do
+    name = Valuation::Name.new("reconciliation", "Property")
+    assert_equal "Manual value update", name.to_s
+  end
+
+  test "generates recon name for Investment" do
+    name = Valuation::Name.new("reconciliation", "Investment")
+    assert_equal "Manual value update", name.to_s
+  end
+
+  test "generates recon name for Loan" do
+    name = Valuation::Name.new("reconciliation", "Loan")
+    assert_equal "Manual principal update", name.to_s
+  end
+
+  test "generates recon name for other account types" do
+    name = Valuation::Name.new("reconciliation", "Depository")
+    assert_equal "Manual balance update", name.to_s
+  end
+end

test/system/trades_test.rb

@@ -31,7 +31,7 @@ class TradesTest < ApplicationSystemTestCase
     visit_trades
 
     within_trades do
-      assert_text "Buy #{shares_qty} shares of AAPL"
+      assert_text "Buy #{shares_qty}.0 shares of AAPL"
     end
   end
 
@@ -52,7 +52,7 @@ class TradesTest < ApplicationSystemTestCase
     visit_trades
 
     within_trades do
-      assert_text "Sell #{qty} shares of AAPL"
+      assert_text "Sell #{qty}.0 shares of AAPL"
     end
   end