Improvements (#379)

* Improvements

- Fix button visibility in reports on light theme
- Unify logic for provider syncs
- Add default option is to skip accounts linking ( no op default )

* Stability fixes and UX improvements

* FIX add unlinking when deleting lunch flow connection as well

* Wrap updates in transaction

* Some more improvements

* FIX proper provider setup check

* Make provider section collapsible

* Fix balance calculation

* Restore focus ring

* Use browser default focus

* Fix lunch flow balance for credit cards

app/controllers/settings/providers_controller.rb

@@ -126,8 +126,8 @@ class Settings::ProvidersController < ApplicationController
         config.provider_key.to_s.casecmp("simplefin").zero? || config.provider_key.to_s.casecmp("lunchflow").zero?
       end
 
-      # Providers page only needs to know whether any SimpleFin/Lunchflow connections exist
-      @simplefin_items = Current.family.simplefin_items.ordered.select(:id)
-      @lunchflow_items = Current.family.lunchflow_items.ordered.select(:id)
+      # Providers page only needs to know whether any SimpleFin/Lunchflow connections exist with valid credentials
+      @simplefin_items = Current.family.simplefin_items.where.not(access_url: [ nil, "" ]).ordered.select(:id)
+      @lunchflow_items = Current.family.lunchflow_items.where.not(api_key: [ nil, "" ]).ordered.select(:id)
     end
 end