From 98ca1608f4acdbfec3d07fc721e9661284793748 Mon Sep 17 00:00:00 2001
From: dripsmvcp <138900956+dripsmvcp@users.noreply.github.com>
Date: Sun, 24 May 2026 20:43:36 +0900
Subject: [PATCH] fix(enable_banking): match bank list search against BIC, not
 just name (#1874)

* fix(enable_banking): match bank list search against BIC, not just name

Bank-search filter on the Enable Banking bank-selection modal only indexed
`aspsp[:name]`, so users searching by BIC code (e.g. `INGDDEFF`) got no
results even when the bank was rendered in the list. Switch the per-item
data attribute to a `name + BIC` haystack and read from it in the Stimulus
controller, so either token matches.

Refs #1814

* style(bank_search): apply Biome formatting to forEach callback (#1874 review)
---
 .../controllers/bank_search_controller.js     |  6 +--
 .../enable_banking_items/select_bank.html.erb |  2 +-
 .../enable_banking_items_controller_test.rb   | 42 +++++++++++++++++++
 3 files changed, 46 insertions(+), 4 deletions(-)
 create mode 100644 test/controllers/enable_banking_items_controller_test.rb

diff --git a/app/javascript/controllers/bank_search_controller.js b/app/javascript/controllers/bank_search_controller.js
index a2c045cd9..155a7a8bb 100644
--- a/app/javascript/controllers/bank_search_controller.js
+++ b/app/javascript/controllers/bank_search_controller.js
@@ -7,9 +7,9 @@ export default class extends Controller {
     const query = this.inputTarget.value.toLocaleLowerCase().trim();
     let visibleCount = 0;
 
-    this.itemTargets.forEach(item => {
-      const name = item.dataset.bankName?.toLocaleLowerCase() ?? "";
-      const match = name.includes(query);
+    this.itemTargets.forEach((item) => {
+      const haystack = (item.dataset.bankSearch ?? "").toLocaleLowerCase();
+      const match = haystack.includes(query);
       item.style.display = match ? "" : "none";
       if (match) visibleCount++;
     });
diff --git a/app/views/enable_banking_items/select_bank.html.erb b/app/views/enable_banking_items/select_bank.html.erb
index 124c8e3ec..095ae6738 100644
--- a/app/views/enable_banking_items/select_bank.html.erb
+++ b/app/views/enable_banking_items/select_bank.html.erb
@@ -28,7 +28,7 @@
 
           <div class="space-y-2 max-h-80 overflow-y-auto">
             <% @aspsps.each do |aspsp| %>
-              <div data-bank-search-target="item" data-bank-name="<%= aspsp[:name].to_s.downcase(:fold) %>">
+              <div data-bank-search-target="item" data-bank-search="<%= [ aspsp[:name], aspsp[:bic] ].compact_blank.join(" ").downcase(:fold) %>">
                 <%= button_to authorize_enable_banking_item_path(@enable_banking_item),
                               method: :post,
                               params: { aspsp_name: aspsp[:name], new_connection: @new_connection },
diff --git a/test/controllers/enable_banking_items_controller_test.rb b/test/controllers/enable_banking_items_controller_test.rb
new file mode 100644
index 000000000..06005bc9a
--- /dev/null
+++ b/test/controllers/enable_banking_items_controller_test.rb
@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "openssl"
+
+class EnableBankingItemsControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in users(:family_admin)
+    @family = families(:dylan_family)
+    @item = @family.enable_banking_items.create!(
+      name: "Test Connection",
+      country_code: "DE",
+      application_id: "test_app_id",
+      client_certificate: OpenSSL::PKey::RSA.new(2048).to_pem
+    )
+  end
+
+  test "select_bank exposes ASPSP BIC in the searchable data attribute" do
+    Provider::EnableBanking.any_instance.stubs(:get_aspsps).returns(
+      aspsps: [
+        {
+          name: "ING-DiBa AG",
+          country: "DE",
+          bic: "INGDDEFF",
+          beta: false,
+          psu_types: [ "personal" ],
+          auth_methods: [ { approach: "REDIRECT" } ]
+        }
+      ]
+    )
+
+    get select_bank_enable_banking_item_url(@item)
+
+    assert_response :success
+    haystack = @response.body[/data-bank-search="([^"]*)"/, 1]
+    assert haystack, "Expected list items to render a data-bank-search attribute the client filter reads from"
+    assert_includes haystack, "ingddeff",
+      "Expected the searchable data attribute to include the BIC so users can find banks by BIC code"
+    assert_includes haystack, "ing-diba ag",
+      "Expected the searchable data attribute to still include the bank name (existing name-search behavior)"
+  end
+end