From a9661253f432dcd3b3764a00c7c188cd8bf4523b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Jos=C3=A9=20Mata?= Date: Tue, 5 May 2026 18:48:06 +0200 Subject: [PATCH] Revert "feat(accounts): Highlight matching activity search text in entry names" (#1682) Explanation in #1679 --- app/helpers/accounts_helper.rb | 10 ---------- app/views/trades/_trade.html.erb | 4 ++-- app/views/transactions/_split_parent_row.html.erb | 4 ++-- app/views/transactions/_transaction.html.erb | 4 ++-- app/views/valuations/_valuation.html.erb | 4 ++-- 5 files changed, 8 insertions(+), 18 deletions(-) diff --git a/app/helpers/accounts_helper.rb b/app/helpers/accounts_helper.rb index 302902f39..99ef891ce 100644 --- a/app/helpers/accounts_helper.rb +++ b/app/helpers/accounts_helper.rb @@ -1,6 +1,4 @@ module AccountsHelper - ACTIVITY_HIGHLIGHT_MARKUP = '\1'.freeze - def summary_card(title:, &block) content = capture(&block) render "accounts/summary_card", title: title, content: content @@ -10,12 +8,4 @@ module AccountsHelper # Always use the account sync path, which handles syncing all providers sync_account_path(account) end - - def highlight_activity_entry_name(name, query = params.dig(:q, :search)) - search = query.to_s.strip - return name if search.blank? - - escaped_name = ERB::Util.html_escape(name.to_s) - highlight(escaped_name, search, highlighter: ACTIVITY_HIGHLIGHT_MARKUP, sanitize: false) - end end diff --git a/app/views/trades/_trade.html.erb b/app/views/trades/_trade.html.erb index a614b0251..04b67e645 100644 --- a/app/views/trades/_trade.html.erb +++ b/app/views/trades/_trade.html.erb @@ -32,10 +32,10 @@
- <%= link_to(highlight_activity_entry_name(entry.name), + <%= link_to entry.name, entry_path(entry), data: { turbo_frame: "drawer", turbo_prefetch: false }, - class: "hover:underline") %> + class: "hover:underline" %>
<% end %> diff --git a/app/views/transactions/_split_parent_row.html.erb b/app/views/transactions/_split_parent_row.html.erb index df864569b..99bf6a086 100644 --- a/app/views/transactions/_split_parent_row.html.erb +++ b/app/views/transactions/_split_parent_row.html.erb @@ -29,10 +29,10 @@
- <%= link_to(highlight_activity_entry_name(entry.name), + <%= link_to entry.name, entry_path(entry), data: { turbo_frame: "drawer", turbo_prefetch: false }, - class: "hover:underline") %> + class: "hover:underline" %>
diff --git a/app/views/transactions/_transaction.html.erb b/app/views/transactions/_transaction.html.erb index 61a584982..551c56138 100644 --- a/app/views/transactions/_transaction.html.erb +++ b/app/views/transactions/_transaction.html.erb @@ -59,7 +59,7 @@
<% if transaction.transfer? %> <%= link_to( - highlight_activity_entry_name(entry.name), + entry.name, transaction.transfer.present? ? transfer_path(transaction.transfer) : entry_path(entry), data: { turbo_frame: "drawer", @@ -69,7 +69,7 @@ ) %> <% else %> <%= link_to( - highlight_activity_entry_name(entry.name), + entry.name, entry_path(entry), data: { turbo_frame: "drawer", diff --git a/app/views/valuations/_valuation.html.erb b/app/views/valuations/_valuation.html.erb index d19a78f5d..e377eda0f 100644 --- a/app/views/valuations/_valuation.html.erb +++ b/app/views/valuations/_valuation.html.erb @@ -17,10 +17,10 @@ <%= render DS::FilledIcon.new(icon: icon, size: "md", hex_color: color, rounded: true) %>
- <%= link_to(highlight_activity_entry_name(entry.name), + <%= link_to entry.name, entry_path(entry), data: { turbo_frame: "drawer", turbo_prefetch: false }, - class: "hover:underline") %> + class: "hover:underline" %>