Budget page refactor: split into(All - Over Budget - On Track) (#1195)

* Optimize UI in budget * update locales * Optimize UI * optimize suggested_daily_spending * try over_budget and on_track * update locale * optimize * add budgets_helper.rb * fix * hide no buget and no expense sub-catogory * Optimize * Optimize button on phone * Fix Pipelock CI noise * using section to render both overbudget and onTrack * hide last ruler * fix * update test --------- Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-05-12 15:15:01 +00:00 · 2026-04-14 02:03:55 +08:00
parent fdc2ce1feb
commit aacbb5ef3b
17 changed files with 626 additions and 63 deletions
--- a/test/helpers/budgets_helper_test.rb
+++ b/test/helpers/budgets_helper_test.rb
@@ -0,0 +1,107 @@
+require "test_helper"
+
+class BudgetsHelperTest < ActionView::TestCase
+  setup do
+    @family = families(:dylan_family)
+    @budget = budgets(:one)
+
+    @parent_category = Category.create!(
+      name: "Helper Parent #{SecureRandom.hex(4)}",
+      family: @family,
+      color: "#4da568",
+      lucide_icon: "utensils"
+    )
+
+    @child_category = Category.create!(
+      name: "Helper Child #{SecureRandom.hex(4)}",
+      parent: @parent_category,
+      family: @family
+    )
+
+    @parent_budget_category = BudgetCategory.create!(
+      budget: @budget,
+      category: @parent_category,
+      budgeted_spending: 200,
+      currency: "USD"
+    )
+
+    @child_budget_category = BudgetCategory.create!(
+      budget: @budget,
+      category: @child_category,
+      budgeted_spending: 0,
+      currency: "USD"
+    )
+  end
+
+  test "hides inheriting subcategory with no budget and no spending from on-track section" do
+    state = budget_categories_view_state(@budget)
+    group = state[:on_track_groups].find { |g| g.budget_category.id == @parent_budget_category.id }
+
+    assert group.present?
+    assert_empty group.budget_subcategories
+  end
+
+  test "shows inheriting subcategory in on-track section when it has spending" do
+    Entry.create!(
+      account: accounts(:depository),
+      entryable: Transaction.create!(category: @child_category),
+      date: Date.current,
+      name: "Helper Child Spending",
+      amount: 25,
+      currency: "USD"
+    )
+
+    budget = Budget.find(@budget.id)
+    state = budget_categories_view_state(budget)
+    group = state[:on_track_groups].find { |g| g.budget_category.category_id == @parent_category.id }
+
+    assert group.present?
+    assert_includes group.budget_subcategories.map(&:category_id), @child_category.id
+  end
+
+  test "keeps group when only subcategory is over budget" do
+    parent = Category.create!(
+      name: "Helper Group Parent #{SecureRandom.hex(4)}",
+      family: @family,
+      color: "#22c55e",
+      lucide_icon: "utensils"
+    )
+
+    child = Category.create!(
+      name: "Helper Group Child #{SecureRandom.hex(4)}",
+      parent: parent,
+      family: @family
+    )
+
+    BudgetCategory.create!(
+      budget: @budget,
+      category: parent,
+      budgeted_spending: 300,
+      currency: "USD"
+    )
+
+    BudgetCategory.create!(
+      budget: @budget,
+      category: child,
+      budgeted_spending: 50,
+      currency: "USD"
+    )
+
+    Entry.create!(
+      account: accounts(:depository),
+      entryable: Transaction.create!(category: child),
+      date: Date.current,
+      name: "Helper Child Over Budget",
+      amount: 100,
+      currency: "USD"
+    )
+
+    state = budget_categories_view_state(Budget.find(@budget.id))
+    group = state[:over_budget_groups].find { |g| g.budget_category.category_id == parent.id }
+
+    assert group.present?
+    refute group.budget_category.any_over_budget?
+    assert_equal [ child.id ], group.budget_subcategories.map(&:category_id)
+    assert group.budget_subcategories.first.any_over_budget?
+  end
+end