Add partial account sync support (#653)

* Add partial account sync support

* Fix indentation

* Use historical balance as base when doing partial sync

* Simplify controller crud tests

* Fix linter errors
This commit is contained in:
Jakub Kottnauer
2024-04-24 21:55:52 +02:00
committed by GitHub
parent b3f8ab78d9
commit ad4de99f1a
9 changed files with 260 additions and 111 deletions

View File

@@ -75,7 +75,7 @@ class TransactionsController < ApplicationController
respond_to do |format|
if @transaction.save
@transaction.account.sync_later
@transaction.account.sync_later(@transaction.date)
format.html { redirect_to transactions_url, notice: t(".success") }
else
format.html { render :new, status: :unprocessable_entity }
@@ -85,8 +85,9 @@ class TransactionsController < ApplicationController
def update
respond_to do |format|
sync_start_date = [ @transaction.date, Date.parse(transaction_params[:date]) ].compact.min
if @transaction.update(transaction_params)
@transaction.account.sync_later
@transaction.account.sync_later(sync_start_date)
format.html { redirect_to transaction_url(@transaction), notice: t(".success") }
format.turbo_stream do
@@ -102,8 +103,10 @@ class TransactionsController < ApplicationController
end
def destroy
@account = @transaction.account
sync_start_date = @account.transactions.where("date < ?", @transaction.date).order(date: :desc).first&.date
@transaction.destroy!
@transaction.account.sync_later
@account.sync_later(sync_start_date)
respond_to do |format|
format.html { redirect_to transactions_url, notice: t(".success") }

View File

@@ -1,11 +1,12 @@
class ValuationsController < ApplicationController
before_action :set_valuation, only: %i[ edit update destroy ]
def create
@account = Current.family.accounts.find(params[:account_id])
# TODO: placeholder logic until we have a better abstraction for trends
@valuation = @account.valuations.new(valuation_params.merge(currency: Current.family.currency))
if @valuation.save
@valuation.account.sync_later
@valuation.account.sync_later(@valuation.date)
respond_to do |format|
format.html { redirect_to account_path(@account), notice: "Valuation created" }
@@ -24,13 +25,12 @@ class ValuationsController < ApplicationController
end
def edit
@valuation = Valuation.find(params[:id])
end
def update
@valuation = Valuation.find(params[:id])
sync_start_date = [ @valuation.date, Date.parse(valuation_params[:date]) ].compact.min
if @valuation.update(valuation_params)
@valuation.account.sync_later
@valuation.account.sync_later(sync_start_date)
redirect_to account_path(@valuation.account), notice: "Valuation updated"
else
@@ -42,10 +42,10 @@ class ValuationsController < ApplicationController
end
def destroy
@valuation = Valuation.find(params[:id])
@account = @valuation.account
sync_start_date = @account.valuations.where("date < ?", @valuation.date).order(date: :desc).first&.date
@valuation.destroy!
@account.sync_later
@account.sync_later(sync_start_date)
respond_to do |format|
format.html { redirect_to account_path(@account), notice: "Valuation deleted" }
@@ -59,6 +59,11 @@ class ValuationsController < ApplicationController
end
private
# Use callbacks to share common setup or constraints between actions.
def set_valuation
@valuation = Valuation.find(params[:id])
end
def valuation_params
params.require(:valuation).permit(:date, :value)
end