QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-07-27 20:22:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix N+1 queries on categories index by batching lookups and removing … (#2163)

Browse Source 
* Fix N+1 queries on categories index by batching lookups and removing partial fallbacks

* resolve Codex review suggestion about Guard subcategory against missing parents

* resolve coderabbitai review suggestion - Guard against empty categories when computing category_ids_with_transactions

* resolve coderabbitai review suggestion - Redundant pb-4 makes the conditional dead code

* resolve coderabbitai caution on PR review

* resolve sure-design review - DS Drift Patrol

* fix conflicting hidden/flex classes

* resolve jjmata review suggestion - schema.rb noise

* fix conflict and adjust related parts

* Ignore Brakeman EOLRails warning for Rails 7.2
Restore ignore entry lost during merge from main; documents upgrade
tracking and matches brakeman 7.1.2 in Gemfile.lock.

* db migration executed

* Remove deprecated focus-ring override from goals color picker.
The summary_class override was reintroduced during merge conflict
resolution and clobbered DS::Disclosure's canonical focus styling.

* fix merge conflict on disclosure.rb

* Restore parent-based semantics while keeping the performance win for root categories

* fix(ci): skip scheduled preview cleanup on forks
Only run the hourly Cloudflare preview cleanup on we-promise/sure,
where the required secrets exist.

* Revert schema.rb dump noise unrelated to categories N+1 fix

Restore db/schema.rb from main so PostgreSQL check-constraint and
column-order churn does not obscure the real PR changes.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Remove obsolete Rails 7.2 EOLRails Brakeman ignore

Main is already on Rails 8.1, so the 7.2.3.1 ignore entry is no longer needed.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Address review: bare disclosure docs, category picker aria label

* fix(test): wait for async exchange rate updates in system test

* fix(test): retry account edit submit around Turbo morph races

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
William Wei Ming
2026-07-21 15:00:15 +07:00
committed by GitHub
parent c9c484010b
commit b613d107be
26 changed files with 222 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/javascript/controllers/color_icon_picker_controller.js
View File

@@ -152,10 +152,10 @@ export default class extends Controller {
"Poor contrast, choose darker color or auto-adjust.",
);
this.validationMessageTarget.classList.remove("hidden");
this.showFlex(this.validationMessageTarget);
} else {
this.colorInputTarget.setCustomValidity("");
this.validationMessageTarget.classList.add("hidden");
this.hideFlex(this.validationMessageTarget);
}
}
@@ -226,7 +226,7 @@ export default class extends Controller {
showPaletteSection() {
this.initPicker();
this.colorsSectionTarget.classList.add("hidden");
this.paletteSectionTarget.classList.remove("hidden");
this.showFlex(this.paletteSectionTarget);
this.pickerSectionTarget.classList.remove("hidden");
this.updatePopupPosition();
this.picker.show();
@@ -234,7 +234,7 @@ export default class extends Controller {
showColorsSection() {
this.colorsSectionTarget.classList.remove("hidden");
this.paletteSectionTarget.classList.add("hidden");
this.hideFlex(this.paletteSectionTarget);
this.pickerSectionTarget.classList.add("hidden");
this.updatePopupPosition()
if (this.picker) {
@@ -256,6 +256,16 @@ export default class extends Controller {
}
};
showFlex(element) {
element.classList.remove("hidden");
element.classList.add("flex");
}
hideFlex(element) {
element.classList.add("hidden");
element.classList.remove("flex");
}
updatePopupPosition() {
const popup = this.popupTarget;
popup.style.top = "";