mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 12:04:08 +00:00
Improve rules - add name, allow sorting, improve UI (#2177)
* Add ability to name a rule * Add sorting by name and date, * Improve rule page and form design * Small header tweak * Improve sorting click areas by including icon * Fix brakeman * Use icon helper instead of lucide_icon helper * Fix double headers with new DialogComponent * Use updated_at for sorting instead of created_at * Use copy-plus icon for compound rules * Remove icons and change IF/THEN/FOR font in edit form * Use text-secondary on disabled rules * First pass at redesigning the sorting menu * New rule list * Borders instead of shadows * Apply proper text color to TO in edit form * Improve dark mode with proper background color classes * Use border-secondary * Add touch: true to conditions and actions of a rule, so updated_at works as expected * Fix db schema * Change sort direction to be a LinkComponent outside of the form for better sort behavior * Clean up dropdown design to match figma * Match tags/categories design * Fix name text color, add bg-divider background for dividers * Fix family subscription tests (thanks zach!)
This commit is contained in:
committed by
GitHub
parent
050d5ebaad
commit
bebe7b40d6
@@ -8,7 +8,10 @@ class Rule < ApplicationRecord
|
||||
accepts_nested_attributes_for :conditions, allow_destroy: true
|
||||
accepts_nested_attributes_for :actions, allow_destroy: true
|
||||
|
||||
before_validation :normalize_name
|
||||
|
||||
validates :resource_type, presence: true
|
||||
validates :name, length: { minimum: 1 }, allow_nil: true
|
||||
validate :no_nested_compound_conditions
|
||||
|
||||
# Every rule must have at least 1 action
|
||||
@@ -99,4 +102,8 @@ class Rule < ApplicationRecord
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
def normalize_name
|
||||
self.name = nil if name.is_a?(String) && name.strip.empty?
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user