From c1adbefb0dd201fb63efae57cbe018b8df0a34a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Mata?= <juanjo.mata@gmail.com>
Date: Wed, 13 May 2026 18:48:04 +0200
Subject: [PATCH] Mobile releases workflow fix (#1790)

* Codex fix

* Handle immutable mobile release updates safely

* Handle gh release view failures before create/edit
---
 .github/workflows/mobile-release.yml | 69 ++++++++++++++++++++++++----
 1 file changed, 60 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/mobile-release.yml b/.github/workflows/mobile-release.yml
index 633a2bc71..3367a457c 100644
--- a/.github/workflows/mobile-release.yml
+++ b/.github/workflows/mobile-release.yml
@@ -170,13 +170,23 @@ jobs:
             exit 1
           fi
 
-      - name: Create GitHub Release
+      - name: Create or update GitHub Release
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
           set -euo pipefail
           VERSION="${{ steps.version.outputs.version }}"
           TAG="${{ steps.version.outputs.tag_name }}"
+          REPO="${{ github.repository }}"
+
+          mapfile -d '' -t RELEASE_ASSETS < <(
+            find "${{ runner.temp }}/release-assets" -maxdepth 1 -type f -print0
+          )
+
+          if [[ "${#RELEASE_ASSETS[@]}" -eq 0 ]]; then
+            echo "::error::No release assets were produced"
+            exit 1
+          fi
 
           cat > /tmp/release-notes.md <<NOTES
           ## Mobile-Only Release: ${VERSION}
@@ -194,17 +204,58 @@ jobs:
           # Strip heredoc indentation
           sed -i 's/^          //' /tmp/release-notes.md
 
-          PRERELEASE_FLAG=""
+          RELEASE_ARGS=(
+            "--repo"
+            "$REPO"
+            "--title"
+            "$TAG"
+            "--notes-file"
+            /tmp/release-notes.md
+          )
           if [[ "$TAG" == *"alpha"* ]] || [[ "$TAG" == *"beta"* ]] || [[ "$TAG" == *"rc"* ]]; then
-            PRERELEASE_FLAG="--prerelease"
+            RELEASE_ARGS+=("--prerelease")
           fi
 
-          gh release create "$TAG" \
-            --repo "${{ github.repository }}" \
-            --title "$TAG" \
-            --notes-file /tmp/release-notes.md \
-            $PRERELEASE_FLAG \
-            ${{ runner.temp }}/release-assets/*
+          if release_view_output="$(gh release view "$TAG" --repo "$REPO" 2>&1)"; then
+            is_immutable="$(gh release view "$TAG" --repo "$REPO" --json isImmutable --jq '.isImmutable')"
+            existing_assets="$(gh release view "$TAG" --repo "$REPO" --json assets --jq '.assets[].name')"
+            echo "Release ${TAG} already exists. Updating metadata."
+            gh release edit "$TAG" "${RELEASE_ARGS[@]}"
+
+            if [[ "$is_immutable" == "true" ]]; then
+              echo "Release is immutable. Verifying existing release assets are already present."
+              missing_assets=0
+              for asset in "${RELEASE_ASSETS[@]}"; do
+                asset_name="$(basename "$asset")"
+                if ! grep -Fxq "$asset_name" <<<"$existing_assets"; then
+                  echo "::error::Immutable release ${TAG} is missing asset: ${asset_name}"
+                  missing_assets=1
+                fi
+              done
+
+              if [[ "$missing_assets" != "0" ]]; then
+                echo "::error::Release assets cannot be changed on immutable releases. Recreate the release to update assets."
+                exit 1
+              fi
+
+              echo "Immutable release already has required assets. Skipping asset upload."
+              exit 0
+            fi
+          else
+            if ! echo "$release_view_output" | grep -Eiq "(not found|404)"; then
+              echo "::error::Failed to inspect existing release ${TAG}."
+              echo "$release_view_output"
+              exit 1
+            fi
+
+            echo "Creating release ${TAG} with attached assets."
+            gh release create "$TAG" "${RELEASE_ARGS[@]}" "${RELEASE_ASSETS[@]}"
+            exit 0
+          fi
+
+          for asset in "${RELEASE_ASSETS[@]}"; do
+            gh release upload "$TAG" "$asset" --repo "$REPO" --clobber
+          done
 
       - name: Checkout gh-pages branch
         uses: actions/checkout@v4