Add tests for TwelveData rate limit error handling

- Test rate limit error detection in Provider::TwelveData - Test error propagation in Security::Price::Importer - Test job retry configuration in SyncJob Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
2026-05-12 07:05:00 +00:00 · 2026-01-26 07:05:34 +00:00
parent 72d888b2ca
commit c46e8ab07c
3 changed files with 208 additions and 0 deletions
--- a/test/models/provider/twelve_data_test.rb
+++ b/test/models/provider/twelve_data_test.rb
@@ -0,0 +1,125 @@
+require "test_helper"
+
+class Provider::TwelveDataTest < ActiveSupport::TestCase
+  setup do
+    @provider = Provider::TwelveData.new("test_api_key")
+  end
+
+  # ================================
+  #    Rate Limit Error Tests
+  # ================================
+
+  test "raises RateLimitError on 429 response" do
+    # Mock a 429 rate limit response from the API
+    error_body = JSON.generate({
+      "code" => 429,
+      "message" => "You have run out of API credits for the current minute. 27 API credits were used, with the current limit being 8.",
+      "status" => "error"
+    })
+
+    faraday_error = Faraday::ClientError.new("the server responded with status 429")
+    faraday_error.instance_variable_set(:@response, {
+      status: 429,
+      body: error_body
+    })
+
+    @provider.stubs(:client).returns(mock_client = mock)
+    mock_client.stubs(:get).raises(faraday_error)
+
+    response = @provider.fetch_security_prices(
+      symbol: "AAPL",
+      exchange_operating_mic: "XNAS",
+      start_date: Date.parse("2024-01-01"),
+      end_date: Date.parse("2024-01-10")
+    )
+
+    assert_not response.success?
+    assert_instance_of Provider::TwelveData::RateLimitError, response.error
+    assert_match(/rate limit exceeded/i, response.error.message)
+  end
+
+  test "raises RateLimitError for exchange rates on 429 response" do
+    # Mock a 429 rate limit response
+    error_body = JSON.generate({
+      "code" => 429,
+      "message" => "Rate limit exceeded",
+      "status" => "error"
+    })
+
+    faraday_error = Faraday::ClientError.new("the server responded with status 429")
+    faraday_error.instance_variable_set(:@response, {
+      status: 429,
+      body: error_body
+    })
+
+    @provider.stubs(:client).returns(mock_client = mock)
+    mock_client.stubs(:get).raises(faraday_error)
+
+    response = @provider.fetch_exchange_rates(
+      from: "USD",
+      to: "EUR",
+      start_date: Date.parse("2024-01-01"),
+      end_date: Date.parse("2024-01-10")
+    )
+
+    assert_not response.success?
+    assert_instance_of Provider::TwelveData::RateLimitError, response.error
+  end
+
+  test "handles non-rate-limit errors normally" do
+    # Mock a 500 server error
+    error_body = JSON.generate({
+      "code" => 500,
+      "message" => "Internal server error",
+      "status" => "error"
+    })
+
+    faraday_error = Faraday::ServerError.new("the server responded with status 500")
+    faraday_error.instance_variable_set(:@response, {
+      status: 500,
+      body: error_body
+    })
+
+    @provider.stubs(:client).returns(mock_client = mock)
+    mock_client.stubs(:get).raises(faraday_error)
+
+    response = @provider.fetch_security_prices(
+      symbol: "AAPL",
+      exchange_operating_mic: "XNAS",
+      start_date: Date.parse("2024-01-01"),
+      end_date: Date.parse("2024-01-10")
+    )
+
+    assert_not response.success?
+    # Should be a regular error, not a RateLimitError
+    assert_instance_of Provider::TwelveData::Error, response.error
+    assert_not_instance_of Provider::TwelveData::RateLimitError, response.error
+  end
+
+  test "extracts error message from JSON response body" do
+    error_body = JSON.generate({
+      "code" => 429,
+      "message" => "Custom rate limit message",
+      "status" => "error"
+    })
+
+    faraday_error = Faraday::ClientError.new("the server responded with status 429")
+    faraday_error.instance_variable_set(:@response, {
+      status: 429,
+      body: error_body
+    })
+
+    @provider.stubs(:client).returns(mock_client = mock)
+    mock_client.stubs(:get).raises(faraday_error)
+
+    response = @provider.fetch_security_prices(
+      symbol: "AAPL",
+      exchange_operating_mic: "XNAS",
+      start_date: Date.parse("2024-01-01"),
+      end_date: Date.parse("2024-01-10")
+    )
+
+    assert_not response.success?
+    assert_match(/Custom rate limit message/, response.error.message)
+  end
+end