<%= t(".intro", rule: @rule.name.presence || @rule.primary_condition_title) %>
+ +| <%= t(".date") %> | +<%= t(".name") %> | +<%= t(".account") %> | +<%= t(".amount") %> | +
|---|---|---|---|
| <%= I18n.l(txn.entry.date, format: :long) %> | +<%= txn.entry.name %> | +<%= txn.entry.account.name %> | +<%= txn.entry.amount_money.format %> | +
+ <%= link_to t(".cta"), @transactions_url, class: "button" %> +
diff --git a/app/views/rule_notification_mailer/digest.text.erb b/app/views/rule_notification_mailer/digest.text.erb new file mode 100644 index 000000000..af0d03e86 --- /dev/null +++ b/app/views/rule_notification_mailer/digest.text.erb @@ -0,0 +1,9 @@ +<%= t(".heading", count: @transactions.size) %> + +<%= t(".intro", rule: @rule.name.presence || @rule.primary_condition_title) %> + +<% @transactions.each do |txn| %> +- <%= I18n.l(txn.entry.date, format: :long) %> | <%= txn.entry.name %> | <%= txn.entry.account.name %> | <%= txn.entry.amount_money.format %> +<% end %> + +<%= t(".cta") %>: <%= @transactions_url %> diff --git a/config/locales/mailers/rule_notification_mailer/en.yml b/config/locales/mailers/rule_notification_mailer/en.yml new file mode 100644 index 000000000..e8046a339 --- /dev/null +++ b/config/locales/mailers/rule_notification_mailer/en.yml @@ -0,0 +1,16 @@ +--- +en: + rule_notification_mailer: + digest: + subject: + one: "1 new transaction matched your rule on %{product_name}" + other: "%{count} new transactions matched your rule on %{product_name}" + heading: + one: "1 new transaction matched your rule" + other: "%{count} new transactions matched your rule" + intro: 'These transactions matched the rule "%{rule}":' + date: "Date" + name: "Name" + account: "Account" + amount: "Amount" + cta: "View transactions" diff --git a/db/migrate/20260627000000_create_notification_deliveries.rb b/db/migrate/20260627000000_create_notification_deliveries.rb new file mode 100644 index 000000000..dd6f2c249 --- /dev/null +++ b/db/migrate/20260627000000_create_notification_deliveries.rb @@ -0,0 +1,15 @@ +class CreateNotificationDeliveries < ActiveRecord::Migration[7.2] + def change + create_table :notification_deliveries, id: :uuid do |t| + t.references :rule, null: false, foreign_key: { on_delete: :cascade }, type: :uuid + # Transactions are deleted and re-ingested frequently during syncs, so we + # cascade rather than block their deletion. Dedup keys on this row id. + t.references :transaction, null: false, foreign_key: { on_delete: :cascade }, type: :uuid + + t.timestamps + end + + add_index :notification_deliveries, [ :rule_id, :transaction_id ], + unique: true, name: "index_notification_deliveries_on_rule_and_transaction" + end +end diff --git a/db/schema.rb b/db/schema.rb index db6128099..dd8ecc9d7 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -1406,6 +1406,16 @@ ActiveRecord::Schema[7.2].define(version: 2026_07_14_120000) do t.index ["user_id"], name: "index_mobile_devices_on_user_id" end + create_table "notification_deliveries", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t| + t.uuid "rule_id", null: false + t.uuid "transaction_id", null: false + t.datetime "created_at", null: false + t.datetime "updated_at", null: false + t.index ["rule_id", "transaction_id"], name: "index_notification_deliveries_on_rule_and_transaction", unique: true + t.index ["rule_id"], name: "index_notification_deliveries_on_rule_id" + t.index ["transaction_id"], name: "index_notification_deliveries_on_transaction_id" + end + create_table "oauth_access_grants", force: :cascade do |t| t.string "resource_owner_id", null: false t.bigint "application_id", null: false @@ -2295,6 +2305,8 @@ ActiveRecord::Schema[7.2].define(version: 2026_07_14_120000) do add_foreign_key "mercury_items", "families" add_foreign_key "messages", "chats" add_foreign_key "mobile_devices", "users" + add_foreign_key "notification_deliveries", "rules", on_delete: :cascade + add_foreign_key "notification_deliveries", "transactions", on_delete: :cascade add_foreign_key "oauth_access_grants", "oauth_applications", column: "application_id" add_foreign_key "oauth_access_tokens", "oauth_applications", column: "application_id" add_foreign_key "oidc_identities", "users" diff --git a/test/mailers/rule_notification_mailer_test.rb b/test/mailers/rule_notification_mailer_test.rb new file mode 100644 index 000000000..bc1580e8c --- /dev/null +++ b/test/mailers/rule_notification_mailer_test.rb @@ -0,0 +1,78 @@ +require "test_helper" + +class RuleNotificationMailerTest < ActionMailer::TestCase + include EntriesTestHelper + + test "digest" do + rule = rules(:one) + rule.update!(name: "Coffee rule") + family = rule.family + admin = family.users.find_by(role: %w[admin super_admin]) + account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new) + txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction + + mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ]) + + # The mailer derives the recipient from rule.family, so assert against that + # admin explicitly rather than an unrelated fixture. + assert_equal [ admin.email ], mail.to + assert_equal I18n.t( + "rule_notification_mailer.digest.subject", + count: 1, + product_name: Rails.configuration.x.product_name + ), mail.subject + assert_match "Coffee", mail.body.encoded + + # The "View transactions" CTA must link to the transactions page in both parts. + html = mail.html_part.body.encoded + text = mail.text_part.body.encoded + assert_match I18n.t("rule_notification_mailer.digest.cta"), html + assert_match %r{/transactions}, html + assert_match %r{/transactions}, text + end + + test "digest is delivered to the super_admin owner when there is no plain admin" do + # A self-hosted family is commonly a single super_admin (the owner) with no + # :admin user. The owner must still receive the digest. + family = Family.create!(name: "Solo owner family", currency: "USD") + owner = User.create!(family: family, email: "solo-owner@example.com", password: "password123", role: :super_admin) + account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new) + txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction + rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule") + + mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ]) + + assert_equal [ owner.email ], mail.to + end + + test "digest recipient is an admin-level user when both admin and super_admin exist" do + # find_by(role: %w[admin super_admin]) has no ORDER BY, so which of the two + # is returned is not deterministic and precedence is intentionally undefined. + # The contract is only that the recipient is admin-level, never a member. + family = Family.create!(name: "Mixed roles family", currency: "USD") + User.create!(family: family, email: "the-admin@example.com", password: "password123", role: :admin) + User.create!(family: family, email: "the-super-admin@example.com", password: "password123", role: :super_admin) + User.create!(family: family, email: "the-member@example.com", password: "password123", role: :member) + account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new) + txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction + rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule") + + mail = RuleNotificationMailer.digest(rule: rule, transactions: [ txn ]) + + recipient = family.users.find_by!(email: mail.to.first) + assert recipient.admin?, "expected an admin-level recipient, got role=#{recipient.role}" + end + + test "digest is skipped when the family has no admin or super_admin" do + # Transaction details must never go to a regular member/guest. + family = Family.create!(name: "No-admin family", currency: "USD") + User.create!(family: family, email: "member-only@example.com", password: "password123", role: :member) + account = family.accounts.create!(name: "Mailer test", balance: 100, currency: "USD", accountable: Depository.new) + txn = create_transaction(date: Date.current, account: account, amount: 100, name: "Coffee").transaction + rule = Rule.new(family: family, resource_type: "transaction", name: "Coffee rule") + + assert_no_emails do + RuleNotificationMailer.digest(rule: rule, transactions: [ txn ]).deliver_now + end + end +end diff --git a/test/models/rule/action_executor/send_email_notification_test.rb b/test/models/rule/action_executor/send_email_notification_test.rb new file mode 100644 index 000000000..f024ab821 --- /dev/null +++ b/test/models/rule/action_executor/send_email_notification_test.rb @@ -0,0 +1,84 @@ +require "test_helper" + +class Rule::ActionExecutor::SendEmailNotificationTest < ActiveSupport::TestCase + include EntriesTestHelper, ActiveJob::TestHelper + + setup do + @family = families(:dylan_family) + @rule = rules(:one) + @account = @family.accounts.create!(name: "Notify test", balance: 1000, currency: "USD", accountable: Depository.new) + @txn1 = create_transaction(date: Date.current, account: @account, amount: 100, name: "Coffee").transaction + @scope = @account.transactions + end + + def action + Rule::Action.new(rule: @rule, action_type: "send_email_notification") + end + + test "enqueues one digest job for new matches, records deliveries, returns integer count" do + result = nil + + assert_difference -> { NotificationDelivery.where(rule: @rule).count }, 1 do + assert_enqueued_with(job: RuleEmailNotificationJob) do + result = action.apply(@scope) + end + end + + assert_equal 1, result + assert_includes NotificationDelivery.where(rule: @rule).pluck(:transaction_id), @txn1.id + end + + test "dedup suppresses repeat sends across runs" do + action.apply(@scope) + + result = nil + assert_no_enqueued_jobs only: RuleEmailNotificationJob do + result = action.apply(@scope) + end + + assert_equal 0, result + assert_equal 1, NotificationDelivery.where(rule: @rule).count + end + + test "only newly appearing transactions trigger a job" do + action.apply(@scope) # baseline: txn1 recorded + enqueued + + txn2 = create_transaction(date: Date.current, account: @account, amount: 50, name: "Lunch").transaction + + result = nil + # Only txn2 (the newly appearing match) may be enqueued — never the already + # notified txn1. Asserting the args, not just the job class, locks that down. + assert_enqueued_with(job: RuleEmailNotificationJob, args: [ @rule.id, [ txn2.id ] ]) do + result = action.apply(@scope) + end + + assert_equal 1, result + recorded = NotificationDelivery.where(rule: @rule).pluck(:transaction_id) + assert_includes recorded, txn2.id + assert_equal 2, recorded.size + end + + test "pre-seed watermark records existing matches without sending so history never emails" do + # after_create_commit does not fire under transactional tests (the wrapping + # transaction never commits), so invoke the seeding path directly to verify + # the watermark behavior the callback performs in production. + rule = @family.rules.create!( + resource_type: "transaction", + actions_attributes: [ { action_type: "send_email_notification" } ] + ) + seed_action = rule.actions.first + + assert_no_enqueued_jobs only: RuleEmailNotificationJob do + seed_action.send(:seed_notification_baseline) + end + + # Pre-existing @txn1 is now watermarked, so a subsequent run sends nothing. + result = nil + assert_no_enqueued_jobs only: RuleEmailNotificationJob do + result = Rule::Action.new(rule: rule, action_type: "send_email_notification").apply(@scope) + end + + assert_equal 0, result + assert_includes NotificationDelivery.where(rule: rule).pluck(:transaction_id), @txn1.id + end +end