QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-20 20:44:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Account Holding validation and synchronization (#1818)

Browse Source 
* Fix Account Holding validation and synchronization

Fixes #1781

- Add comprehensive validations for Account::Holding
- Implement validation to ensure amount matches qty * price
- Update Account::Syncer to include qty and price during synchronization
- Add database constraints for holding attributes and calculations

* Remove database check constraints for Account Holdings

Align with project convention of keeping complex validations in ActiveRecord
- Remove database-level check constraints for quantity, price, and amount
- Maintain database-level null and unique constraints
- Prepare for more flexible validation in the model layer
This commit is contained in:
Josh Pigford
2025-02-07 10:42:01 -06:00
committed by GitHub
parent 0dc25cda22
commit cf23673003
6 changed files with 67 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/models/account/syncer_test.rb
View File

@@ -29,8 +29,8 @@ class Account::SyncerTest < ActiveSupport::TestCase
Account::HoldingCalculator.any_instance.expects(:calculate).returns(
[
Account::Holding.new(security: securities(:aapl), date: 1.day.ago.to_date, amount: 500, currency: "EUR"),
Account::Holding.new(security: securities(:aapl), date: Date.current, amount: 500, currency: "EUR")
Account::Holding.new(security: securities(:aapl), date: 1.day.ago.to_date, qty: 10, price: 50, amount: 500, currency: "EUR"),
Account::Holding.new(security: securities(:aapl), date: Date.current, qty: 10, price: 50, amount: 500, currency: "EUR")
]
)