From d09765a14cd4bec8d37a5fefe58b637a8bfd62c2 Mon Sep 17 00:00:00 2001
From: "sentry[bot]" <39604003+sentry[bot]@users.noreply.github.com>
Date: Thu, 5 Feb 2026 19:47:01 +0100
Subject: [PATCH] Add mailer subject tests and refine i18n keys (#910)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add mailer subject tests and refine i18n keys

* Linter

* Fix test

* More fixes

* More fixes

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
---
 app/mailers/invitation_mailer.rb               |  2 +-
 app/mailers/pdf_import_mailer.rb               |  2 +-
 .../invitation_mailer/invite_email.html.erb    |  2 +-
 .../locales/mailers/pdf_import_mailer/en.yml   |  2 +-
 test/mailers/invitation_mailer_test.rb         | 18 ++++++++++++++++++
 test/mailers/pdf_import_mailer_test.rb         |  4 ++++
 6 files changed, 26 insertions(+), 4 deletions(-)
 create mode 100644 test/mailers/invitation_mailer_test.rb

diff --git a/app/mailers/invitation_mailer.rb b/app/mailers/invitation_mailer.rb
index 9b90676c5..0fb7589f6 100644
--- a/app/mailers/invitation_mailer.rb
+++ b/app/mailers/invitation_mailer.rb
@@ -8,7 +8,7 @@ class InvitationMailer < ApplicationMailer
       subject: t(
         ".subject",
         inviter: @invitation.inviter.display_name,
-        product: product_name
+        product_name: product_name
       )
     )
   end
diff --git a/app/mailers/pdf_import_mailer.rb b/app/mailers/pdf_import_mailer.rb
index 5f9f759d7..aeae3f5d6 100644
--- a/app/mailers/pdf_import_mailer.rb
+++ b/app/mailers/pdf_import_mailer.rb
@@ -6,7 +6,7 @@ class PdfImportMailer < ApplicationMailer
 
     mail(
       to: @user.email,
-      subject: t(".subject", product: product_name)
+      subject: t(".subject", product_name: product_name)
     )
   end
 end
diff --git a/app/views/invitation_mailer/invite_email.html.erb b/app/views/invitation_mailer/invite_email.html.erb
index b6741f236..dafb379ee 100644
--- a/app/views/invitation_mailer/invite_email.html.erb
+++ b/app/views/invitation_mailer/invite_email.html.erb
@@ -1,4 +1,4 @@
-<h1><%= t(".greeting", product: product_name) %></h1>
+<h1><%= t(".greeting", product_name: product_name) %></h1>
 
 <p>
   <%= t(
diff --git a/config/locales/mailers/pdf_import_mailer/en.yml b/config/locales/mailers/pdf_import_mailer/en.yml
index 1399d306b..401b03efc 100644
--- a/config/locales/mailers/pdf_import_mailer/en.yml
+++ b/config/locales/mailers/pdf_import_mailer/en.yml
@@ -2,4 +2,4 @@
 en:
   pdf_import_mailer:
     next_steps:
-      subject: "Your PDF document has been analyzed - %{product}"
+      subject: "Your PDF document has been analyzed - %{product_name}"
diff --git a/test/mailers/invitation_mailer_test.rb b/test/mailers/invitation_mailer_test.rb
new file mode 100644
index 000000000..485f20329
--- /dev/null
+++ b/test/mailers/invitation_mailer_test.rb
@@ -0,0 +1,18 @@
+require "test_helper"
+
+class InvitationMailerTest < ActionMailer::TestCase
+  test "invite_email" do
+    invitation = invitations(:one)
+
+    mail = InvitationMailer.invite_email(invitation)
+
+    assert_equal I18n.t(
+      "invitation_mailer.invite_email.subject",
+      inviter: invitation.inviter.display_name,
+      product_name: Rails.configuration.x.product_name
+    ), mail.subject
+    assert_equal [ invitation.email ], mail.to
+    assert_equal [ "hello@example.com" ], mail.from
+    assert_match "accept", mail.body.encoded
+  end
+end
diff --git a/test/mailers/pdf_import_mailer_test.rb b/test/mailers/pdf_import_mailer_test.rb
index d5d118b27..1aa9c8561 100644
--- a/test/mailers/pdf_import_mailer_test.rb
+++ b/test/mailers/pdf_import_mailer_test.rb
@@ -9,6 +9,10 @@ class PdfImportMailerTest < ActionMailer::TestCase
   test "next_steps email is sent to user" do
     mail = PdfImportMailer.with(user: @user, pdf_import: @pdf_import).next_steps
 
+    assert_equal I18n.t(
+      "pdf_import_mailer.next_steps.subject",
+      product_name: Rails.configuration.x.product_name
+    ), mail.subject
     assert_equal [ @user.email ], mail.to
     assert_includes mail.subject, "analyzed"
   end