From d3c4986bfdb276475d6bd2bd02f8d63d57dffe44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Mata?= <juanjo.mata@gmail.com>
Date: Wed, 11 Feb 2026 19:42:26 +0100
Subject: [PATCH] Fix flaky expectations in import-related tests (#963)

---
 test/controllers/imports_controller_test.rb |  5 +++--
 test/jobs/process_pdf_job_test.rb           | 17 +++++++++++++----
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/test/controllers/imports_controller_test.rb b/test/controllers/imports_controller_test.rb
index 2b68173a7..8c3738519 100644
--- a/test/controllers/imports_controller_test.rb
+++ b/test/controllers/imports_controller_test.rb
@@ -40,11 +40,12 @@ class ImportsControllerTest < ActionDispatch::IntegrationTest
     adapter.stubs(:supported_extensions).returns(%w[.csv .pdf])
     VectorStore::Registry.stubs(:adapter).returns(adapter)
 
-    @user.family.expects(:upload_document).with do |file_content:, filename:, **|
+    family_document = family_documents(:tax_return)
+    Family.any_instance.expects(:upload_document).with do |file_content:, filename:, **|
       assert_not_empty file_content
       assert_equal "valid.csv", filename
       true
-    end.returns(family_documents(:tax_return))
+    end.returns(family_document)
 
     assert_no_difference "Import.count" do
       post imports_url, params: {
diff --git a/test/jobs/process_pdf_job_test.rb b/test/jobs/process_pdf_job_test.rb
index 9fc2a40b7..29d4a4977 100644
--- a/test/jobs/process_pdf_job_test.rb
+++ b/test/jobs/process_pdf_job_test.rb
@@ -58,9 +58,18 @@ class ProcessPdfJobTest < ActiveJob::TestCase
     process_result = Struct.new(:document_type).new("bank_statement")
 
     @import.expects(:process_with_ai).once.returns(process_result)
-    @import.expects(:extract_transactions).once
-    @import.expects(:generate_rows_from_extracted_data).once do
-      @import.update_column(:rows_count, 1)
+    @import.expects(:extract_transactions).once do
+      @import.update!(
+        extracted_data: {
+          "transactions" => [
+            {
+              "date" => "2024-01-01",
+              "amount" => "10.00",
+              "name" => "Coffee Shop"
+            }
+          ]
+        }
+      )
     end
     @import.expects(:sync_mappings).once
     @import.stubs(:send_next_steps_email)
@@ -74,7 +83,7 @@ class ProcessPdfJobTest < ActiveJob::TestCase
 
     ProcessPdfJob.perform_now(@import)
 
-    assert_equal "pending", @import.reload.status
+    assert_equal "complete", @import.reload.status
   end
 
   private