From dc1db385176cdceb3613d5b1fe904c42e8992f41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Jos=C3=A9=20Mata?= Date: Mon, 17 Nov 2025 18:20:39 +0100 Subject: [PATCH] Add UI clarity for non-cash account balance tracking (#336) * Add UI clarity for non-cash account balance tracking Fixes issue #164 where users were confused that transactions don't update the balance for "Other Assets" accounts. This is by design - non-cash accounts (Other Assets, Properties, Vehicles, Loans, Other Liabilities) are tracked via manual valuations, not transactions. Changes: - Add informational alert to Other Assets creation/edit forms - Add informational alert to account activity page for all non-cash accounts - Alert explains that balance updates require "New Balance" entries - Added i18n strings for alerts in English locale files The alert uses the existing DS::Alert component with info variant to provide clear, non-intrusive guidance to users about how these account types work. * Add spacing to bottom of alert * Update copy to avoid repetition. * Another spacing addition * Leave dead code alone --------- Co-authored-by: Claude --- app/views/other_assets/edit.html.erb | 5 ++++- app/views/other_assets/new.html.erb | 5 ++++- config/locales/views/other_assets/en.yml | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/views/other_assets/edit.html.erb b/app/views/other_assets/edit.html.erb index 930ce27aa..4ec4161f5 100644 --- a/app/views/other_assets/edit.html.erb +++ b/app/views/other_assets/edit.html.erb @@ -1,6 +1,9 @@ <%= render DS::Dialog.new do |dialog| %> <% dialog.with_header(title: t(".edit", account: @account.name)) %> <% dialog.with_body do %> - <%= render "form", account: @account, url: other_asset_path(@account) %> +
+ <%= render DS::Alert.new(message: t(".balance_tracking_info"), variant: :info) %> + <%= render "form", account: @account, url: other_asset_path(@account) %> +
<% end %> <% end %> diff --git a/app/views/other_assets/new.html.erb b/app/views/other_assets/new.html.erb index 75737adab..7377c88e0 100644 --- a/app/views/other_assets/new.html.erb +++ b/app/views/other_assets/new.html.erb @@ -1,6 +1,9 @@ <%= render DS::Dialog.new do |dialog| %> <% dialog.with_header(title: t(".title")) %> <% dialog.with_body do %> - <%= render "form", account: @account, url: other_assets_path %> +
+ <%= render DS::Alert.new(message: t(".balance_tracking_info"), variant: :info) %> + <%= render "form", account: @account, url: other_assets_path %> +
<% end %> <% end %> diff --git a/config/locales/views/other_assets/en.yml b/config/locales/views/other_assets/en.yml index be3f0f431..a04066b9a 100644 --- a/config/locales/views/other_assets/en.yml +++ b/config/locales/views/other_assets/en.yml @@ -3,5 +3,7 @@ en: other_assets: edit: edit: Edit %{account} + balance_tracking_info: "Other Assets are tracked via manual valuations using 'New Balance', not transactions. Cashflow will not affect the account balance." new: title: Enter asset details + balance_tracking_info: "Other Assets are tracked via manual valuations using 'New Balance', not transactions. Cashflow will not affect the account balance."