QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 12:04:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix unable to create Deposit entries in investment portfolio (#1125)

Browse Source 
* Fix unable to create Deposit entries in investment portfolio

* Add system test for deposit transaction
This commit is contained in:
Tony Vincent
2024-08-25 23:48:46 +02:00
committed by GitHub
parent 52c729dc33
commit e1efe97e6f
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/account/transaction_builder.rb
View File

@@ -21,7 +21,7 @@ class Account::TransactionBuilder
end end
def create_transfer def create_transfer
return create_unlinked_transfer(account.id, signed_amount) unless transfer_account_id return create_unlinked_transfer(account.id, signed_amount) if transfer_account_id.blank?
from_account_id = type == "transfer_in" ? transfer_account_id : account.id from_account_id = type == "transfer_in" ? transfer_account_id : account.id
to_account_id = type == "transfer_in" ? account.id : transfer_account_id to_account_id = type == "transfer_in" ? account.id : transfer_account_id

18
test/system/transactions_test.rb
View File

@@ -150,6 +150,24 @@ class TransactionsTest < ApplicationSystemTestCase
assert_selection_count(0) assert_selection_count(0)
end end
test "can create deposit transaction for investment account" do
investment_account = accounts(:investment)
transfer_date = Date.current
visit account_path(investment_account)
click_on "New transaction"
select "Deposit", from: "Type"
fill_in "Date", with: transfer_date
fill_in "account_entry[amount]", with: 175.25
click_button "Add transaction"
within "#account_" + investment_account.id do
click_on "Transactions"
end
within "#entry-group-" + transfer_date.to_s do
assert_text "175.25"
end
end
private private
def create_transaction(name, date, amount, category: nil, merchant: nil, tags: []) def create_transaction(name, date, amount, category: nil, merchant: nil, tags: [])