Auto sync preference, max limit on account CSV imports (#2259)

* Auto sync preference, max limit on account CSV imports

* MaxRowCountExceededError
This commit is contained in:
Zach Gollwitzer
2025-05-18 15:02:51 -04:00
committed by GitHub
parent f82f77466a
commit e26e5c5aec
7 changed files with 35 additions and 1 deletions

View File

@@ -54,4 +54,8 @@ class AccountImport < Import
CSV.parse(template, headers: true)
end
def max_row_count
50
end
end

View File

@@ -1,4 +1,6 @@
class Import < ApplicationRecord
MaxRowCountExceededError = Class.new(StandardError)
TYPES = %w[TransactionImport TradeImport AccountImport MintImport].freeze
SIGNAGE_CONVENTIONS = %w[inflows_positive inflows_negative]
SEPARATORS = [ [ "Comma (,)", "," ], [ "Semicolon (;)", ";" ] ].freeze
@@ -52,6 +54,7 @@ class Import < ApplicationRecord
end
def publish_later
raise MaxRowCountExceededError if row_count_exceeded?
raise "Import is not publishable" unless publishable?
update! status: :importing
@@ -60,6 +63,8 @@ class Import < ApplicationRecord
end
def publish
raise MaxRowCountExceededError if row_count_exceeded?
import!
family.sync_later
@@ -220,7 +225,15 @@ class Import < ApplicationRecord
)
end
def max_row_count
10000
end
private
def row_count_exceeded?
rows.count > max_row_count
end
def import!
# no-op, subclasses can implement for customization of algorithm
end