QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-07-19 00:05:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix fee display consistency, derive fees from entries, clean schema churn

Browse Source 
- Show principal-only transfer amounts on both sides with separate fee and total lines (fixes inconsistent gross/net convention)
- Derive displayed fee amounts from fee_transactions entries (single source of truth) instead of stored columns
- Remove stored source_fee_amount/destination_fee_amount columns from transfers table
- Add foreign key for transactions.transfer_id -> transfers.id (replaces invalid CHECK subquery)
- Move destination fee line inside destination side div for consistent layout
- Remove orphaned view_fee_transaction locale keys from 7 locale files
- Rebuild schema.rb from origin/main to eliminate unrelated column reordering churn
This commit is contained in:
DataEnginr
2026-06-28 19:47:53 +00:00
parent 75234dab19
commit e75f2a0c78
18 changed files with 924 additions and 1049 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/controllers/transfers_controller_test.rb
View File

@@ -164,9 +164,9 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
end
transfer = Transfer.order(created_at: :desc).first
assert_equal 3, transfer.source_fee_amount
assert_equal 0, transfer.destination_fee_amount
assert_equal 100, transfer.amount
assert_equal 3, transfer.derived_source_fee_amount
assert_equal 0, transfer.derived_destination_fee_amount
# Outflow should be principal only (no fee baked in)
assert_equal 100, transfer.outflow_transaction.entry.amount
# Inflow should be -(converted_principal)
@@ -177,9 +177,6 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
assert_equal "standard", fee_tx.kind
assert_equal 3, fee_tx.entry.amount
assert_equal accounts(:depository).id, fee_tx.entry.account_id
# Derived fee methods match stored amounts
assert_equal 3, transfer.derived_source_fee_amount
assert_equal 0, transfer.derived_destination_fee_amount
assert transfer.has_source_fee?
assert_not transfer.has_destination_fee?
end
@@ -198,9 +195,9 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
end
transfer = Transfer.order(created_at: :desc).first
assert_equal 0, transfer.source_fee_amount
assert_equal 3, transfer.destination_fee_amount
assert_equal 100, transfer.amount
assert_equal 0, transfer.derived_source_fee_amount
assert_equal 3, transfer.derived_destination_fee_amount
# Outflow should be principal only
assert_equal 100, transfer.outflow_transaction.entry.amount
# Inflow should be -(converted_principal)
@@ -211,9 +208,6 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
assert_equal "standard", fee_tx.kind
assert_equal 3, fee_tx.entry.amount
assert_equal accounts(:credit_card).id, fee_tx.entry.account_id
# Derived fee methods match stored amounts
assert_equal 0, transfer.derived_source_fee_amount
assert_equal 3, transfer.derived_destination_fee_amount
assert_not transfer.has_source_fee?
assert transfer.has_destination_fee?
end
@@ -233,9 +227,9 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
end
transfer = Transfer.order(created_at: :desc).first
assert_equal 2, transfer.source_fee_amount
assert_equal 3, transfer.destination_fee_amount
assert_equal 100, transfer.amount
assert_equal 2, transfer.derived_source_fee_amount
assert_equal 3, transfer.derived_destination_fee_amount
# Outflow should be principal only
assert_equal 100, transfer.outflow_transaction.entry.amount
# Inflow should be -(converted_principal)
@@ -246,9 +240,6 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
dest_fee_tx = transfer.fee_transactions.find { |t| t.entry.account_id == accounts(:credit_card).id }
assert_equal 2, source_fee_tx.entry.amount
assert_equal 3, dest_fee_tx.entry.amount
# Derived fee methods match stored amounts
assert_equal 2, transfer.derived_source_fee_amount
assert_equal 3, transfer.derived_destination_fee_amount
assert transfer.has_fees?
end
@@ -270,11 +261,9 @@ class TransfersControllerTest < ActionDispatch::IntegrationTest
fee_tx = transfer.fee_transactions.first
fee_tx.entry.update!(amount: 5)
# Derived fee should reflect the updated entry, not the stored column
# Derived fee should reflect the updated entry
transfer.reload
assert_equal 5, transfer.derived_source_fee_amount
# Stored column remains unchanged
assert_equal 3, transfer.source_fee_amount
assert transfer.has_source_fee?
end