<%= label_tag "account_types[#{enable_banking_account.id}]", "Account Type:",
class: "block text-sm font-medium text-primary mb-2" %>
<%= select_tag "account_types[#{enable_banking_account.id}]",
- options_for_select(@account_type_options, "skip"),
+ options_for_select(@account_type_options, enable_banking_account.suggested_account_type || "skip"),
{ class: "appearance-none bg-container border border-primary rounded-md px-3 py-2 text-sm leading-6 text-primary focus:border-primary focus:ring-1 focus:ring-primary focus:outline-none w-full",
data: {
action: "change->account-type-selector#updateSubtype"
diff --git a/config/locales/views/enable_banking_items/en.yml b/config/locales/views/enable_banking_items/en.yml
index dfbcd8501..b143fe1a8 100644
--- a/config/locales/views/enable_banking_items/en.yml
+++ b/config/locales/views/enable_banking_items/en.yml
@@ -2,8 +2,9 @@
en:
enable_banking_items:
authorize:
- authorization_failed: Failed to initiate authorization
+ authorization_failed: "Failed to initiate authorization: %{message}"
bank_required: Please select a bank.
+ decoupled_not_supported: This bank uses a separate device authentication method which is not yet supported. Please add this account manually.
invalid_redirect: The authorization URL received is invalid. Please try again.
redirect_uri_not_allowed: Redirect not allowed. Please configure `%{callback_url}` in your Enable Banking app settings.
unexpected_error: An unexpected error occurred. Please try again.
@@ -39,11 +40,17 @@ en:
invalid_redirect: The authorization URL received is invalid. Please try again.
reauthorization_failed: Reauthorization failed
select_bank:
+ beta_label: Beta
cancel: Cancel
check_country: Please check your country code settings.
credentials_required: Please configure your Enable Banking credentials first.
description: Select the bank you want to connect to your accounts.
no_banks: No banks available for this country/region.
+ no_search_results: No banks match your search.
+ search_label: Search for your bank
+ search_placeholder: Search for your bank...
title: Select Your Bank
+ setup_accounts:
+ psd2_savings_notice: "Note: Some regulated French savings accounts (Livret A, PEL, LEP, LDDS) may have limited or no access via Open Banking (PSD2). If a savings account is missing, you can add it manually."
update:
success: Enable Banking configuration updated.
diff --git a/config/locales/views/enable_banking_items/fr.yml b/config/locales/views/enable_banking_items/fr.yml
index d4e3bccb0..1d68e177c 100644
--- a/config/locales/views/enable_banking_items/fr.yml
+++ b/config/locales/views/enable_banking_items/fr.yml
@@ -4,6 +4,7 @@ fr:
authorize:
authorization_failed: Échec de l'initiation de l'autorisation
bank_required: Veuillez sélectionner une banque.
+ decoupled_not_supported: Cette banque utilise une méthode d'authentification sur un appareil séparé qui n'est pas encore prise en charge. Veuillez ajouter ce compte manuellement.
invalid_redirect: L'URL d'autorisation reçue est invalide. Veuillez réessayer.
redirect_uri_not_allowed: Redirection non autorisée. Veuillez configurer `%{callback_url}` dans les paramètres de votre application Enable Banking.
unexpected_error: Une erreur inattendue s'est produite. Veuillez réessayer.
@@ -39,11 +40,17 @@ fr:
invalid_redirect: L'URL d'autorisation reçue est invalide. Veuillez réessayer.
reauthorization_failed: Échec de la réautorisation
select_bank:
+ beta_label: Bêta
cancel: Annuler
check_country: Veuillez vérifier les paramètres de votre code pays.
credentials_required: Veuillez d'abord configurer vos identifiants Enable Banking.
description: Sélectionnez la banque que vous souhaitez connecter à vos comptes.
no_banks: Aucune banque disponible pour ce pays/région.
+ no_search_results: "Aucun établissement ne correspond à votre recherche."
+ search_placeholder: Recherchez votre banque...
+ search_label: "Rechercher votre banque"
title: Sélectionnez votre banque
+ setup_accounts:
+ psd2_savings_notice: "Remarque : Certains comptes d'épargne réglementés français (Livret A, PEL, LEP, LDDS) peuvent avoir un accès limité ou inexistant via l'Open Banking (DSP2). Si un compte d'épargne est manquant, vous pouvez l'ajouter manuellement."
update:
success: Configuration d'Enable Banking mise à jour.
diff --git a/db/migrate/20260405120000_add_aspsp_metadata_to_enable_banking.rb b/db/migrate/20260405120000_add_aspsp_metadata_to_enable_banking.rb
new file mode 100644
index 000000000..b1553e87e
--- /dev/null
+++ b/db/migrate/20260405120000_add_aspsp_metadata_to_enable_banking.rb
@@ -0,0 +1,35 @@
+class AddAspspMetadataToEnableBanking < ActiveRecord::Migration[7.2]
+ def change
+ # ASPSP-level metadata on the item (stored when user selects a bank)
+ add_column :enable_banking_items, :aspsp_required_psu_headers, :jsonb, default: []
+ add_column :enable_banking_items, :aspsp_maximum_consent_validity, :integer # in seconds
+ add_column :enable_banking_items, :aspsp_auth_approach, :string # REDIRECT | EMBEDDED | DECOUPLED
+ add_column :enable_banking_items, :aspsp_psu_types, :jsonb, default: []
+ # PII/GDPR Notice: last_psu_ip stores the user's IP address.
+ # - Required for the Psu-Ip-Address header in Enable Banking API requests
+ # - Must be declared in the privacy policy
+ # - Data retention: consider nullifying after session expiry or 90 days
+ add_column :enable_banking_items, :last_psu_ip, :string # user IP captured at request time
+
+ # Fix sync_start_date type: was datetime, should be date
+ reversible do |dir|
+ dir.up do
+ # Truncate any non-midnight time components before converting datetime→date.
+ # sync_start_date is a user-configured date — time components are meaningless.
+ execute(<<~SQL)
+ UPDATE enable_banking_items
+ SET sync_start_date = DATE_TRUNC('day', sync_start_date)
+ WHERE sync_start_date IS NOT NULL
+ AND sync_start_date != DATE_TRUNC('day', sync_start_date)
+ SQL
+ change_column :enable_banking_items, :sync_start_date, :date
+ end
+ dir.down { change_column :enable_banking_items, :sync_start_date, :datetime }
+ end
+
+ # Account-level fields from AccountResource
+ add_column :enable_banking_accounts, :product, :string # bank's proprietary product name
+ add_column :enable_banking_accounts, :credit_limit, :decimal, precision: 19, scale: 4
+ add_column :enable_banking_accounts, :identification_hashes, :jsonb, default: []
+ end
+end
diff --git a/db/migrate/20260406120000_add_psu_type_to_enable_banking_items.rb b/db/migrate/20260406120000_add_psu_type_to_enable_banking_items.rb
new file mode 100644
index 000000000..2767601c0
--- /dev/null
+++ b/db/migrate/20260406120000_add_psu_type_to_enable_banking_items.rb
@@ -0,0 +1,5 @@
+class AddPsuTypeToEnableBankingItems < ActiveRecord::Migration[7.2]
+ def change
+ add_column :enable_banking_items, :psu_type, :string
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index cd59bffdc..ba39edf6d 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -403,6 +403,9 @@ ActiveRecord::Schema[7.2].define(version: 2026_04_10_114435) do
t.jsonb "raw_transactions_payload"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
+ t.string "product"
+ t.decimal "credit_limit", precision: 19, scale: 4
+ t.jsonb "identification_hashes", default: []
t.index ["account_id"], name: "index_enable_banking_accounts_on_account_id"
t.index ["enable_banking_item_id"], name: "index_enable_banking_accounts_on_enable_banking_item_id"
end
@@ -418,7 +421,7 @@ ActiveRecord::Schema[7.2].define(version: 2026_04_10_114435) do
t.string "status", default: "good"
t.boolean "scheduled_for_deletion", default: false
t.boolean "pending_account_setup", default: false
- t.datetime "sync_start_date"
+ t.date "sync_start_date"
t.jsonb "raw_payload"
t.jsonb "raw_institution_payload"
t.string "country_code"
@@ -431,6 +434,12 @@ ActiveRecord::Schema[7.2].define(version: 2026_04_10_114435) do
t.string "authorization_id"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
+ t.jsonb "aspsp_required_psu_headers", default: []
+ t.integer "aspsp_maximum_consent_validity"
+ t.string "aspsp_auth_approach"
+ t.jsonb "aspsp_psu_types", default: []
+ t.string "last_psu_ip"
+ t.string "psu_type"
t.index ["family_id"], name: "index_enable_banking_items_on_family_id"
t.index ["status"], name: "index_enable_banking_items_on_status"
end
diff --git a/test/models/enable_banking_account/processor_test.rb b/test/models/enable_banking_account/processor_test.rb
new file mode 100644
index 000000000..811df535b
--- /dev/null
+++ b/test/models/enable_banking_account/processor_test.rb
@@ -0,0 +1,72 @@
+require "test_helper"
+
+class EnableBankingAccount::ProcessorTest < ActiveSupport::TestCase
+ setup do
+ @family = families(:dylan_family)
+ @account = accounts(:depository)
+ @enable_banking_item = EnableBankingItem.create!(
+ family: @family,
+ name: "Test EB",
+ country_code: "FR",
+ application_id: "app_id",
+ client_certificate: "cert"
+ )
+ @enable_banking_account = EnableBankingAccount.create!(
+ enable_banking_item: @enable_banking_item,
+ name: "Compte courant",
+ uid: "hash_abc",
+ currency: "EUR",
+ current_balance: 1500.00
+ )
+ AccountProvider.create!(account: @account, provider: @enable_banking_account)
+ end
+
+ test "calls set_current_balance instead of direct account update" do
+ EnableBankingAccount::Processor.new(@enable_banking_account).process
+
+ assert_equal 1500.0, @account.reload.cash_balance
+ end
+
+ test "updates account currency" do
+ @enable_banking_account.update!(currency: "USD")
+
+ EnableBankingAccount::Processor.new(@enable_banking_account).process
+
+ assert_equal "USD", @account.reload.currency
+ end
+
+ test "does nothing when no linked account" do
+ @account.account_providers.destroy_all
+
+ result = EnableBankingAccount::Processor.new(@enable_banking_account).process
+ assert_nil result
+ end
+
+ test "sets CC balance to available_credit when credit_limit is present" do
+ cc_account = accounts(:credit_card)
+ @enable_banking_account.update!(
+ current_balance: 450.00,
+ credit_limit: 1000.00
+ )
+ AccountProvider.find_by(provider: @enable_banking_account)&.destroy
+ AccountProvider.create!(account: cc_account, provider: @enable_banking_account)
+
+ EnableBankingAccount::Processor.new(@enable_banking_account).process
+
+ assert_equal 550.0, cc_account.reload.cash_balance
+ if cc_account.accountable.respond_to?(:available_credit)
+ assert_equal 550.0, cc_account.accountable.reload.available_credit
+ end
+ end
+
+ test "sets CC balance to raw outstanding when credit_limit is absent" do
+ cc_account = accounts(:credit_card)
+ @enable_banking_account.update!(current_balance: 300.00, credit_limit: nil)
+ AccountProvider.find_by(provider: @enable_banking_account)&.destroy
+ AccountProvider.create!(account: cc_account, provider: @enable_banking_account)
+
+ EnableBankingAccount::Processor.new(@enable_banking_account).process
+
+ assert_equal 300.0, cc_account.reload.cash_balance
+ end
+end
diff --git a/test/models/enable_banking_account_test.rb b/test/models/enable_banking_account_test.rb
new file mode 100644
index 000000000..d638e0ec0
--- /dev/null
+++ b/test/models/enable_banking_account_test.rb
@@ -0,0 +1,152 @@
+require "test_helper"
+
+class EnableBankingAccountTest < ActiveSupport::TestCase
+ setup do
+ @family = families(:dylan_family)
+ @item = EnableBankingItem.create!(
+ family: @family,
+ name: "Test EB",
+ country_code: "FR",
+ application_id: "app_id",
+ client_certificate: "cert"
+ )
+ @account = EnableBankingAccount.create!(
+ enable_banking_item: @item,
+ name: "Mon compte",
+ uid: "hash_abc123",
+ currency: "EUR"
+ )
+ end
+
+ # suggested_account_type / suggested_subtype mapping
+ test "suggests Depository checking for CACC" do
+ @account.update!(account_type: "CACC")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "checking", @account.suggested_subtype
+ end
+
+ test "suggests Depository savings for SVGS" do
+ @account.update!(account_type: "SVGS")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "savings", @account.suggested_subtype
+ end
+
+ test "suggests CreditCard for CARD" do
+ @account.update!(account_type: "CARD")
+ assert_equal "CreditCard", @account.suggested_account_type
+ assert_equal "credit_card", @account.suggested_subtype
+ end
+
+ test "suggests Loan for LOAN" do
+ @account.update!(account_type: "LOAN")
+ assert_equal "Loan", @account.suggested_account_type
+ assert_nil @account.suggested_subtype
+ end
+
+ test "suggests Loan mortgage for MORT" do
+ @account.update!(account_type: "MORT")
+ assert_equal "Loan", @account.suggested_account_type
+ assert_equal "mortgage", @account.suggested_subtype
+ end
+
+ test "returns nil for OTHR" do
+ @account.update!(account_type: "OTHR")
+ assert_nil @account.suggested_account_type
+ assert_nil @account.suggested_subtype
+ end
+
+ test "suggests Depository savings for MOMA and ONDP" do
+ @account.update!(account_type: "MOMA")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "savings", @account.suggested_subtype
+
+ @account.update!(account_type: "ONDP")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "savings", @account.suggested_subtype
+ end
+
+ test "suggests Depository checking for NREX, TAXE, and TRAS" do
+ @account.update!(account_type: "NREX")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "checking", @account.suggested_subtype
+
+ @account.update!(account_type: "TAXE")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "checking", @account.suggested_subtype
+
+ @account.update!(account_type: "TRAS")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "checking", @account.suggested_subtype
+ end
+
+ test "returns nil when account_type is blank" do
+ @account.update!(account_type: nil)
+ assert_nil @account.suggested_account_type
+ assert_nil @account.suggested_subtype
+ end
+
+ test "is case insensitive for account type mapping" do
+ @account.update!(account_type: "svgs")
+ assert_equal "Depository", @account.suggested_account_type
+ assert_equal "savings", @account.suggested_subtype
+ end
+
+ # upsert_enable_banking_snapshot! stores new fields
+ test "stores product from snapshot" do
+ @account.upsert_enable_banking_snapshot!({
+ uid: "hash_abc123",
+ identification_hash: "hash_abc123",
+ currency: "EUR",
+ cash_account_type: "SVGS",
+ product: "Livret A"
+ })
+ assert_equal "Livret A", @account.reload.product
+ end
+
+ test "stores identification_hashes from snapshot" do
+ @account.upsert_enable_banking_snapshot!({
+ uid: "uid_uuid_123",
+ identification_hash: "hash_abc123",
+ identification_hashes: [ "hash_abc123", "hash_old456" ],
+ currency: "EUR",
+ cash_account_type: "CACC"
+ })
+ reloaded_account = @account.reload
+ assert_includes reloaded_account.identification_hashes, "hash_abc123"
+ assert_includes reloaded_account.identification_hashes, "hash_old456"
+ end
+
+ test "stores credit_limit from snapshot" do
+ @account.upsert_enable_banking_snapshot!({
+ uid: "uid_uuid_123",
+ identification_hash: "hash_abc123",
+ currency: "EUR",
+ cash_account_type: "CARD",
+ credit_limit: { amount: "2000.00", currency: "EUR" }
+ })
+ assert_equal 2000.00, @account.reload.credit_limit.to_f
+ end
+
+ test "stores account_servicer bic in institution_metadata" do
+ @account.upsert_enable_banking_snapshot!({
+ uid: "uid_uuid_123",
+ identification_hash: "hash_abc123",
+ currency: "EUR",
+ cash_account_type: "CACC",
+ account_servicer: { bic_fi: "BOURFRPPXXX", name: "Boursobank" }
+ })
+ metadata = @account.reload.institution_metadata
+ assert_equal "BOURFRPPXXX", metadata["bic"]
+ assert_equal "Boursobank", metadata["servicer_name"]
+ end
+
+ test "stores empty identification_hashes when not in snapshot" do
+ @account.upsert_enable_banking_snapshot!({
+ uid: "uid_uuid_123",
+ identification_hash: "hash_abc123",
+ currency: "EUR",
+ cash_account_type: "CACC"
+ })
+ assert_equal [], @account.reload.identification_hashes
+ end
+end
diff --git a/test/models/enable_banking_entry/processor_test.rb b/test/models/enable_banking_entry/processor_test.rb
index 33e55f46e..f8fae7323 100644
--- a/test/models/enable_banking_entry/processor_test.rb
+++ b/test/models/enable_banking_entry/processor_test.rb
@@ -117,4 +117,95 @@ class EnableBankingEntry::ProcessorTest < ActiveSupport::TestCase
entry = @account.entries.find_by!(external_id: "enable_banking_string_key_ref", source: "enable_banking")
assert_equal 15.0, entry.amount.to_f
end
+
+ test "includes note field in transaction notes alongside remittance_information" do
+ tx = {
+ entry_reference: "ref_note",
+ transaction_id: nil,
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "10.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ remittance_information: [ "Facture 2026-001" ],
+ note: "Détail comptable interne",
+ status: "BOOK"
+ }
+
+ EnableBankingEntry::Processor.new(tx, enable_banking_account: @enable_banking_account).process
+ entry = @account.entries.find_by!(external_id: "enable_banking_ref_note")
+ assert_includes entry.notes, "Facture 2026-001"
+ assert_includes entry.notes, "Détail comptable interne"
+ end
+
+ test "stores exchange_rate in extra when present" do
+ tx = {
+ entry_reference: "ref_fx",
+ transaction_id: nil,
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "100.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ exchange_rate: {
+ unit_currency: "USD",
+ exchange_rate: "1.0821",
+ rate_type: "SPOT",
+ instructed_amount: { amount: "108.21", currency: "USD" }
+ },
+ status: "BOOK"
+ }
+
+ EnableBankingEntry::Processor.new(tx, enable_banking_account: @enable_banking_account).process
+ entry = @account.entries.find_by!(external_id: "enable_banking_ref_fx")
+ eb_extra = entry.transaction&.extra&.dig("enable_banking")
+ assert_equal "1.0821", eb_extra["fx_rate"]
+ assert_equal "USD", eb_extra["fx_unit_currency"]
+ assert_equal "108.21", eb_extra["fx_instructed_amount"]
+ end
+
+ test "stores merchant_category_code in extra when present" do
+ tx = {
+ entry_reference: "ref_mcc",
+ transaction_id: nil,
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "25.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ merchant_category_code: "5411",
+ status: "BOOK"
+ }
+
+ EnableBankingEntry::Processor.new(tx, enable_banking_account: @enable_banking_account).process
+ entry = @account.entries.find_by!(external_id: "enable_banking_ref_mcc")
+ eb_extra = entry.transaction&.extra&.dig("enable_banking")
+ assert_equal "5411", eb_extra["merchant_category_code"]
+ end
+
+ test "stores pending true in extra for PDNG-tagged transactions" do
+ tx = {
+ entry_reference: "ref_pdng",
+ transaction_id: nil,
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "15.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "PDNG",
+ _pending: true
+ }
+
+ EnableBankingEntry::Processor.new(tx, enable_banking_account: @enable_banking_account).process
+ entry = @account.entries.find_by!(external_id: "enable_banking_ref_pdng")
+ eb_extra = entry.transaction&.extra&.dig("enable_banking")
+ assert_equal true, eb_extra["pending"]
+ end
+
+ test "does not add enable_banking extra key when no extra data present" do
+ tx = {
+ entry_reference: "ref_noextra",
+ transaction_id: nil,
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "5.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ EnableBankingEntry::Processor.new(tx, enable_banking_account: @enable_banking_account).process
+ entry = @account.entries.find_by!(external_id: "enable_banking_ref_noextra")
+ assert_nil entry.transaction&.extra&.dig("enable_banking")
+ end
end
diff --git a/test/models/enable_banking_item/importer_pdng_test.rb b/test/models/enable_banking_item/importer_pdng_test.rb
new file mode 100644
index 000000000..3d444ebf4
--- /dev/null
+++ b/test/models/enable_banking_item/importer_pdng_test.rb
@@ -0,0 +1,146 @@
+require "test_helper"
+
+class EnableBankingItem::ImporterPdngTest < ActiveSupport::TestCase
+ setup do
+ @family = families(:dylan_family)
+ @account = accounts(:depository)
+
+ @enable_banking_item = EnableBankingItem.create!(
+ family: @family,
+ name: "Test EB",
+ country_code: "FR",
+ application_id: "test_app_id",
+ client_certificate: "test_cert",
+ session_id: "test_session",
+ session_expires_at: 1.day.from_now,
+ sync_start_date: Date.new(2026, 3, 1)
+ )
+ @enable_banking_account = EnableBankingAccount.create!(
+ enable_banking_item: @enable_banking_item,
+ name: "Compte courant",
+ uid: "hash_abc123",
+ account_id: "uuid-1234-5678-abcd",
+ currency: "EUR"
+ )
+ AccountProvider.create!(account: @account, provider: @enable_banking_account)
+
+ @mock_provider = mock()
+ @importer = EnableBankingItem::Importer.new(@enable_banking_item, enable_banking_provider: @mock_provider)
+ end
+
+ # --- Post-fetch date filtering ---
+
+ test "filters out transactions before sync_start_date" do
+ old_tx = {
+ entry_reference: "old_ref",
+ transaction_id: nil,
+ booking_date: "2024-01-15", # Before sync_start_date of 2026-03-01
+ transaction_amount: { amount: "50.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+ recent_tx = {
+ entry_reference: "recent_ref",
+ transaction_id: nil,
+ booking_date: "2026-03-10",
+ transaction_amount: { amount: "30.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ result = @importer.send(:filter_transactions_by_date, [ old_tx, recent_tx ], Date.new(2026, 3, 1))
+
+ assert_equal 1, result.count
+ assert_equal "recent_ref", result.first[:entry_reference]
+ end
+
+ test "uses value_date when booking_date is absent for filtering" do
+ tx_only_value_date = {
+ entry_reference: "vd_ref",
+ transaction_id: nil,
+ value_date: "2024-06-01", # Before sync_start_date
+ transaction_amount: { amount: "10.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ result = @importer.send(:filter_transactions_by_date, [ tx_only_value_date ], Date.new(2026, 3, 1))
+
+ assert_equal 0, result.count
+ end
+
+ test "keeps transactions with no date (cannot determine, keep to avoid data loss)" do
+ tx_no_date = {
+ entry_reference: "nodate_ref",
+ transaction_id: nil,
+ transaction_amount: { amount: "10.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ result = @importer.send(:filter_transactions_by_date, [ tx_no_date ], Date.new(2026, 3, 1))
+
+ assert_equal 1, result.count
+ end
+
+ test "keeps transactions on exactly sync_start_date" do
+ boundary_tx = {
+ entry_reference: "boundary_ref",
+ transaction_id: nil,
+ booking_date: "2026-03-01", # Exactly on sync_start_date
+ transaction_amount: { amount: "10.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ result = @importer.send(:filter_transactions_by_date, [ boundary_tx ], Date.new(2026, 3, 1))
+
+ assert_equal 1, result.count
+ end
+
+ # --- PDNG transaction tagging ---
+
+ test "tags PDNG transactions with pending: true in extra" do
+ pdng_tx = {
+ entry_reference: "pdng_ref",
+ transaction_id: "pdng_txn",
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "20.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "PDNG"
+ }
+
+ result = @importer.send(:tag_as_pending, [ pdng_tx ])
+
+ assert_equal true, result.first[:_pending]
+ end
+
+ test "tags all passed transactions regardless of status (caller is responsible for filtering)" do
+ # tag_as_pending blindly marks everything passed to it.
+ # The caller (fetch_and_store_transactions) is responsible for only passing PDNG transactions.
+ any_tx = {
+ entry_reference: "any_ref",
+ transaction_id: "any_txn",
+ booking_date: Date.current.to_s,
+ transaction_amount: { amount: "20.00", currency: "EUR" },
+ credit_debit_indicator: "DBIT",
+ status: "BOOK"
+ }
+
+ result = @importer.send(:tag_as_pending, [ any_tx ])
+
+ assert_equal true, result.first[:_pending]
+ end
+
+ # --- identification_hashes matching ---
+
+ test "find_enable_banking_account_by_hash uses identification_hashes for matching" do
+ # Account already exists with uid = identification_hash
+ @enable_banking_account.update!(identification_hashes: [ "hash_abc123", "hash_old_xyz" ])
+
+ # Lookup by a secondary hash that is in identification_hashes
+ found = @importer.send(:find_enable_banking_account_by_hash, "hash_old_xyz")
+
+ assert_equal @enable_banking_account.id, found.id
+ end
+end
diff --git a/test/models/transaction_test.rb b/test/models/transaction_test.rb
index e3fbf9c26..b6086d5c7 100644
--- a/test/models/transaction_test.rb
+++ b/test/models/transaction_test.rb
@@ -25,6 +25,18 @@ class TransactionTest < ActiveSupport::TestCase
assert_not transaction.pending?
end
+ test "pending? returns true for enable_banking pending transactions" do
+ transaction = Transaction.new(extra: { "enable_banking" => { "pending" => true } })
+
+ assert transaction.pending?
+ end
+
+ test "pending? returns false for enable_banking non-pending transactions" do
+ transaction = Transaction.new(extra: { "enable_banking" => { "pending" => false } })
+
+ assert_not transaction.pending?
+ end
+
test "investment_contribution is a valid kind" do
transaction = Transaction.new(kind: "investment_contribution")
![<%= aspsp[:name] %>](<%= aspsp[:logo] %>)
- <% else %>
-