QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 12:04:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Handle empty compound conditions on rules index (#965)

Browse Source 
* fix: Handle empty compound conditions on rules index

* fix: avoid contradictory rule condition summary on /rules

* refactor: move rules condition display logic from view to model

* fix: localize rule title fallback and preload conditions in rules index
This commit is contained in:
Pluto
2026-02-13 13:53:24 -05:00
committed by GitHub
parent 34afc1f597
commit e99e38a91c
16 changed files with 99 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/models/rule.rb
View File

@@ -86,14 +86,23 @@ class Rule < ApplicationRecord
end
def primary_condition_title
return "No conditions" if conditions.none?
condition = displayed_condition
return I18n.t("rules.no_condition") if condition.blank?
first_condition = conditions.first
if first_condition.compound? && first_condition.sub_conditions.any?
first_sub_condition = first_condition.sub_conditions.first
"If #{first_sub_condition.filter.label.downcase} #{first_sub_condition.operator} #{first_sub_condition.value_display}"
else
"If #{first_condition.filter.label.downcase} #{first_condition.operator} #{first_condition.value_display}"
"If #{condition.filter.label.downcase} #{condition.operator} #{condition.value_display}"
end
def displayed_condition
displayable_conditions.first
end
def additional_displayable_conditions_count
[ displayable_conditions.size - 1, 0 ].max
end
def displayable_conditions
conditions.filter_map do |condition|
condition.compound? ? condition.sub_conditions.first : condition
end
end