QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-05-29 15:34:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(settings/providers): align with DS conventions

Browse Source 
Two consistency wins from the screenshot/DS audit pass.

Sync icon button now renders DS::Button (variant: icon, size: sm)
instead of a hand-rolled `button_to`. Same component used by other
icon-only actions across the app (settings/profiles, layouts/imports).
Visual delta: 28×28 → 32×32 (DS sm size). Accept the +4px for
consistency. `event.stopPropagation()` still wired via the form opt
so the row's <details> doesn't toggle when the user clicks the
button.

Group heading now follows the established Sure section-label style
(`text-xs font-medium text-secondary uppercase`) used by
`_settings_nav` and the imports/categories surfaces. The previous
sentence-case `text-sm text-primary` was a one-off that didn't
match the rest of the app. Locale strings stay sentence-case;
uppercase comes from CSS `text-transform`. Tests updated to
case-insensitively match the rendered heading text.
This commit is contained in:
Guillem Arias
2026-05-09 13:18:51 +02:00
committed by Guillem Arias
parent 41cd6418dd
commit ee798aed9e
3 changed files with 22 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/system/settings/providers_test.rb
View File

@@ -36,8 +36,8 @@ class Settings::ProvidersTest < ApplicationSystemTestCase
titles = all("details").map { |d| d.find("summary h3", match: :first).text.squish }
assert_equal titles.sort_by(&:downcase), titles, "Connection panels should render alphabetically by title"
connections_heading = page.find(:xpath, "//h2[contains(normalize-space(), 'Your connections')]")
available_heading = page.find(:xpath, "//h2[contains(normalize-space(), 'Available')]")
connections_heading = page.find(:xpath, "//h2[contains(translate(normalize-space(), 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'your connections')]")
available_heading = page.find(:xpath, "//h2[contains(translate(normalize-space(), 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'available')]")
connections_y = connections_heading.native.location.y
available_y = available_heading.native.location.y
@@ -65,12 +65,12 @@ class Settings::ProvidersTest < ApplicationSystemTestCase
visit settings_providers_path
connections_heading = find(:xpath, "//h2[contains(., 'Your connections')]")
connections_heading = find(:xpath, "//h2[contains(translate(., 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'your connections')]")
normalized = connections_heading.text.squish
assert_match(/Your connections .*· \d+/, normalized)
assert_match(/Your connections .*· \d+/i, normalized)
connections_y = connections_heading.native.location.y
available_heading = find(:xpath, "//h2[contains(., 'Available')]")
available_heading = find(:xpath, "//h2[contains(translate(., 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'available')]")
available_y = available_heading.native.location.y
simplefin_y = find("details", text: "SimpleFIN").native.location.y
@@ -86,8 +86,8 @@ class Settings::ProvidersTest < ApplicationSystemTestCase
visit settings_providers_path
assert_selector "h2", text: /\AYour connections/
assert_no_selector "h2", text: /\AAction needed/
assert_selector "h2", text: /\AYour connections/i
assert_no_selector "h2", text: /\AAction needed/i
end
test "enable banking with expiring session appears in your connections and auto-opens" do
@@ -104,7 +104,7 @@ class Settings::ProvidersTest < ApplicationSystemTestCase
visit settings_providers_path
assert_selector "h2", text: /\AYour connections/
assert_selector "h2", text: /\AYour connections/i
# Auto-expanded warning sections hide compact meta behind `group-open:hidden`;
# collapse once so the re-consent copy is visible again.