QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-09-03 13:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(charts): round series values to the currency's display precision (#3091)

Browse Source 
* fix(charts): round chart values to the currency's display precision

Charts are drawn from the serialized amounts, not from the formatted strings,
so a sub-unit residue plotted as a visible move between two points that both
read $0.00, and the trend between them reported a change. Round in
`Series#as_json` so the series values stay exact for insights, goals and the
assistant.

Also hide the percentage when the previous value is zero, since that makes it
infinite.

* fix(charts): round the two payloads that bypass Series#as_json

`NetWorthBreakdownSeriesBuilder` builds its payload by hand, so the reports
chart never went through the rounding added in `Series#as_json` and still
plotted raw amounts: adjacent points printing the same value rendered a
visible move, and the tooltip it inherits reported a change between them.

`Series#trend` had the same gap on the server side. It is rendered right above
the chart by `UI::Account::Chart` and by the reports summary, so an account
going from 0 to a sub-cent residue showed a coloured $0.00 change next to a
flat line.

Rounding the trend can make a previously finite percentage infinite, so guard
the three views that render `percent_formatted` without checking, as
`shared/_trend_change` already does.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(charts): address net worth review comments

* fix(charts): tighten rounded trend handling

* fix(reports): restore positive sign in print trend

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: sure-admin <sure-admin@splashblot.com>
This commit is contained in:
Victor Dusart
2026-08-22 04:30:23 +02:00
committed by GitHub
co-authored by Claude Opus 5 sure-admin
parent 0ff5b0f274
commit f0a0013da9
11 changed files with 198 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/controllers/time_series_chart_controller.js
+6 -2
View File
@@ -408,11 +408,15 @@ export default class extends Controller {
</div>
${
datum.trend.value === 0
this._extractNumericValue(datum.trend.value) === 0
? `<span class="w-20"></span>`
: `
<span class="tabular-nums" style="color: ${datum.trend.color};">
${this._extractFormattedValue(datum.trend.value)} (${datum.trend.percent_formatted})
${this._extractFormattedValue(datum.trend.value)}${
datum.trend.percent === null
? ""
: ` (${datum.trend.percent_formatted})`
}
</span>
`
}