3 Commits

Author	SHA1	Message	Date
GermanDZ	c5503320af	Fix IndexaCapital sync, account setup, and balance/type bugs (#1562) ... * Add missing IndexaCapitalItem::SyncCompleteEvent Syncable#sync_broadcaster instantiates self.class::SyncCompleteEvent, which is implemented for every other provider (Plaid, Lunchflow, Mercury, etc.) but was missing for IndexaCapitalItem. The error was swallowed by Sync#perform_post_sync's rescue, so syncs appeared to succeed but post-sync UI broadcasts never fired: Error performing post-sync for IndexaCapitalItem (...): uninitialized constant IndexaCapitalItem::SyncCompleteEvent This adds the class, modeled on LunchflowItem::SyncCompleteEvent, restoring per-account and per-item Turbo broadcasts after Indexa Capital syncs. * Fix IndexaCapital account setup never creating accounts complete_account_setup read params[:accounts], but the form in setup_accounts.html.erb submits account_ids[] (array) and sync_start_dates[<id>] (hash). The hash was always empty, so every submit hit the empty-config branch and bounced back with "No accounts to set up." — accounts were never created. The controller also branched on config[:account_type] / config[:subtype] even though the form has no account-type picker (Indexa Capital is an investment-only broker). Rewrote complete_account_setup to consume the form's actual params and infer the accountable type as Investment from indexa_capital_account.account_type. * Fix IndexaCapital balance double-count and account type Two more issues in the IndexaCapital flow that surfaced once accounts could actually be created (see prior commit): 1. Accountable type was inferred from indexa_capital_account.account_type ("mutual" / "pension"), but infer_accountable_type doesn't recognize those values and falls through to "Depository". The result: every imported Indexa account showed up as a Cash depository account instead of an Investment account, hiding holdings/trades surfaces. Indexa Capital is investment-only, so hard-code the accountable type to Investment. 2. Account::Processor#calculate_total_balance summed every row in raw_holdings_payload. Indexa returns a time series — one row per security per date — so the naive sum double-counts (observed: reported €91,633 became stored balance €180,039). Trust the API's current_balance when present, and if we have to fall back to a computed total, dedupe by instrument and take the latest-dated amount per security. * Fix IndexaCapital holdings reflecting oldest snapshot per security HoldingsProcessor#process iterated every row in raw_holdings_payload. Indexa returns a time series (many rows per security across dates), and each iteration upserts the same (account, security, today) holding row, so the LAST row processed wins. The payload is ordered with newer dates first, so the last row processed is the OLDEST snapshot — the holdings shown in the UI reflected tiny early positions instead of the current ones (e.g. 3.8 shares of US 500 stored vs 62.34 actual). Reduce the payload to one row per security (latest date) before processing. The cost-basis update is now also driven by the latest snapshot for the same reason. * Fix IndexaCapital holdings using per-lot detail instead of totals Importer#normalize_holdings_response read data[:fiscal_results], which the Indexa API returns as per-tax-lot detail — many rows per security covering each subscription_date, plus virtual sell/buy rows generated by rebalances. Iterating it produced wildly wrong stored holdings: e.g. 9.61 shares stored for Vanguard US 500 vs 62.34 actual; total weights summed to ~10% instead of 100%. The same response also includes data[:total_fiscal_results] — one aggregated row per security with current titles/amount/cost matching the Indexa UI and the user-downloadable positions CSV. Prefer it, falling back to the per-lot field only when the totals are absent. * Address CodeRabbit review on IndexaCapital fixes Four review items, all fixed: * Share instrument-key extraction HoldingsProcessor#extract_ticker and Processor#calculate_holdings_value used different fallback orders (one looked at :isin, the other at :isin_code), so they could disagree on which rows referred to the same security. Moved a single extract_instrument_key helper into IndexaCapitalAccount::DataHelpers and routed both callers through it. * Simplify Processor#calculate_holdings_value The date-based dedupe was a workaround for the bug already fixed in the importer (which now stores total_fiscal_results — one row per security). Replaced the date comparison with a per-security map populated via the shared key extractor. Same end result, fewer moving parts, no fragile string-date comparison. * Drop dead config key passed to create_account_from_indexa_capital create_account_from_indexa_capital only reads :subtype and :balance from its config arg. Passing :sync_start_date there was inert. * Don't mark created accounts as skipped on post-create errors In complete_account_setup, ensure_account_provider! and update!(sync_start_date:) ran inside the same begin/rescue as the Account.create!. If either raised after the Account row was already persisted, control jumped to the rescue with created_count not yet incremented and the account was wrongly counted as skipped. Now: parse the form-supplied sync_start_date up front (a malformed value is silently dropped instead of bubbling out of the loop), bump created_count immediately after persisted?, and isolate the post- create steps in their own rescue so failures there are logged but don't desync the success counter. * Fall back to /portfolio so pension plans get holdings imported Indexa's /accounts/{id}/fiscal-results endpoint returns {fiscal_results: [], total_fiscal_results: []} for pension plan accounts (e.g. type "pension"). The same positions are exposed via /accounts/{id}/portfolio in instrument_accounts[].positions[] for both mutual funds and pensions, so use it as a fallback when fiscal-results is empty. The portfolio response uses the same field names HoldingsProcessor already understands (instrument, titles, price, amount, cost_amount) plus a derived cost_price (cost_amount / titles) added during adaptation. No HoldingsProcessor changes needed. Verified against the user-downloadable "Posiciones" CSV for an SH71ZPMY pension account: two positions (N5138 Acciones, N5137 Bonos) and balance €8,273.56 match exactly. * Fix CI: update tests for new IndexaCapital flow + rubocop blank line * Lint: drop trailing blank line before `end` in IndexaCapitalAccount::Processor (Layout/EmptyLinesAroundClassBody). * Controller test: complete_account_setup#creates was posting params: { accounts: { id => { account_type:, subtype: } } } against the old controller schema. The new endpoint reads params[:account_ids] and infers Investment for Indexa Capital, so switch the test to that shape (and update the matching skip-already- linked / no-selected-accounts cases). * Processor test: "updates account balance from holdings value" set current_balance: 38905.21 alongside holdings summing to 27093.01 and asserted the latter wins. After the fix (calculate_total_balance prefers the API-reported current_balance when present), the API value is the right answer. Renamed to "trusts API current_balance over holdings sum when present" and added a sibling test that nils current_balance to exercise the holdings-sum fallback path explicitly (still asserts 27093.01). * Wrap account creation+linking in a transaction to avoid orphans complete_account_setup created the Account row first, incremented created_count, and only then called ensure_account_provider! / the sync_start_date update inside an inner rescue. If the link or the sync_start_date update raised after the Account was already persisted, control fell into the inner rescue: the orphaned Account row stayed in the database, the failure was silently logged, and the success counter was inflated. Wrap creation, ensure_account_provider!, and the optional sync_start_date update in a single ActiveRecord::Base.transaction. Increment created_count only after the transaction commits; on any exception the outer rescue rolls the whole step into skipped_count with a clear log line tagged with the indexa_capital_account id.	2026-04-27 18:33:22 +02:00
soky srm	9410e5b38d	Providers sharing (#1273) ... * third party provider scoping * Simplify logic and allow only admins to mange providers * Broadcast fixes * FIX tests and build * Fixes * Reviews * Scope merchants * DRY fixes	2026-03-25 17:47:04 +01:00
David Gil	ba442d5f26	Implement Indexa Capital provider with real API integration (#933) ... * Add Indexa Capital provider scaffold Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements. * Fix PR 926 lint and schema CI failures * Implement Indexa Capital provider with real API integration - Rewrite all broken view templates (were meta-ERB from code generator) - Create missing select_accounts.html.erb template - Implement real API calls: list_accounts via /users/me, get_holdings via /accounts/{number}/fiscal-results, get_account_balance via /accounts/{number}/performance - Add API token auth support (stored token > env token > credentials) - Add api_token column with encryption support - Redesign settings panel: API token prominent, credentials collapsible - Fix account balances display using performance endpoint portfolios - Fix accounts index empty-state guard missing indexa_capital_items - Simplify activities fetch job (no activities API endpoint exists) - Fix i18n interpolation (%%{ -> %{) throughout locale file * Add tests for Indexa Capital provider integration - IndexaCapitalItemTest: validations, credentials, scopes, sync status - IndexaCapitalAccountTest: upsert, holdings, account provider linking - Provider::IndexaCapitalTest: auth modes, API stubs, error handling - IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization - Fixtures for items (token + credentials) and accounts (mutual + pension) 52 tests, 98 assertions, 0 failures * Address code review feedback from PR #933 - Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored - Fix has_indexa_capital_credentials? to check api_token (was ignored) - Fix build_provider to delegate to Provided concern (was ignoring token) - Fix IndexaCapital section outside encryption_error guard in settings - Add account_number sanitization to prevent path traversal in API URLs - Replace all skipped processor tests with real working tests - Add zero-balance and path-traversal test coverage 61 tests, 107 assertions, 0 failures * Address code review round 2: credentials validation, RuboCop, test quality - Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check - Chain where.not calls so all three username/document/password must be present - Require all three credentials (||) instead of any one (&&) in validate_configuration! - Move attr_reader to private to avoid exposing credentials publicly - Parse dates with Date.parse in extract_balance for robustness - Remove stale TODO and Crypto from supported_account_types - Order build_provider query deterministically by created_at - Replace no-op holdings assertion with meaningful assert_difference * Address code review round 3: JSON parse safety and test precision - Rescue JSON::ParserError on 2xx responses for clearer error messages - Fix weak balance assertion: set balance to 0 before processing, assert expected value (27093.01 = sum of holdings amounts) * Include Indexa Capital in automatic family sync Add indexa_capital_items to Family::Syncer#child_syncables so balances and holdings refresh on daily auto-sync and login sync, not only on manual sync button clicks. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-02-08 18:19:37 +01:00