2 Commits

Author	SHA1	Message	Date
Himmelschmidt	4cd737b5d9	Fix SimpleFin investment holdings and comprehensive integration improvements (#104) ... * Remove skipped account functionality from SimpleFin - Remove "Skip - don't add" option from account setup - Simplify account setup flow to require all accounts be assigned types - Update controller logic to handle all accounts without skipping - Redirect to accounts page instead of SimpleFin items page - Add I18N message support with t(".success") * Simplify SimpleFin sync logic by removing skipped accounts - Remove skipped account filtering from syncer - All unlinked accounts now block sync until setup is complete - Remove skipped account UI elements from setup view - Streamline sync flow without complex skipped/non-skipped logic * Fix cash balance calculation for SimpleFin investment accounts - Update SimplefinAccount::Processor to recalculate balances during sync - Properly calculate cash_balance for investment accounts using BalanceCalculator - Handle negative balances for credit cards and loans correctly - Ensure account balance and cash balance are updated from latest SimpleFin data * Add I18N translations and edit view for SimpleFin - Add comprehensive English translations for SimpleFin UI - Create edit view for SimpleFin re-authentication - Support status messages, errors, and user feedback - Match translation structure with Plaid integration * Add specialized SimpleFin data processors - Add investment processors for transactions, holdings, and balance calculation - Add liability processors for credit cards and loans - Add transaction processor for standard account transactions - Add account importer for SimpleFin account data - Organize processors by account type for maintainable architecture * Add loading button controller for SimpleFin forms - Add Stimulus controller to show loading state during form submission - Disable button and show loading text to prevent double submissions - Improve user experience during SimpleFin account setup * Add SimpleFin edit and update routes - Add edit and update actions to SimpleFin items routes - Enable re-authentication flow for expired SimpleFin connections - Match route structure with Plaid items for consistency * Add institution metadata fields to SimpleFin items - Add institution_id, institution_name, institution_domain fields - Add institution_url, institution_color for UI customization - Add raw_institution_payload for complete institution data storage - Enable better institution organization and display * Enhance SimpleFin item with institution support and metadata - Add institution summary and connected institutions methods - Store and retrieve institution metadata from SimpleFin API - Add institution-aware import functionality - Support multiple institutions per SimpleFin connection * Fix account creation and Plaid provider issues - Fix cash balance calculation in Account.create_from_simplefin_account - Add nil check for plaid_provider in remove_plaid_item method - Ensure proper balance handling for investment accounts during creation * Improve sync parent relationship handling - Add parent sync assignment for existing syncs when parent_sync is provided - Ensure sync hierarchy is maintained when expanding sync windows - Fix sync relationship consistency in nested sync operations * Update SimpleFin item view with enhanced UI - Improve SimpleFin connection display and status information - Add better visual styling and user feedback - Match UI consistency with Plaid item views * Update database schema with institution fields - Add institution metadata fields to simplefin_items table - Support institution tracking and organization features * Update SimpleFin tests for new functionality - Update controller tests for edit/update actions and removed skip functionality - Update model tests for institution metadata and enhanced features - Ensure test coverage for SimpleFin improvements * Add migration to remove old institution fields * Fix linting issues * Apply suggestion from @coderabbitai[bot] Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Himmelschmidt <46351743+Himmelschmidt@users.noreply.github.com> * Fix 2 failing tests * Wrap SimpleFin account transfer in database transaction * Make loading button controller more reusable - Add loadingText Stimulus value for configurable loading text - Remove unused originalText variable - Update view to pass loading text via data attribute * Remove unused SimplefinAccount::Importer class This class was added in the PR but is never called anywhere in the codebase. The actual SimpleFin account processing is handled by SimplefinAccount::Processor and its specialized sub-processors. * Fix SimpleFin account transfer bug during token updates - Call import_latest_simplefin_data before account transfer to ensure new SimpleFin accounts exist with account_id populated - Prevents silent failure where accounts become orphaned when refreshing expired SimpleFin tokens * Fix SimpleFin error handling to render correct template and use i18n - Update render_error method to accept context parameter for template selection - Fix update action to render :edit template instead of :new on errors - Replace hardcoded error messages with localized strings using t() calls - Add comprehensive error message keys to SimpleFin locale file * Improve loading button accessibility and HTML semantics - Add aria-disabled and aria-busy attributes for screen readers - Use semantic span elements instead of divs for button content - Add aria-hidden to decorative spinner element * Fix SimpleFin SSL verification to use OpenSSL constant * Remove HTTParty streaming to prevent empty response body and PII logging * Use BigDecimal zero for consistent numeric types in balance calculator * Add investment account guard to holdings processor * Remove duplicate balance normalization from SimpleFin loan processor * Fix critical account deletion bug in SimpleFin token update * Fix linting issues in SimpleFin controller tests * Replace hardcoded colors with design system tokens in SimpleFin views * Gate investment processors to Investment accounts only Prevents investment processors from running on non-Investment account types, matching the pattern used by liability processors. * Localize hardcoded strings in SimpleFin edit form * Adding the error message to a hover state. * Use only 1 month for sync_start_date, new account restriction? * Harden investment cash_balance calculation with error handling - Add try/catch around SimplefinAccount::Investments::BalanceCalculator - Fallback to zero on calculation errors or nil results - Log warning with error details for debugging - Prevents nil cash_balance that could cause downstream issues * Fix SimpleFin institution fields migration and add DB constraints - Remove destructive migration that dropped existing institution fields - Add only new fields (institution_domain, institution_color) - Add indexes on institution fields for query performance - Add NOT NULL constraints on required fields (institution_id, institution_name) - Fix schema jsonb consistency for raw_institution_payload * Improve SimpleFin holdings error handling and BigDecimal consistency * Add security attribute to external link in SimpleFin edit form * Improve SimpleFin sync timing and add user-configurable date range - Fix initial sync timing issue: change from 1 month to 7 days default lookback - Add user-selectable sync start date in account setup UI - Implement chunked historical sync that respects user-selected date range - Add sync_start_date field to SimpleFin items - Handle new accounts on existing connections with same date picker This addresses SimpleFin API limitations and gives users control over how much transaction history to sync during initial setup. * Fix SimpleFin sync status to show detailed results instead of "Never synced" - Modify sync completion logic to always complete even with unlinked accounts - Add sync_stats column to track account sync statistics during sync process - Update sync status display to show "X synced, Y need setup" instead of "Never synced" - Store detailed sync statistics (total, linked, unlinked accounts) in sync record - Add sync_status_summary method to provide meaningful status text - Remove early return that prevented sync completion when accounts need setup Resolves issue where successful account syncing still showed "Never synced" status. * Fix Transaction persistence before Entry creation in SimpleFin processor Persist Transaction with create! instead of new to ensure it has an ID before creating Entry that references it as entryable. Prevents foreign key errors. * Fix indifferent access for SimpleFin institution data extraction The accounts_snapshot parameter comes from JSON with string keys, but the code was accessing with symbol keys which could silently fail. Convert to indifferent access to handle both string and symbol keys properly. * Localize hardcoded deletion in progress string Replace hardcoded "(deletion in progress...)" text with I18n translation to maintain consistency with the rest of the view. * Fix SimpleFin item update test to properly verify rebind/destroy behavior The test now creates a different SimplefinItem instance and mocks create_simplefin_item! to return it, ensuring the controller operates on a new record instead of the same instance. This properly exercises the rebind/destroy logic and verifies the original item is scheduled for deletion. * Fix potential transaction data loss in SimpleFin importer Prevent wiping stored transactions when API omits transaction data by only updating raw_transactions_payload when transactions are actually present in the response, preserving existing transaction data when API doesn't include transactions key. * Fix SimpleFin sync chunking and enforce 3-year historical limit - Fix SimpleFin's actual API limit from 365 days to 60 days per request - Implement proper backward-walking chunked sync for historical data - Enforce 3-year maximum historical data limit (60 days × 22 requests) - Update date picker to reflect 3-year limit and better defaults - Add comprehensive logging for debugging sync issues * Add dedicated raw_holdings_payload storage for SimpleFin accounts - Add raw_holdings_payload column to simplefin_accounts table - Separates holdings data from general account data for cleaner processing - Follows same pattern as raw_transactions_payload for consistency - Enables proper SimpleFin holdings processing pipeline * Enhance SimpleFin holdings storage with external ID tracking - Add external_id and cost_basis columns to holdings table - Update holdings processor to use external_id for precise matching - Capture all available SimpleFin holdings data (shares, market_value, cost_basis, etc.) - Use SimpleFin holding ID as external_id with "simplefin_" prefix - Calculate price from market_value/shares when available - Store raw holdings payload in simplefin_accounts for complete data retention This enables better holdings tracking than composite key approach and ensures we capture all SimpleFin data even if not immediately used in our models. * Simplify SimpleFin transaction enrichment - Add MerchantDetector that uses payee field directly for merchant creation - Enhance SimpleFin entry name generation combining payee + description - Remove transaction processor category matching logic - Create dedicated SimpleFin entry processor Uses SimpleFin's clean payee data without unnecessary filtering. * Add source field to ProviderMerchant and fix data enrichment - Add source field to ProviderMerchant model for provider-specific merchant tracking - Fix DataEnrichment to handle string transaction IDs correctly with to_i conversion Enables per-provider merchant deduplication and fixes transaction lookups. * Fix SimpleFin controller parameter handling - Convert string account_ids to integers for proper account lookup - Ensure account selection works correctly with form submissions Fixes account filtering when setting up SimpleFin sync. * Fix linting issues - auto-corrected whitespace and formatting * Derive institution domain from URL when missing in SimpleFin items * Fix render_error to preserve persisted record for edit context * Add unique index to prevent duplicate holdings * Fix potential NameError in holdings processor rescue block * Guard against missing SimpleFin transaction IDs * Fix SimpleFin amount parsing error handling Re-raise ArgumentError instead of silently returning BigDecimal("0") to prevent misleading $0 transactions from invalid amount data. * Fix SimpleFin chunked import data loss bug Merge transaction arrays instead of overwriting to prevent data loss during chunked imports. Preserve most recent holdings data only. * Add external_id uniqueness validation to Holding model * Fix holdings cost_basis precision and add external_id unique constraint * Fix SimpleFin test mock expectations and remove debug statements - Fixed SimplefinItemsControllerTest by properly mocking Provider::Simplefin instead of over-mocking the create_simplefin_item! method - Removed DEBUG puts statements from SimplefinItem::Importer * Fix linting issues - auto-corrected whitespace and formatting --------- Signed-off-by: Himmelschmidt <46351743+Himmelschmidt@users.noreply.github.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2025-10-22 19:51:24 +02:00
Himmelschmidt	7e36b1c7c5	Feature/simplefin integration (#94) ... * Add HTTParty gem for SimpleFin API integration - Add HTTParty gem for making HTTP requests to SimpleFin API - Required for SimpleFin protocol implementation * Add SimpleFin database schema - Create simplefin_items table for SimpleFin connections - Create simplefin_accounts table for account metadata - Add simplefin_account_id to accounts table for linking - Add external_id to transactions for deduplication - Enable encrypted storage of SimpleFin access URLs * Implement SimpleFin API client and data models - Add SimplefinItem model with sync capabilities and encryption - Add SimplefinAccount model for account data mapping - Implement Provider::Simplefin API client with token exchange - Add SimpleFin protocol support with proper error handling - Include sync jobs, importers, and processors for data flow - Add family SimpleFin connectivity mixin * Update core models for SimpleFin integration - Add SimpleFin account creation methods to Account model - Implement intelligent account type mapping from names - Add SimpleFin linkable functionality to Account - Include SimpleFin items in Family model associations - Support account creation with user-selected types * Add SimpleFin controllers and routing - Create SimplefinItemsController with CRUD operations - Add account setup flow with user type selection - Include sync management and error handling - Update AccountsController to display SimpleFin items - Add routes for SimpleFin item management and setup * Add SimpleFin user interface components - Create SimpleFin connection management views - Add account setup modal with type selection - Include connection form with token input and instructions - Update accounts index to display SimpleFin items - Add SimpleFin option to account method selector - Include SimpleFin in settings navigation * Add user account type selection workflow - Add pending_account_setup field to SimpleFin items - Enable pausing sync for user account type selection - Allow users to choose account types during import - Prevent automatic account creation until user confirms * Add tests for SimpleFin integration - Add SimplefinItem model tests with fixtures - Add SimplefinAccount model tests - Add SimplefinItemsController tests - Include test coverage for sync and account creation * Fix account show page for SimpleFin accounts - Update sync button routing to handle SimpleFin accounts - Add SimpleFin item sync path alongside existing Plaid support - Prevent NoMethodError when viewing SimpleFin-linked accounts - Support proper sync routing for Plaid, SimpleFin, and manual accounts * Complete subtype selection for SimpleFin accounts - Add subtype database columns to all accountable models - Create Stimulus controller for dynamic subtype dropdown interaction - Add delegation from Account to accountable subtype for clean API access - Update SimpleFin account setup form with working subtype selection - Fix account display to show proper subtype labels instead of generic "Cash" Users can now select both account type and subtype during SimpleFin import, and the selected subtypes are properly saved and displayed in the UI. * Fix dark mode compatibility for SimpleFin UI components - Replace hardcoded colors with design system tokens throughout SimpleFin views - Fix method selector hover states to use bg-surface instead of bg-gray-50 - Update SimpleFin form to use styled_form_with and standard form patterns - Replace custom button styling with design system button components - Fix info boxes and containers to use bg-surface and border-primary - Replace hardcoded green/blue colors with text-primary, text-secondary, text-link - Remove custom text area styling to allow form builder defaults (dark mode support) All SimpleFin components now properly adapt to both light and dark themes with correct contrast and visibility. * Fix SimpleFin integration bugs and improve code quality - Fix upsert method to handle string/symbol keys with indifferent access - Add missing show route and view for SimpleFin items - Fix test fixtures to use correct user references - Update test data to match real-world JSON format (string keys, BigDecimal) - Apply code formatting and linting fixes (rubocop, erb_lint) - Ensure all SimpleFin tests pass (16/16 passing) * Remove SimpleFin demo file with outdated setup token * Update SimpleFin User-Agent to use Sure Finance branding * Remove unused SimpleFin account type mapping logic - Remove map_simplefin_type_to_accountable_type method (no longer needed) - Remove create_from_simplefin_account method (manual setup only) - Simplify account type selection UI to not pre-select defaults - Update processor to log error if account missing (safety check) - All account creation now goes through manual user selection flow * Gate SimpleFin option behind US region check SimpleFin is primarily for North American financial institutions, so only show the option when US banking connections are available. * Refactor SimpleFin controller to use model method - Move SimpleFin item creation logic from controller to Family#create_simplefin_item! - Remove duplication between controller and model - Simplify controller to focus on web request/response handling - Remove unused simplefin_provider method - Follow Rails best practices for fat models, skinny controllers * Fix critical data integrity issue in SimpleFin date parsing - Remove fallback to Date.current when transaction dates fail to parse - Raise ArgumentError instead to ensure data integrity - Log detailed error messages for debugging - Skip transactions with invalid dates rather than using incorrect dates - Prevents hard-to-debug issues with balances and financial reports * Address all Gemini code review feedback for SimpleFin integration - Remove debug console.log statements from JavaScript controller - Consolidate duplicate SimpleFin account creation methods into single method - Refactor SimplefinItemsController to reduce complexity with helper methods - Fix HTTParty thread-safety by moving SSL options to class level - Remove redundant HTTParty options from individual requests - Add proper error logging for invalid currency URIs - Extract sync button path logic to AccountsHelper#sync_path_for method - DRY up repeated subtype dropdown code with reusable partial and data structure All SimpleFin tests passing (16/16). Code quality improvements maintain backward compatibility while following Rails best practices. * Fix tests for subtype delegation to accountable models The subtype attribute was moved from Account to individual accountable models to enable users to select specific subtypes during SimpleFin account import. This change allows for better account categorization and more precise display of account types (e.g., "HSA" instead of generic "Cash"). However, tests and the PlaidAccount processor weren't updated to work with the new delegation pattern. This commit fixes: - PlaidAccount::Processor now sets subtype on accountable and uses enrichable pattern to respect user locks - PropertiesController updated to handle subtype via accountable_attributes - Test fixtures corrected to set subtype on accountable models not Account - Tests updated to work with the delegated subtype pattern All originally failing tests now pass: - PropertiesControllerTest#test_updates_property_overview - PlaidAccount::ProcessorTest (2 failing tests) - AccountTest#test_gets_short/long_subtype_label * Fix trailing whitespace (rubocop auto-fix) * Add option to "skip" adding an account * Revert "Gate SimpleFin option behind US region check" This reverts commit 43b339940b. * Fix SimpleFin transaction syncing and clean up debug logging - Fix transaction creation to use Entry/entryable pattern instead of creating Transaction directly - Handle both string and symbol keys in transaction data using with_indifferent_access - Fix amount parsing to use BigDecimal instead of converting to cents - Use plaid_id field for external ID storage to prevent duplicates - Remove excessive debug logging while keeping essential error logging SimpleFin transaction sync now works correctly, creating proper Entry records with accurate dollar amounts and preventing duplicate transactions. * Not sure how skipping worked for me the first time * Fix SimpleFin new account setup flow and UI dark mode issues - Fix accounts showing as 'unknown' by displaying proper account type from Account model - Fix new accounts in existing connections not triggering setup flow with correct query - Fix dark mode colors throughout SimpleFin views using design system tokens - Improve UI logic to show existing accounts alongside new account setup prompt - Remove balance attribute error when creating CreditCard accounts - Simplify CreditCard subtype selection (auto-default to credit_card) * Fix linter issues (trailing whitespace and ERB formatting) * Remove SimpleFin button from create accounts view SimpleFin doesn't work like Plaid - no need for separate connection creation for new accounts, just refresh existing connection. * Add missing SimpleFin attributes and fix balance attribute error - Add balance_date field to SimpleFin accounts to capture balance timestamp from protocol - Enhanced build_simplefin_accountable_attributes to set available_credit for CreditCard accounts - Fixed model mismatch where balance was being set on accountable models instead of Account model - Updated tests to verify balance_date parsing functionality This addresses the balance attribute error from commit 6681537b and ensures we're capturing all available SimpleFin protocol data properly. * Store all SimpleFin protocol fields in JSONB following existing patterns * Fix SimpleFin API date parameter format and improve error handling - Change date parameters from string format to Unix timestamps as required by SimpleFin API - Add better error handling for 400 Bad Request responses - Add more detailed error logging for debugging failed API calls This fixes the issue where SimpleFin was only returning recent transactions instead of historical data when start_date was provided. * Implement comprehensive historical transaction sync for SimpleFin - Add start_date parameter to SimpleFin API calls for historical data - Use 100-year lookback for first sync to capture all available history - Use 7-day buffer for incremental syncs to catch late-posting transactions - Fix transaction storage to prevent data loss during account updates - Remove verbose logging for cleaner output This ensures users get all their historical transactions on first sync, not just recent ones. * Fix SimpleFin transaction sign convention to match Maybe's format - Negate SimpleFin amounts to convert from banking convention to Maybe's format - SimpleFin: expenses negative, income positive (banking convention) - Maybe: expenses positive, income negative (internal convention) - Improve date parsing to handle multiple date formats (Unix timestamps, strings, Date objects) This fixes the issue where expenses showed as negative in the UI instead of positive. * Add SimpleFin account association and fix balance handling for liabilities - Add belongs_to :simplefin_account association to Account model - Fix balance handling for credit cards and loans (use absolute value) - SimpleFin returns negative balances for liabilities, but Maybe expects positive This enables displaying organization names and ensures correct balance display. * Display organization names throughout SimpleFin interface - Show institution names under SimpleFin connection titles - Display organization names next to account names (e.g., "360 Checking • Capital One") - Add organization info to all SimpleFin account displays: - Account setup page - SimpleFin item details page - Regular account lists for SimpleFin accounts - Use org_data from SimpleFin accounts with fallback to institution_name This improves account identification by showing which financial institution each account belongs to throughout the SimpleFin workflow. * Fix SimpleFin UI styling to match design system - Replace custom styles with DS components (DS::FilledIcon, DS::Link, DS::Button) - Use proper design system tokens instead of hardcoded colors - Fix form select styling to match design system patterns - Update empty states to use consistent styling - Ensure all SimpleFin views follow the app's design system This makes the SimpleFin interface consistent with the rest of the app. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-08-12 02:59:16 +02:00