3 Commits

Include renames

Author	SHA1	Message	Date
4 people	eb498cfa0c	Feature/category hierarchy and account search (#2845) ... * Add parent/child category hierarchy to all category selects; add search to account select Category selection consistency: - DS::Select (shared component powering the main transaction form, transaction edit, bulk-update, and transfer category pickers) now indents subcategories with a corner-down-right icon, matching the existing transaction-row category dropdown. - Feed DS::Select-based category pickers with Category.alphabetically_by_hierarchy (parent name, then parent-before-children, then own name) so children render directly under their parent. - Added Category::Group.select_options, a shared helper producing parent-then-child ordered options (with an indent marker) for plain HTML <select> elements. Used by: - Rule builder category condition/action selects - Bulk 'categorize transactions' select - CSV/QIF import category mapping select - Grouped the splits category combobox and the transaction search category filter checklist the same way, both with the corner-down-right indent icon used elsewhere. Account selection: - Added searchable: true to the account select in the new/edit transaction form, matching the category and merchant selects next to it. * Fix SyntaxError: 'for' is a Ruby reserved keyword Category::Group.select_options called for(categories) as a bare method call, but Ruby parses a bare 'for' as the start of a for..in loop statement, not a method invocation. Qualify it as self.for(categories) to call the class method explicitly. Verified with 'ruby -c' on all touched .rb files and ERB.new(...).src on all touched .erb files. * Add test coverage for category hierarchy and account search Model-level: - Category::GroupTest (new): for() grouping and the new select_options helper (order + indent labels). - CategoryTest: alphabetically_by_hierarchy scope ordering. - Rule::ConditionFilter::TransactionCategoryTest (new) - Rule::ActionExecutor::SetTransactionCategoryTest (new) - Import::CategoryMappingTest (new): grouping + 'Add as new category' still prepends correctly. Controller/integration-level (asserting actual rendered HTML order): - SplitsControllerTest: category combobox data-value ordering. - Transactions::CategorizesControllerTest: bulk-categorize <select> option ordering. - TransactionsControllerTest: - search filter checkbox ordering (q[categories][]) - new-transaction DS::Select category ordering (via trigger id + ancestor traversal) - new-transaction account select renders a search box All new/modified test files verified with 'ruby -c' (syntax) and cross-checked fixture names, family scoping, route helpers, and field names against the actual fixtures/routes/views. Ruby/Bundler network access to rubygems.org is unavailable in this sandbox, so the suite itself has not been executed — run 'bin/rails test' before merging. * Align with design-sure conventions: keep domain logic in component, not template Per .cursor/rules/view_conventions.mdc ('keep domain logic out of the views'), the parent/child hierarchy check for DS::Select items belongs in the component class, not inline in the ERB template. DS::Select already has this exact pattern for other per-item derived properties (color_for, icon_for, logo_for) — added child? alongside them and updated the template to call it instead of computing it inline. Added test/components/DS/select_test.rb (ViewComponent::TestCase, no rendering needed) covering child? directly: subcategory objects, root-category objects, non-hierarchical objects (merchants), and the include_blank placeholder item. Also did a broader pass against the design-sure .cursor/rules to confirm the rest of this branch's changes already comply: - Uses Current.family (never current_family) throughout - Uses the icon() helper exclusively, never lucide_icon directly - No new/hardcoded colors; only existing semantic Tailwind tokens already used elsewhere in these same files - No changes to sure-design-system.css / application.css - Extended existing components/partials rather than creating new ones where one already existed (view_conventions.mdc component-vs-partial guidance) - Test additions stay in Minitest + fixtures, avoid system tests, and test query-method output directly (testing.mdc) * Address CodeRabbit review: sort category groups, tighten test assertion, move grouping out of view * Address review: fix arrow leak in rule summaries, filter panel alignment, simplify splits ordering * fix(pages): set breadcrumbs for changelog and feedback pages (#2889) * fix(app): set breadcrumbs for changelog and feedback pages * feat(test): add test to assert breadcrumbs * fix(test): remove changes * feat(app): update breadcrumbs to use semantic nav element * feat(test): add breadcrumb assertions to changelog and feedback pages * fix(app): replace breadcrumb nav element with div containing data-breadcrumbs attribute * fix ci failures * resolved failures * Regenerate schema.rb from migrations * Fix test * Remove schema dump noise --------- Signed-off-by: Shibu M <23173570+DataEnginr@users.noreply.github.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Kenrick Tandrian <60643640+KenTandrian@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-08-26 07:59:00 +02:00
CrossDrain	0b7fa732ae	feat(splits): add exclusion support for splits and improve rendering (#1661) ... * feat(splits): add excluded attribute support for split children and improve rendering of split transactions * address coderabbitai suggestions to improve code quality * Fix split excluded coercion, DRY helpers, and clean up view partials Fix boolean coercion bug where string "false" from form params was truthy in Ruby, causing all split children to be marked excluded. Use ActiveModel::Type::Boolean for explicit casting in Entry#split!. Additional changes addressing code review feedback: - Extract duplicated in_split_group logic from TransactionsController and TransactionCategoriesController into TransactionsHelper - Remove redundant local_assigns.fetch calls in partials that already declare defaults via the Rails 7.1 locals: magic comment - Simplify ternary in _transaction.html.erb to pass grouped directly - Guard hidden_field_tag :grouped to only emit when value is "true" - Add model tests for excluded on split children (boolean and string) - Add controller test for excluded param through full HTTP stack - Add test confirming excluded children are dropped from balance queries * fix(splits): simplify excluded attribute boolean check * refactor(splits): extract truthy values constant for excluded check Extract the array of truthy values used for excluded attribute check into a private constant to improve code maintainability and avoid duplication of the magic array. * refactor: simplify split grouping link generation and add test coverage for excluded split parameters	2026-05-09 12:36:41 +02:00
soky srmandJuan José Mata	ae5b23fe67	Initial split transaction support (#1230) ... * Initial split transaction support * Add support to unsplit and edit split * Update show.html.erb * FIX address reviews * Improve UX * Update show.html.erb * Reviews * Update edit.html.erb * Add parent category to dialog * Update en.yml * Add UI indication to totals * FIX ui update * Add category select like rest of app --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-03-20 21:19:30 +01:00