2 Commits

Include renames

Author	SHA1	Message	Date
4 people	eb498cfa0c	Feature/category hierarchy and account search (#2845) ... * Add parent/child category hierarchy to all category selects; add search to account select Category selection consistency: - DS::Select (shared component powering the main transaction form, transaction edit, bulk-update, and transfer category pickers) now indents subcategories with a corner-down-right icon, matching the existing transaction-row category dropdown. - Feed DS::Select-based category pickers with Category.alphabetically_by_hierarchy (parent name, then parent-before-children, then own name) so children render directly under their parent. - Added Category::Group.select_options, a shared helper producing parent-then-child ordered options (with an indent marker) for plain HTML <select> elements. Used by: - Rule builder category condition/action selects - Bulk 'categorize transactions' select - CSV/QIF import category mapping select - Grouped the splits category combobox and the transaction search category filter checklist the same way, both with the corner-down-right indent icon used elsewhere. Account selection: - Added searchable: true to the account select in the new/edit transaction form, matching the category and merchant selects next to it. * Fix SyntaxError: 'for' is a Ruby reserved keyword Category::Group.select_options called for(categories) as a bare method call, but Ruby parses a bare 'for' as the start of a for..in loop statement, not a method invocation. Qualify it as self.for(categories) to call the class method explicitly. Verified with 'ruby -c' on all touched .rb files and ERB.new(...).src on all touched .erb files. * Add test coverage for category hierarchy and account search Model-level: - Category::GroupTest (new): for() grouping and the new select_options helper (order + indent labels). - CategoryTest: alphabetically_by_hierarchy scope ordering. - Rule::ConditionFilter::TransactionCategoryTest (new) - Rule::ActionExecutor::SetTransactionCategoryTest (new) - Import::CategoryMappingTest (new): grouping + 'Add as new category' still prepends correctly. Controller/integration-level (asserting actual rendered HTML order): - SplitsControllerTest: category combobox data-value ordering. - Transactions::CategorizesControllerTest: bulk-categorize <select> option ordering. - TransactionsControllerTest: - search filter checkbox ordering (q[categories][]) - new-transaction DS::Select category ordering (via trigger id + ancestor traversal) - new-transaction account select renders a search box All new/modified test files verified with 'ruby -c' (syntax) and cross-checked fixture names, family scoping, route helpers, and field names against the actual fixtures/routes/views. Ruby/Bundler network access to rubygems.org is unavailable in this sandbox, so the suite itself has not been executed — run 'bin/rails test' before merging. * Align with design-sure conventions: keep domain logic in component, not template Per .cursor/rules/view_conventions.mdc ('keep domain logic out of the views'), the parent/child hierarchy check for DS::Select items belongs in the component class, not inline in the ERB template. DS::Select already has this exact pattern for other per-item derived properties (color_for, icon_for, logo_for) — added child? alongside them and updated the template to call it instead of computing it inline. Added test/components/DS/select_test.rb (ViewComponent::TestCase, no rendering needed) covering child? directly: subcategory objects, root-category objects, non-hierarchical objects (merchants), and the include_blank placeholder item. Also did a broader pass against the design-sure .cursor/rules to confirm the rest of this branch's changes already comply: - Uses Current.family (never current_family) throughout - Uses the icon() helper exclusively, never lucide_icon directly - No new/hardcoded colors; only existing semantic Tailwind tokens already used elsewhere in these same files - No changes to sure-design-system.css / application.css - Extended existing components/partials rather than creating new ones where one already existed (view_conventions.mdc component-vs-partial guidance) - Test additions stay in Minitest + fixtures, avoid system tests, and test query-method output directly (testing.mdc) * Address CodeRabbit review: sort category groups, tighten test assertion, move grouping out of view * Address review: fix arrow leak in rule summaries, filter panel alignment, simplify splits ordering * fix(pages): set breadcrumbs for changelog and feedback pages (#2889) * fix(app): set breadcrumbs for changelog and feedback pages * feat(test): add test to assert breadcrumbs * fix(test): remove changes * feat(app): update breadcrumbs to use semantic nav element * feat(test): add breadcrumb assertions to changelog and feedback pages * fix(app): replace breadcrumb nav element with div containing data-breadcrumbs attribute * fix ci failures * resolved failures * Regenerate schema.rb from migrations * Fix test * Remove schema dump noise --------- Signed-off-by: Shibu M <23173570+DataEnginr@users.noreply.github.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Kenrick Tandrian <60643640+KenTandrian@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>	2026-08-26 07:59:00 +02:00
kianrafieeandClaude Sonnet 5	c54369bd2d	Add send_email_notification rule action (#2527) ... * Add send_email_notification rule action Adds a new rule action that emails a digest of transactions matching a rule. Re-syncs re-apply every active rule to all in-window matches, so a notification_deliveries table (unique on rule_id + transaction_id) backs deduplication and a per-rule watermark: - Rule::ActionExecutor::SendEmailNotification plucks candidate ids, drops ones already in notification_deliveries, records the remainder BEFORE enqueuing (fail-safe: a crash suppresses rather than double-sends), and returns the count of newly-notified transactions. - RuleEmailNotificationJob loads the rule + transactions and delivers the digest via RuleNotificationMailer. - Creating the action pre-seeds all currently-matching transactions as already-delivered (after_create_commit), so the rule only emails about transactions appearing after the action exists. Dedup keys on the DB row id, not provider identity, so a re-ingested transaction (new id) may re-notify; accepted as benign. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add view transactions link to rule notification digest email Include a "View transactions" CTA (APP_DOMAIN/transactions) in both the HTML and text versions of the rule notification digest email. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address review feedback on rule email notifications - Restrict digest delivery to family admins only (drop non-admin fallback) - Make NotificationDelivery.record_for return only inserted ids and enqueue off that result, preventing duplicate digests under concurrent rule runs - Seed the notification baseline when an existing action is changed to send_email_notification, so historical matches are not emailed - Strengthen tests: assert the transactions CTA/link in the digest and the enqueued job's transaction-id args Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Include super_admin owner as rule digest recipient The admin-only recipient lookup used find_by(role: :admin), which excluded super_admin owners. A self-hosted family is commonly a single super_admin, so the digest was silently skipped (NullMail no-op) and no email was sent. Match the recipient on %w[admin super_admin] (the same pattern used elsewhere, and consistent with User#admin?), while still excluding regular members/guests. Add tests for the super_admin recipient and the no-admin skip path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add mixed-role digest recipient test Cover the case where a family has both an admin and a super_admin. The recipient lookup uses find_by(role: %w[admin super_admin]) with no ORDER BY, so which one is returned is non-deterministic; the contract is only that the recipient is an admin-level user (never a member). Assert recipient.admin? rather than a brittle precedence between the two roles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Deliver rule digest via deliver_later and order in DB Use deliver_later so a slow/flaky SMTP connection doesn't tie up the Sidekiq worker, and push the entry-date sort into the query instead of materializing and sorting the result set in Ruby. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Replace raw hex colors with email-safe design tokens in digest template The rule digest email hardcoded Tailwind slate-100/200 hex values for table borders, which aren't part of this project's design system. Resolve to the actual border-primary/border-secondary token values and centralize them as a reusable .email-table class in the mailer layout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-17 23:00:18 +02:00