require "test_helper" class Family::AutoTransferMatchableTest < ActiveSupport::TestCase include EntriesTestHelper setup do @family = families(:dylan_family) @depository = accounts(:depository) @credit_card = accounts(:credit_card) @loan = accounts(:loan) end test "auto-matches transfers" do outflow_entry = create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500) inflow_entry = create_transaction(date: Date.current, account: @credit_card, amount: -500) assert_difference -> { Transfer.count } => 1 do @family.auto_match_transfers! end end test "auto-matches multi-currency transfers" do load_exchange_prices create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500) create_transaction(date: Date.current, account: @credit_card, amount: -700, currency: "CAD") assert_difference -> { Transfer.count } => 1 do @family.auto_match_transfers! end # test match within lower 10% bound create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 1000) create_transaction(date: Date.current, account: @credit_card, amount: -1330, currency: "CAD") assert_difference -> { Transfer.count } => 1 do @family.auto_match_transfers! end # test match within upper 10% bound create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 1500) create_transaction(date: Date.current, account: @credit_card, amount: -2189, currency: "CAD") assert_difference -> { Transfer.count } => 1 do @family.auto_match_transfers! end # test no match outside of slippage tolerance create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 1000) create_transaction(date: Date.current, account: @credit_card, amount: -1250, currency: "CAD") assert_difference -> { Transfer.count } => 0 do @family.auto_match_transfers! end end test "only matches inflow with correct currency when duplicate amounts exist" do load_exchange_prices create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500) create_transaction(date: Date.current, account: @credit_card, amount: -500, currency: "CAD") create_transaction(date: Date.current, account: @credit_card, amount: -500) assert_difference -> { Transfer.count } => 1 do @family.auto_match_transfers! end end # In this scenario, our matching logic should find 4 potential matches. These matches should be ranked based on # days apart, then de-duplicated so that we aren't auto-matching the same transaction across multiple transfers. test "when 2 options exist, only auto-match one at a time, ranked by days apart" do yesterday_outflow = create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500) yesterday_inflow = create_transaction(date: 1.day.ago.to_date, account: @credit_card, amount: -500) today_outflow = create_transaction(date: Date.current, account: @depository, amount: 500) today_inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500) assert_difference -> { Transfer.count } => 2 do @family.auto_match_transfers! end end test "does not auto-match any transfers that have been rejected by user already" do outflow = create_transaction(date: Date.current, account: @depository, amount: 500) inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500) RejectedTransfer.create!(inflow_transaction_id: inflow.entryable_id, outflow_transaction_id: outflow.entryable_id) assert_no_difference -> { Transfer.count } do @family.auto_match_transfers! end end test "does not consider inactive accounts when matching transfers" do @depository.disable! outflow = create_transaction(date: Date.current, account: @depository, amount: 500) inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500) assert_no_difference -> { Transfer.count } do @family.auto_match_transfers! end end test "does not match transactions outside the 4-day window" do create_transaction(date: 10.days.ago.to_date, account: @depository, amount: 500) create_transaction(date: Date.current, account: @credit_card, amount: -500) assert_no_difference -> { Transfer.count } do @family.auto_match_transfers! end end test "auto-matched cash to investment assigns investment contribution category" do investment = accounts(:investment) outflow_entry = create_transaction(date: Date.current, account: @depository, amount: 500) inflow_entry = create_transaction(date: Date.current, account: investment, amount: -500) @family.auto_match_transfers! outflow_entry.reload category = @family.investment_contributions_category assert_equal category, outflow_entry.entryable.category end test "does not match multi-currency transfer with missing exchange rate" do create_transaction(date: Date.current, account: @depository, amount: 500) create_transaction(date: Date.current, account: @credit_card, amount: -700, currency: "GBP") assert_no_difference -> { Transfer.count } do @family.auto_match_transfers! end end # Regression tests for loan transfer kind assignment bug # The kind should be determined by the DESTINATION account (inflow), not the source (outflow) test "loan payment (cash to loan) assigns loan_payment kind to outflow" do # Cash → Loan: outflow from depository, inflow to loan outflow_entry = create_transaction(date: Date.current, account: @depository, amount: 500) inflow_entry = create_transaction(date: Date.current, account: @loan, amount: -500) @family.auto_match_transfers! outflow_entry.reload inflow_entry.reload # Destination is loan account, so outflow should be loan_payment assert_equal "loan_payment", outflow_entry.entryable.kind assert_equal "funds_movement", inflow_entry.entryable.kind end test "loan disbursement (loan to cash) assigns funds_movement kind to outflow" do # Loan → Cash: outflow from loan, inflow to depository outflow_entry = create_transaction(date: Date.current, account: @loan, amount: 500) inflow_entry = create_transaction(date: Date.current, account: @depository, amount: -500) @family.auto_match_transfers! outflow_entry.reload inflow_entry.reload # Destination is depository (not loan), so outflow should be funds_movement # This ensures loan disbursements don't incorrectly appear in cashflow assert_equal "funds_movement", outflow_entry.entryable.kind assert_equal "funds_movement", inflow_entry.entryable.kind end test "credit card payment (cash to credit card) assigns cc_payment kind to outflow" do # Cash → Credit Card: outflow from depository, inflow to credit card outflow_entry = create_transaction(date: Date.current, account: @depository, amount: 500) inflow_entry = create_transaction(date: Date.current, account: @credit_card, amount: -500) @family.auto_match_transfers! outflow_entry.reload inflow_entry.reload # Destination is credit card, so outflow should be cc_payment assert_equal "cc_payment", outflow_entry.entryable.kind assert_equal "funds_movement", inflow_entry.entryable.kind end private def load_exchange_prices rates = { 4.days.ago.to_date => 1.36, 3.days.ago.to_date => 1.37, 2.days.ago.to_date => 1.38, 1.day.ago.to_date => 1.39, Date.current => 1.40 } rates.each do |date, rate| # USD to CAD ExchangeRate.create!( from_currency: "USD", to_currency: "CAD", date: date, rate: rate ) # CAD to USD (inverse) ExchangeRate.create!( from_currency: "CAD", to_currency: "USD", date: date, rate: (1.0 / rate).round(6) ) end end end