require "test_helper" class SimplefinItemsControllerTest < ActionDispatch::IntegrationTest fixtures :users, :families setup do sign_in users(:family_admin) @family = families(:dylan_family) @simplefin_item = SimplefinItem.create!( family: @family, name: "Test Connection", access_url: "https://example.com/test_access" ) end test "should destroy simplefin item" do assert_difference("SimplefinItem.count", 0) do # doesn't actually delete immediately delete simplefin_item_url(@simplefin_item) end assert_redirected_to accounts_path @simplefin_item.reload assert @simplefin_item.scheduled_for_deletion? end test "should sync simplefin item" do post sync_simplefin_item_url(@simplefin_item) assert_redirected_to accounts_path end test "balances enqueues SyncJob and returns sync id as JSON" do # Expect a Sync to be enqueued via SyncJob SyncJob.expects(:perform_later).with do |sync, opts| sync.is_a?(Sync) && opts.is_a?(Hash) && opts[:balances_only] == true end.once post balances_simplefin_item_url(@simplefin_item, format: :json) assert_response :success body = JSON.parse(@response.body) assert_equal true, body["ok"], "expected ok: true" assert body["sync_id"].present?, "expected sync_id to be present" end test "relink does not disable a previously linked account that still has other provider links" do # Create two manual accounts A and B account_a = Account.create!( family: @family, name: "Manual A", balance: 0, currency: "USD", accountable_type: "Depository", accountable: Depository.create!(subtype: "checking") ) account_b = Account.create!( family: @family, name: "Manual B", balance: 0, currency: "USD", accountable_type: "Depository", accountable: Depository.create!(subtype: "savings") ) # Create a SimpleFIN account under the same item sfa_primary = SimplefinAccount.create!( simplefin_item: @simplefin_item, name: "SF A", account_id: "sf_a", account_type: "depository", currency: "USD", current_balance: 0 ) # Link the primary SimpleFIN provider to account A via AccountProvider (legacy link cleared by action) AccountProvider.create!(account: account_a, provider: sfa_primary) # Also link a different provider TYPE (Plaid) to account A so it is NOT orphaned plaid_item = PlaidItem.create!(family: @family, name: "Plaid Conn", access_token: "test-token", plaid_id: "test-plaid-id") plaid_acct = PlaidAccount.create!( plaid_item: plaid_item, plaid_id: "test-plaid-acct", name: "Plaid A", plaid_type: "depository", currency: "USD", current_balance: 0 ) AccountProvider.create!(account: account_a, provider: plaid_acct) # Perform relink: point sfa_primary at account B post link_existing_account_simplefin_items_path, params: { account_id: account_b.id, simplefin_account_id: sfa_primary.id } assert_response :see_other # Reload and assert: account A should still be enabled (not disabled) because it has another provider link account_a.reload assert account_a.account_providers.any?, "expected previous account to still have provider links" refute account_a.disabled?, "previous account should not be disabled when still linked to other providers" # And the AccountProvider for sfa_primary should now point to account B ap = AccountProvider.find_by(provider: sfa_primary) assert_equal account_b.id, ap.account_id end test "should get edit" do @simplefin_item.update!(status: :requires_update) get edit_simplefin_item_url(@simplefin_item) assert_response :success end test "should update simplefin item with valid token" do @simplefin_item.update!(status: :requires_update) # Mock the SimpleFin provider to prevent real API calls mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") mock_provider.expects(:get_accounts).returns({ accounts: [] }).at_least_once Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once # Let the real create_simplefin_item! method run - don't mock it patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "valid_token" } } assert_redirected_to accounts_path assert_equal "SimpleFin connection updated.", flash[:notice] @simplefin_item.reload assert @simplefin_item.scheduled_for_deletion? end test "should handle update with invalid token" do @simplefin_item.update!(status: :requires_update) patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "" } } assert_response :unprocessable_entity assert_includes response.body, I18n.t("simplefin_items.update.errors.blank_token", default: "Please enter a SimpleFin setup token") end test "should transfer accounts when updating simplefin item token" do @simplefin_item.update!(status: :requires_update) # Create old SimpleFin accounts linked to Maybe accounts old_simplefin_account1 = @simplefin_item.simplefin_accounts.create!( name: "Test Checking", account_id: "sf_account_123", currency: "USD", current_balance: 1000, account_type: "depository" ) old_simplefin_account2 = @simplefin_item.simplefin_accounts.create!( name: "Test Savings", account_id: "sf_account_456", currency: "USD", current_balance: 5000, account_type: "depository" ) # Create Maybe accounts linked to the SimpleFin accounts maybe_account1 = Account.create!( family: @family, name: "Checking Account", balance: 1000, currency: "USD", accountable_type: "Depository", accountable: Depository.create!(subtype: "checking"), simplefin_account_id: old_simplefin_account1.id ) maybe_account2 = Account.create!( family: @family, name: "Savings Account", balance: 5000, currency: "USD", accountable_type: "Depository", accountable: Depository.create!(subtype: "savings"), simplefin_account_id: old_simplefin_account2.id ) # Update old SimpleFin accounts to reference the Maybe accounts old_simplefin_account1.update!(account: maybe_account1) old_simplefin_account2.update!(account: maybe_account2) # Mock only the external API calls, let business logic run mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") mock_provider.expects(:get_accounts).returns({ accounts: [ { id: "sf_account_123", name: "Test Checking", type: "depository", currency: "USD", balance: 1000, transactions: [] }, { id: "sf_account_456", name: "Test Savings", type: "depository", currency: "USD", balance: 5000, transactions: [] } ] }).at_least_once Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once # Perform the update patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "valid_token" } } assert_redirected_to accounts_path assert_equal "SimpleFin connection updated.", flash[:notice] # Verify accounts were transferred to new SimpleFin accounts assert Account.exists?(maybe_account1.id), "maybe_account1 should still exist" assert Account.exists?(maybe_account2.id), "maybe_account2 should still exist" maybe_account1.reload maybe_account2.reload # Find the new SimpleFin item that was created new_simplefin_item = @family.simplefin_items.where.not(id: @simplefin_item.id).first assert_not_nil new_simplefin_item, "New SimpleFin item should have been created" new_sf_account1 = new_simplefin_item.simplefin_accounts.find_by(account_id: "sf_account_123") new_sf_account2 = new_simplefin_item.simplefin_accounts.find_by(account_id: "sf_account_456") assert_not_nil new_sf_account1, "New SimpleFin account with ID sf_account_123 should exist" assert_not_nil new_sf_account2, "New SimpleFin account with ID sf_account_456 should exist" assert_equal new_sf_account1.id, maybe_account1.simplefin_account_id assert_equal new_sf_account2.id, maybe_account2.simplefin_account_id # Verify old SimpleFin accounts no longer reference Maybe accounts old_simplefin_account1.reload old_simplefin_account2.reload assert_nil old_simplefin_account1.current_account assert_nil old_simplefin_account2.current_account # Verify old SimpleFin item is scheduled for deletion @simplefin_item.reload assert @simplefin_item.scheduled_for_deletion? end test "should handle partial account matching during token update" do @simplefin_item.update!(status: :requires_update) # Create old SimpleFin account old_simplefin_account = @simplefin_item.simplefin_accounts.create!( name: "Test Checking", account_id: "sf_account_123", currency: "USD", current_balance: 1000, account_type: "depository" ) # Create Maybe account linked to the SimpleFin account maybe_account = Account.create!( family: @family, name: "Checking Account", balance: 1000, currency: "USD", accountable_type: "Depository", accountable: Depository.create!(subtype: "checking"), simplefin_account_id: old_simplefin_account.id ) old_simplefin_account.update!(account: maybe_account) # Mock only the external API calls, let business logic run mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") # Return empty accounts list to simulate account was removed from bank mock_provider.expects(:get_accounts).returns({ accounts: [] }).at_least_once Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once # Perform update patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "valid_token" } } assert_response :redirect uri2 = URI(response.redirect_url) assert_equal "/accounts", uri2.path # Verify Maybe account still linked to old SimpleFin account (no transfer occurred) maybe_account.reload old_simplefin_account.reload assert_equal old_simplefin_account.id, maybe_account.simplefin_account_id assert_equal maybe_account, old_simplefin_account.current_account # Old item still scheduled for deletion @simplefin_item.reload assert @simplefin_item.scheduled_for_deletion? end test "select_existing_account renders empty-state modal when no available simplefin accounts" do account = accounts(:depository) get select_existing_account_simplefin_items_url(account_id: account.id) assert_response :success assert_includes @response.body, "All SimpleFIN accounts appear to be linked already." end test "destroy should unlink provider links and legacy fk" do # Create SFA and linked Account with AccountProvider sfa = @simplefin_item.simplefin_accounts.create!(name: "Linked", account_id: "sf_link_1", currency: "USD", current_balance: 1, account_type: "depository") acct = Account.create!(family: @family, name: "Manual A", currency: "USD", balance: 0, accountable_type: "Depository", accountable: Depository.create!(subtype: "checking"), simplefin_account_id: sfa.id) AccountProvider.create!(account: acct, provider_type: "SimplefinAccount", provider_id: sfa.id) delete simplefin_item_url(@simplefin_item) assert_redirected_to accounts_path # Links are removed immediately even though deletion is scheduled assert_nil acct.reload.simplefin_account_id assert_equal 0, AccountProvider.where(provider_type: "SimplefinAccount", provider_id: sfa.id).count end test "complete_account_setup creates accounts only for truly unlinked SFAs" do # Linked SFA (should be ignored by setup) linked_sfa = @simplefin_item.simplefin_accounts.create!(name: "Linked", account_id: "sf_l_1", currency: "USD", current_balance: 5, account_type: "depository") linked_acct = Account.create!(family: @family, name: "Already Linked", currency: "USD", balance: 0, accountable_type: "Depository", accountable: Depository.create!(subtype: "savings")) linked_sfa.update!(account: linked_acct) # Unlinked SFA (should be created via setup) unlinked_sfa = @simplefin_item.simplefin_accounts.create!(name: "New CC", account_id: "sf_cc_1", currency: "USD", current_balance: -20, account_type: "credit") post complete_account_setup_simplefin_item_url(@simplefin_item), params: { account_types: { unlinked_sfa.id => "CreditCard" }, account_subtypes: { unlinked_sfa.id => "credit_card" }, sync_start_date: Date.today.to_s } assert_redirected_to accounts_path assert_not @simplefin_item.reload.pending_account_setup # Linked one unchanged, unlinked now has an account linked_sfa.reload unlinked_sfa.reload # The previously linked SFA should still point to the same Maybe account via legacy FK or provider link assert_equal linked_acct.id, linked_sfa.account&.id # The newly created account for the unlinked SFA should now exist assert_not_nil unlinked_sfa.account_id end test "update redirects to accounts after setup without forcing a modal" do @simplefin_item.update!(status: :requires_update) # Mock provider to return one account so updated_item creates SFAs mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") mock_provider.expects(:get_accounts).returns({ accounts: [ { id: "sf_auto_open_1", name: "Auto Open Checking", type: "depository", currency: "USD", balance: 100, transactions: [] } ] }).at_least_once Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "valid_token" } } assert_response :redirect uri = URI(response.redirect_url) assert_equal "/accounts", uri.path end test "create does not auto-open when no candidates or unlinked" do # Mock provider interactions for item creation (no immediate account import on create) mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once post simplefin_items_url, params: { simplefin_item: { setup_token: "valid_token" } } assert_response :redirect uri = URI(response.redirect_url) assert_equal "/accounts", uri.path q = Rack::Utils.parse_nested_query(uri.query) assert !q.key?("open_relink_for"), "did not expect auto-open when nothing actionable" end test "update does not auto-open when no SFAs present" do @simplefin_item.update!(status: :requires_update) mock_provider = mock() mock_provider.expects(:claim_access_url).with("valid_token").returns("https://example.com/new_access") mock_provider.expects(:get_accounts).returns({ accounts: [] }).at_least_once Provider::Simplefin.expects(:new).returns(mock_provider).at_least_once patch simplefin_item_url(@simplefin_item), params: { simplefin_item: { setup_token: "valid_token" } } assert_response :redirect uri = URI(response.redirect_url) assert_equal "/accounts", uri.path q = Rack::Utils.parse_nested_query(uri.query) assert !q.key?("open_relink_for"), "did not expect auto-open when update produced no SFAs/candidates" end end