mirror of
https://github.com/we-promise/sure.git
synced 2026-09-09 08:34:26 +00:00
buzzromainandClaude Opus 5
d7c183d306
A GoalAccount with a NULL `allocated_amount` means "dedicate the whole
balance". Two of them on one account each claimed all of it, so the money
was counted twice:
Livret A, 6,000 precaution 6,000 vacances 6,000
progress: 100% progress: 100%
`Goal#backing_share_for` cannot catch this. Its pro-rata haircut only
scales FIXED earmarks, and an unallocated link contributes `nil.to_d` —
zero — to `others_fixed`, so the two links never see each other. The
invariant "shares never sum past the balance" held for every earmark
except the one that claims everything.
Enforce it at the door: GoalAccount now refuses a second whole-balance
link on an account another non-archived goal already claims in full, and
asks for an amount instead. The scope matches
`Goal.pooled_allocations_for` — archived goals are excluded from the
backing math, so they do not block; completed goals still hold their
money, so they do.
Rows written before this guard stay readable and editable. Autosave
revalidates every loaded goal_account on `goal.save`, so validating
untouched links would make a goal that merely holds a legacy overlap
impossible to rename. Only a new link, or one whose amount is being
cleared onto a contested account, is checked.
The goal fixtures encoded exactly the forbidden state — three goals
claiming `depository` in full — so tests that built a fourth whole
claim now use accounts of their own. `build_goal` mirrors the old
balance, leaving every KPI figure unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DJ1npaGEHr6t2HW1rYZdt4
97 lines
3.7 KiB
Ruby
97 lines
3.7 KiB
Ruby
require "test_helper"
|
|
|
|
class Assistant::Function::CreateGoalTest < ActiveSupport::TestCase
|
|
setup do
|
|
@user = users(:family_admin)
|
|
@family = @user.family
|
|
@depository = accounts(:depository)
|
|
@fn = Assistant::Function::CreateGoal.new(@user)
|
|
end
|
|
|
|
test "to_definition returns valid JSON shape" do
|
|
definition = @fn.to_definition
|
|
assert_equal "create_goal", definition[:name]
|
|
assert_kind_of String, definition[:description]
|
|
assert_equal "object", definition[:params_schema][:type]
|
|
assert_includes definition[:params_schema][:required], "name"
|
|
assert_includes definition[:params_schema][:required], "target_amount"
|
|
assert_includes definition[:params_schema][:required], "linked_account_names"
|
|
end
|
|
|
|
test "creates a goal with linked accounts" do
|
|
# A fresh account, not one the goal fixtures already claim in full:
|
|
# GoalAccount refuses a second whole-balance link on a contested account,
|
|
# and this function has no way to pass an earmark.
|
|
unclaimed = Account.create!(
|
|
family: @family, accountable: Depository.new,
|
|
name: "Vacation Savings", currency: "USD", balance: 2_000
|
|
)
|
|
|
|
assert_difference -> { Goal.count } => 1,
|
|
-> { GoalAccount.count } => 1 do
|
|
result = @fn.call(
|
|
"name" => "Vacation",
|
|
"target_amount" => 1500,
|
|
"target_date" => 3.months.from_now.to_date.iso8601,
|
|
"linked_account_names" => [ unclaimed.name ]
|
|
)
|
|
|
|
assert result[:success]
|
|
assert_match(/Vacation/, result[:message])
|
|
assert result[:url].present?
|
|
assert_equal "USD", result[:currency]
|
|
end
|
|
end
|
|
|
|
test "soft error when name is missing" do
|
|
result = @fn.call("target_amount" => 100, "linked_account_names" => [ @depository.name ])
|
|
assert_equal false, result[:success]
|
|
assert_equal "name_required", result[:error]
|
|
end
|
|
|
|
test "soft error when target_amount is zero" do
|
|
result = @fn.call("name" => "X", "target_amount" => 0, "linked_account_names" => [ @depository.name ])
|
|
assert_equal false, result[:success]
|
|
assert_equal "target_amount_invalid", result[:error]
|
|
end
|
|
|
|
test "soft error when no linked accounts" do
|
|
result = @fn.call("name" => "X", "target_amount" => 100, "linked_account_names" => [])
|
|
assert_equal false, result[:success]
|
|
assert_equal "no_linked_accounts", result[:error]
|
|
assert_kind_of Array, result[:available_accounts]
|
|
assert(result[:available_accounts].all? { |a| a.is_a?(Hash) && a.key?(:name) })
|
|
end
|
|
|
|
test "soft error when account name doesn't match" do
|
|
result = @fn.call("name" => "X", "target_amount" => 100, "linked_account_names" => [ "Nonexistent Account" ])
|
|
assert_equal false, result[:success]
|
|
assert_equal "unknown_accounts", result[:error]
|
|
assert_includes result[:unknown_names], "Nonexistent Account"
|
|
end
|
|
|
|
test "soft error when currencies differ across linked accounts" do
|
|
eur = Account.create!(family: @family, accountable: Depository.new, name: "EUR Account", currency: "EUR", balance: 100)
|
|
result = @fn.call(
|
|
"name" => "Mixed",
|
|
"target_amount" => 100,
|
|
"linked_account_names" => [ @depository.name, eur.name ]
|
|
)
|
|
assert_equal false, result[:success]
|
|
assert_equal "currency_mismatch", result[:error]
|
|
end
|
|
|
|
test "scopes to the user's family" do
|
|
other_family = Family.create!(name: "Other", currency: "USD", locale: "en", country: "US", timezone: "UTC")
|
|
Account.create!(family: other_family, accountable: Depository.new, name: "Foreign Checking", currency: "USD", balance: 100)
|
|
|
|
result = @fn.call(
|
|
"name" => "X",
|
|
"target_amount" => 100,
|
|
"linked_account_names" => [ "Foreign Checking" ]
|
|
)
|
|
assert_equal false, result[:success]
|
|
assert_equal "unknown_accounts", result[:error]
|
|
end
|
|
end
|