mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Fix OIDC household invitation (issue #900) - Auto-add existing user when inviting by email (no invite email sent) - Accept page: choose 'Create account' or 'Sign in' (supports OIDC) - Store invitation token in session on sign-in; accept after login (password, OIDC, OIDC link, OIDC JIT, MFA) - Invitation#accept_for!(user): add user to household and mark accepted - Defensive guards: nil/blank user, token normalization, accept_for! return check * Address PR review: rename accept_for! to accept_for, i18n OIDC notice, test fixes, stub Rails.application.config * Fix flaky system test: assert only configure step, not flash message Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: mkdev11 <jaysmth689+github@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
143 lines
4.2 KiB
Ruby
143 lines
4.2 KiB
Ruby
require "test_helper"
|
|
|
|
class InvitationsControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
sign_in @admin = users(:family_admin)
|
|
@invitation = invitations(:one)
|
|
end
|
|
|
|
test "should get new" do
|
|
get new_invitation_url
|
|
assert_response :success
|
|
end
|
|
|
|
test "should create invitation for member" do
|
|
Rails.application.config.stubs(:app_mode).returns("managed".inquiry)
|
|
|
|
assert_difference("Invitation.count") do
|
|
assert_enqueued_with(job: ActionMailer::MailDeliveryJob) do
|
|
post invitations_url, params: {
|
|
invitation: {
|
|
email: "new@example.com",
|
|
role: "member"
|
|
}
|
|
}
|
|
end
|
|
end
|
|
|
|
invitation = Invitation.order(created_at: :desc).first
|
|
assert_equal "member", invitation.role
|
|
assert_equal @admin, invitation.inviter
|
|
assert_equal "new@example.com", invitation.email
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.create.success"), flash[:notice]
|
|
end
|
|
|
|
test "should add existing user to household when inviting their email" do
|
|
existing_user = users(:empty)
|
|
assert existing_user.family_id != @admin.family_id
|
|
|
|
assert_difference("Invitation.count") do
|
|
assert_no_enqueued_jobs only: ActionMailer::MailDeliveryJob do
|
|
post invitations_url, params: {
|
|
invitation: {
|
|
email: existing_user.email,
|
|
role: "member"
|
|
}
|
|
}
|
|
end
|
|
end
|
|
|
|
invitation = Invitation.order(created_at: :desc).first
|
|
assert invitation.accepted_at.present?, "Invitation should be accepted"
|
|
existing_user.reload
|
|
assert_equal @admin.family_id, existing_user.family_id
|
|
assert_equal "member", existing_user.role
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.create.existing_user_added"), flash[:notice]
|
|
end
|
|
|
|
test "non-admin cannot create invitations" do
|
|
sign_in users(:family_member)
|
|
|
|
assert_no_difference("Invitation.count") do
|
|
post invitations_url, params: {
|
|
invitation: {
|
|
email: "new@example.com",
|
|
role: "admin"
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.create.failure"), flash[:alert]
|
|
end
|
|
|
|
test "admin can create admin invitation" do
|
|
assert_difference("Invitation.count") do
|
|
post invitations_url, params: {
|
|
invitation: {
|
|
email: "new@example.com",
|
|
role: "admin"
|
|
}
|
|
}
|
|
end
|
|
|
|
invitation = Invitation.order(created_at: :desc).first
|
|
assert_equal "admin", invitation.role
|
|
assert_equal @admin.family, invitation.family
|
|
assert_equal @admin, invitation.inviter
|
|
end
|
|
|
|
test "should handle invalid invitation creation" do
|
|
assert_no_difference("Invitation.count") do
|
|
post invitations_url, params: {
|
|
invitation: {
|
|
email: "",
|
|
role: "member"
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.create.failure"), flash[:alert]
|
|
end
|
|
|
|
test "should accept invitation and show choice between sign in and create account" do
|
|
get accept_invitation_url(@invitation.token)
|
|
assert_response :success
|
|
assert_select "a[href=?]", new_registration_path(invitation: @invitation.token), text: /Create new account/i
|
|
assert_select "a[href=?]", new_session_path(invitation: @invitation.token), text: /already have an account/i
|
|
end
|
|
|
|
test "should not accept invalid invitation token" do
|
|
get accept_invitation_url("invalid-token")
|
|
assert_response :not_found
|
|
end
|
|
|
|
test "admin can remove pending invitation" do
|
|
assert_difference("Invitation.count", -1) do
|
|
delete invitation_url(@invitation)
|
|
end
|
|
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.destroy.success"), flash[:notice]
|
|
end
|
|
|
|
test "non-admin cannot remove invitations" do
|
|
sign_in users(:family_member)
|
|
|
|
assert_no_difference("Invitation.count") do
|
|
delete invitation_url(@invitation)
|
|
end
|
|
|
|
assert_redirected_to settings_profile_path
|
|
assert_equal I18n.t("invitations.destroy.not_authorized"), flash[:alert]
|
|
end
|
|
|
|
test "should handle invalid invitation removal" do
|
|
delete invitation_url(id: "invalid-id")
|
|
assert_response :not_found
|
|
end
|
|
end
|