mirror of
https://github.com/we-promise/sure.git
synced 2026-05-10 06:05:00 +00:00
* chore(design-system): swap raw gray classes for semantic tokens across remaining views Finalizes the raw-color sweep started in #1652 (settings) and continued in #1654 (holdings). Covers accounts, budgets, chats, pages, imports, provider integrations (mercury, lunchflow, sophtron, enable_banking, coinstats), auth flows (password reset, MFA, registrations), shared layouts, and selected DS component hover states. 35 files, ~56 line changes. Mappings (matching the patterns established in the prior sweeps): - text-white bg-gray-900 hover:bg-gray-800 (with optional focus:ring-gray-900) -> text-inverse button-bg-primary hover:button-bg-primary-hover -> focus:ring-button-bg-primary - text-gray-500 / 600 / 700 -> text-secondary - text-gray-800 -> text-primary - text-gray-400 -> text-subdued - hover:text-gray-700 / hover:text-gray-100 -> hover:text-primary - bg-gray-50 / 100 / 200 (standalone) -> bg-surface-inset - bg-gray-500/5 -> bg-gray-tint-5 - bg-gray-500/10 -> bg-gray-tint-10 - bg-gray-900 (decorative active states) -> bg-inverse - hover:bg-gray-50 / 100 (standalone) -> hover:bg-surface-inset - hover:bg-gray-300 -> hover:bg-surface-inset-hover - bg-white hover:bg-gray-100 -> bg-container hover:bg-container-hover - border-gray-300 -> border-secondary - focus:border-gray-200 -> focus:border-secondary - focus-within:border-gray-900 -> focus-within:border-primary - DS::Buttonish outline / ghost / icon hover: hover:bg-gray-100 theme-dark:hover:bg-gray-700 -> hover:bg-container-inset-hover Left intentionally raw, with rationale: - bg-gray-300 / bg-gray-400 decorative dots and avatar circles. The raw value reads OK against both bg-container variants; no semantic "neutral indicator" token exists. Same pattern as #1652 / #1654. - bg-gray-400/20 theme-dark:bg-gray-500/20 (onboardings/trial). Custom alpha tint with no equivalent token. - bg-white theme-dark:bg-gray-700 (DS::Tabs active pill, budgets tabs). Custom tab-pill pattern; gray-700 in dark mode (one shade lighter than page bg-gray-900) is intentional for visibility. - bg-gray-100 theme-dark:bg-gray-700 (DS::Toggle base bg). Closest match (bg-container-inset-hover) is semantically a hover state. - DS::Buttonish secondary variant gray-200/300/700/600 pattern. Same pattern as #1654 holdings; needs button-bg-secondary-strong from that PR. Will swap in a follow-up after #1654 merges. - disabled:bg-gray-500 theme-dark:disabled:bg-gray-400 on inverse buttons (DS::Buttonish primary, enable_banking, coinstats). Custom disabled state for the inverse pair; no token. - text-gray-300 SVG stroke (shared/_progress_circle). - bg-white text-gray-900 (layouts/print). Print contexts intentionally light regardless of theme. - bg-gray-800 / border-gray-700 / text-white / hover:text-gray-100 (impersonation_sessions/_super_admin_bar). Admin overlay styled to remain dark in both modes; not a theme-aware component. Files covered by other in-flight PRs were skipped to avoid rebase conflicts: chats/_ai_consent's fg-inverse swap (#1626), shared/_text_tooltip and shared/_money_field tooltip pills (#1626), investments/_value_tooltip (#1626), components/DS/tooltip (#1626). * fix(design-system): keep changelog avatar text raw to preserve dark-mode contrast The changelog avatar fallback (when @release_notes[:avatar] is missing) sits inside the "decorative + raw" exception list — bg-gray-300 stays fixed across themes since no semantic neutral-indicator token exists. The earlier sweep partially themed the pair: bg-gray-300 stayed raw but text-gray-600 became text-secondary. text-secondary resolves to gray-300 in dark mode, which matches the bg → text became invisible against its own background. Reverting only the text class to text-gray-600 restores the original fixed-light placeholder behavior. Both classes raw, both themes readable. * fix(design-system): address review feedback on raw-color-sweep-finalize Six issues caught by CodeRabbit + Codex review: 1. focus:ring-button-bg-primary silently emits no CSS (×6 files). button-bg-primary is a custom @utility, not a theme color, so Tailwind's ring-{name} resolution finds no --color-button-bg-primary. Replaces with focus:ring-gray-900 theme-dark:focus:ring-white — same color flip as the button bg, but resolved through theme colors so the ring actually renders. Files: lunchflow/mercury/sophtron _api_error + _setup_required, coinstats_items/new. 2. accounts/show/_activity.html.erb: focus-within:ring-gray-100 was dead (no ring-width on the parent). Removed. 3. import/confirms/show.html.erb: uniform hover:bg-surface-inset-hover applied to both active and inactive step indicators created a jarring dark-to-light flip on the active step (bg-inverse → bg-surface-inset-hover). Now hover follows the resting state: active uses hover:bg-inverse-hover, inactive uses hover:bg-surface-inset-hover. 4. password_resets/new.html.erb: bg-white left raw alongside the migrated hover:bg-surface-inset. Swapped to bg-container so dark mode flips properly. 5. registrations/new.html.erb + password_validator_controller.js: view now uses bg-surface-inset on password strength block lines, but the Stimulus controller still toggled bg-gray-200 on validate. Updated controller to add/remove bg-surface-inset matching the view, so unmet states reset to the tokenized class instead of leaving raw gray-200 stuck on the element.
96 lines
4.2 KiB
Plaintext
96 lines
4.2 KiB
Plaintext
<%
|
|
header_title @invitation ? t(".join_family_title", family: @invitation.family.name, moniker: @invitation.family.moniker_label) : t(".title")
|
|
%>
|
|
|
|
<% if self_hosted_first_login? %>
|
|
<div class="fixed inset-0 w-full h-fit bg-container p-5 border-b border-secondary flex flex-col gap-3 items-center text-center mb-12">
|
|
<h2 class="font-bold text-primary text-xl"><%= t(".welcome_title", product_name: product_name) %></h2>
|
|
<p class="text-secondary text-secondary text-sm"><%= t(".welcome_body") %></p>
|
|
</div>
|
|
<% elsif @invitation %>
|
|
<div class="space-y-1 mb-6 text-center">
|
|
<p class="text-secondary">
|
|
<%= t(".invitation_message",
|
|
inviter: @invitation.inviter.display_name,
|
|
role: t(".role_#{@invitation.role}", default: @invitation.role.to_s.humanize.downcase)) %>
|
|
</p>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% if @user.errors.present? %>
|
|
<div class="text-red-600 flex items-center gap-2">
|
|
<%= icon("circle-alert") %>
|
|
<p class="text-sm"><%= @user.errors.full_messages.to_sentence %></p>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%= styled_form_with model: @user, url: registration_path, class: "space-y-4" do |form| %>
|
|
<%= form.email_field :email,
|
|
autofocus: false,
|
|
autocomplete: "email",
|
|
required: "required",
|
|
placeholder: "you@example.com",
|
|
label: true,
|
|
disabled: @invitation.present? %>
|
|
|
|
<% if invite_code_required? && !@invitation %>
|
|
<%= form.text_field :invite_code, required: "required", label: true, value: params[:invite] %>
|
|
<% end %>
|
|
|
|
<%= form.hidden_field :invitation, value: @invitation&.token %>
|
|
|
|
<div data-controller="password-validator">
|
|
<div data-controller="password-visibility" class="relative">
|
|
<%= form.password_field :password,
|
|
autocomplete: "new-password",
|
|
required: "required",
|
|
placeholder: t(".password_placeholder"),
|
|
label: true,
|
|
maxlength: 72,
|
|
data: {
|
|
password_validator_target: "input",
|
|
password_visibility_target: "input",
|
|
action: "input->password-validator#validate"
|
|
} %>
|
|
<button type="button"
|
|
class="absolute right-3 top-1/2 -translate-y-1/2 text-secondary hover:text-primary focus:outline-none"
|
|
data-action="click->password-visibility#toggle">
|
|
<div data-password-visibility-target="showIcon">
|
|
<%= icon("eye") %>
|
|
</div>
|
|
<div data-password-visibility-target="hideIcon">
|
|
<%= icon("eye-off") %>
|
|
</div>
|
|
</button>
|
|
</div>
|
|
|
|
<div class="flex gap-4 my-4">
|
|
<div class="h-1 bg-surface-inset rounded-full flex-grow" data-password-validator-target="blockLine" data-requirement-type="length"></div>
|
|
<div class="h-1 bg-surface-inset rounded-full flex-grow" data-password-validator-target="blockLine" data-requirement-type="case"></div>
|
|
<div class="h-1 bg-surface-inset rounded-full flex-grow" data-password-validator-target="blockLine" data-requirement-type="number"></div>
|
|
<div class="h-1 bg-surface-inset rounded-full flex-grow" data-password-validator-target="blockLine" data-requirement-type="special"></div>
|
|
</div>
|
|
|
|
<div class="space-y-1 my-4">
|
|
<div class="flex items-center gap-2 text-secondary text-sm" data-password-validator-target="requirementType" data-requirement-type="length">
|
|
<%= icon("check", size: "sm") %>
|
|
<span><%= t(".password_requirements.length") %></span>
|
|
</div>
|
|
<div class="flex items-center gap-2 text-secondary text-sm" data-password-validator-target="requirementType" data-requirement-type="case">
|
|
<%= icon("check", size: "sm") %>
|
|
<span><%= t(".password_requirements.case") %></span>
|
|
</div>
|
|
<div class="flex items-center gap-2 text-secondary text-sm" data-password-validator-target="requirementType" data-requirement-type="number">
|
|
<%= icon("check", size: "sm") %>
|
|
<span><%= t(".password_requirements.number") %></span>
|
|
</div>
|
|
<div class="flex items-center gap-2 text-secondary text-sm" data-password-validator-target="requirementType" data-requirement-type="special">
|
|
<%= icon("check", size: "sm") %>
|
|
<span><%= t(".password_requirements.special") %></span>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<%= form.submit t(".submit") %>
|
|
<% end %>
|