Files
sure/app/views/settings/securities/show.html.erb
Guillem Arias Fauste 83cb287294 chore(design-system): swap raw gray classes for semantic tokens in settings/ (#1652)
* chore(design-system): swap raw gray classes for semantic tokens in settings/

Pilot for the broader raw-color sweep. Maps 21 occurrences across 11
files to design-system equivalents:

- text-white bg-gray-900 hover:bg-gray-800 (CTA buttons)
  -> text-inverse button-bg-primary hover:button-bg-primary-hover
- bg-gray-25 / bg-gray-50 / bg-gray-100 (subtle surface backgrounds)
  -> bg-surface-inset
- bg-gray-800 (tooltip pills) -> bg-inverse
- text-white inside tooltips -> text-inverse
- text-gray-300 (muted tooltip labels) -> text-inverse opacity-70
- text-gray-600 (muted body text) -> text-secondary
- hover:text-gray-700 -> hover:text-primary
- focus:ring-gray-900 -> focus:ring-button-bg-primary

The 7 status-indicator dots (`bg-gray-400`) are intentionally left
as raw classes. Gray-400 against both light and dark container bgs
gives reasonable contrast either way, and there's no semantic token
that fits a "neutral inactive indicator" use case yet. Worth a
follow-up if a `bg-subdued` token would benefit other places.

* fix(design-system): use theme-aware focus ring on provider submit buttons

Two issues caught in code review:

1. focus:ring-button-bg-primary silently emits no CSS (CodeRabbit, Codex).
   button-bg-primary is a custom @utility, not a theme color, so Tailwind's
   ring-{name} resolution finds no --color-button-bg-primary and falls
   back to the default. Replaces with focus:ring-gray-900
   theme-dark:focus:ring-white — same color flip as the button bg, but
   resolved through theme colors so ring-{name} actually generates CSS.

2. _enable_banking_panel.html.erb dropped focus-ring + transition entirely
   in the original sweep (CodeRabbit). Restores parity with the other
   provider panels using the corrected ring classes.

Long-term cleanup: tracked under issue #1653 (modifier-aware utilities)
to make button-bg-primary also a theme color so ring-button-bg-primary
becomes valid.
2026-05-04 21:42:44 +02:00

179 lines
7.8 KiB
Plaintext

<%= content_for :page_title, t(".page_title") %>
<%= settings_section title: t(".mfa_title"), subtitle: t(".mfa_description") do %>
<div class="space-y-4">
<div class="p-3 shadow-border-xs bg-container rounded-lg md:flex md:justify-between md:items-center">
<div class="flex items-center gap-3">
<div class="w-9 h-9 rounded-full bg-surface-inset flex justify-center items-center">
<%= icon "shield-check" %>
</div>
<div class="text-sm space-y-1">
<% if Current.user.otp_required? %>
<p class="text-primary">Two-factor authentication is <span class="font-medium text-green-600">enabled</span></p>
<p class="text-secondary">Your account is protected with an additional layer of security.</p>
<% else %>
<p class="text-primary">Two-factor authentication is <span class="font-medium text-red-600">disabled</span></p>
<p class="text-secondary">Enable 2FA to add an extra layer of security to your account.</p>
<% end %>
</div>
</div>
<div class="mt-4 md:mt-0">
<% if Current.user.otp_required? %>
<%= render DS::Button.new(
text: t(".disable_mfa"),
variant: "secondary",
href: disable_mfa_path,
method: :delete,
confirm: CustomConfirm.new(
title: t(".disable_mfa_confirm"),
body: t(".disable_mfa_confirm"),
btn_text: t(".disable_mfa"),
destructive: true
)
) %>
<% else %>
<%= render DS::Link.new(
text: t(".enable_mfa"),
variant: "primary",
href: new_mfa_path
) %>
<% end %>
</div>
</div>
</div>
<% end %>
<% if Current.user.otp_required? %>
<%= settings_section title: t(".webauthn_title"), subtitle: t(".webauthn_description") do %>
<div class="space-y-4">
<% if @webauthn_credentials.any? %>
<div class="space-y-2">
<% @webauthn_credentials.each do |credential| %>
<div class="flex items-center justify-between bg-container p-4 shadow-border-xs rounded-lg">
<div class="flex items-center gap-3">
<div class="w-9 h-9 shrink-0 bg-surface rounded-full flex items-center justify-center">
<%= icon "fingerprint", class: "w-5 h-5 text-secondary" %>
</div>
<div>
<p class="font-medium text-primary"><%= credential.nickname %></p>
<p class="text-sm text-secondary">
<%= t(".webauthn_added", date: l(credential.created_at.to_date)) %>
<% if credential.last_used_at.present? %>
<span><%= t(".webauthn_last_used", time_ago: time_ago_in_words(credential.last_used_at)) %></span>
<% end %>
</p>
</div>
</div>
<%= render DS::Button.new(
text: t(".webauthn_remove"),
variant: "outline_destructive",
size: "sm",
href: settings_webauthn_credential_path(credential),
method: :delete,
confirm: CustomConfirm.new(
title: t(".webauthn_remove_confirm"),
body: t(".webauthn_remove_confirm_body"),
btn_text: t(".webauthn_remove"),
destructive: true
)
) %>
</div>
<% end %>
</div>
<% else %>
<div class="bg-surface-inset rounded-lg p-4">
<p class="text-sm text-secondary"><%= t(".webauthn_empty") %></p>
</div>
<% end %>
<%= styled_form_with scope: :webauthn_credential,
url: settings_webauthn_credentials_path,
method: :post,
class: "space-y-3",
data: {
controller: "webauthn-registration",
action: "submit->webauthn-registration#register",
webauthn_registration_options_url_value: options_settings_webauthn_credentials_path,
webauthn_registration_create_url_value: settings_webauthn_credentials_path,
webauthn_registration_unsupported_message_value: t(".webauthn_unsupported"),
webauthn_registration_error_fallback_value: t("webauthn_credentials.failure")
} do |form| %>
<%= form.text_field :nickname,
placeholder: t(".webauthn_name_placeholder"),
label: t(".webauthn_name_label"),
data: { webauthn_registration_target: "nickname" } %>
<p class="text-sm text-destructive" role="alert" aria-live="assertive" aria-atomic="true" aria-hidden="true" hidden data-webauthn-registration-target="error"></p>
<div>
<%= render DS::Button.new(
text: t(".webauthn_add"),
variant: "secondary",
icon: "fingerprint",
type: "submit"
) %>
</div>
<% end %>
</div>
<% end %>
<% end %>
<% if @oidc_identities.any? || AuthConfig.sso_providers.any? %>
<%= settings_section title: t(".sso_title"), subtitle: t(".sso_subtitle") do %>
<% if @oidc_identities.any? %>
<div class="space-y-2">
<% @oidc_identities.each do |identity| %>
<div class="flex items-center justify-between bg-container p-4 shadow-border-xs rounded-lg">
<div class="flex items-center gap-3">
<div class="w-9 h-9 shrink-0 bg-surface rounded-full flex items-center justify-center">
<% icon_name = identity.provider_config&.dig(:icon).presence || "key" %>
<%= icon icon_name, class: "w-5 h-5 text-secondary" %>
</div>
<div>
<p class="font-medium text-primary"><%= identity.provider_config&.dig(:label) || identity.provider.titleize %></p>
<p class="text-sm text-secondary"><%= identity.info&.dig("email") || t(".sso_no_email") %></p>
<p class="text-xs text-secondary">
<%= t(".sso_last_used") %>:
<%= identity.last_authenticated_at&.to_fs(:short) || t(".sso_never") %>
</p>
</div>
</div>
<% if @oidc_identities.count > 1 || Current.user.password_digest.present? %>
<%= render DS::Button.new(
text: t(".sso_disconnect"),
variant: "outline",
size: "sm",
href: settings_sso_identity_path(identity),
method: :delete,
confirm: CustomConfirm.new(
title: t(".sso_confirm_title"),
body: t(".sso_confirm_body", provider: identity.provider_config&.dig(:label) || identity.provider.titleize),
btn_text: t(".sso_confirm_button"),
destructive: true
)
) %>
<% end %>
</div>
<% end %>
</div>
<% if @oidc_identities.count == 1 && Current.user.password_digest.blank? %>
<div class="mt-4 p-3 bg-amber-50 border border-amber-200 rounded-lg">
<div class="flex items-start gap-2">
<%= icon "alert-triangle", class: "w-5 h-5 text-amber-600 shrink-0 mt-0.5" %>
<p class="text-sm text-amber-800"><%= t(".sso_warning_message") %></p>
</div>
</div>
<% end %>
<% else %>
<div class="text-center py-6">
<%= icon "link", class: "w-12 h-12 mx-auto text-secondary mb-3" %>
<p class="text-secondary"><%= t(".sso_no_identities") %></p>
<p class="text-sm text-secondary mt-2"><%= t(".sso_connect_hint") %></p>
</div>
<% end %>
<% end %>
<% end %>