mirror of
https://github.com/we-promise/sure.git
synced 2026-05-08 13:14:58 +00:00
0a96bf199d
* SimpleFIN: setup UX + same-provider relink + card-replacement detection Fixes three bugs and adds auto-detection for credit-card fraud replacement. Bugs: - Importer: per-institution auth errors no longer flip the whole item to requires_update. Partial errors stay on sync_stats so other institutions keep syncing. - Setup page: new activity badges (recent / dormant / empty / likely-closed) via SimplefinAccount::ActivitySummary. Likely-closed (dormant + near-zero balance + prior history) defaults to "skip" in the type picker. - Relink: link_existing_account allows SimpleFIN to SimpleFIN swaps by atomically detaching the old AccountProvider inside a transaction. Adds "Change SimpleFIN account" menu item on linked-account dropdowns. Feature (credit-card scope only): - SimplefinItem::ReplacementDetector runs post-sync. Pairs a linked dormant zero-balance sfa with an unlinked active sfa at the same institution and account type. Persists suggestions on Sync#sync_stats. - Inline banner on the SimpleFIN item card prompts relink via CustomConfirm. Per-pair dismiss button scoped to the current sync (resurfaces on next sync if still applicable). Auto-suppresses once the relink has landed. Dev tooling: - bin/rails simplefin:seed_fraud_scenario[email] creates a realistic broken pair for manual QA; cleanup_fraud_scenario reverses it. * Address review feedback on #1493 - ReplacementDetector: symmetric one-to-one matching. Two dormant cards pointing at the same active card are now both skipped — previously the detector could emit two suggestions that would clobber each other if the user accepted both. - ReplacementDetector: require non-blank institution names on both sides before matching. Blank-vs-blank was accidentally treated as equal, risking cross-provider false matches when SimpleFIN omitted org_data. - ActivitySummary: fall back to "posted" when "transacted_at" is 0 (SimpleFIN's "unknown" sentinel). Integer 0 is truthy in Ruby, so the previous `|| fallback` short-circuited and ignored posted. - Controller: dismiss key is now the (dormant, active) pair so dismissing one candidate for a dormant card doesn't suppress others. - Helper test: freeze time around "6.hours.ago" and "5.days.ago" assertions so they don't flake when the suite runs before 06:00. * Address second review pass on #1493 - ReplacementDetector: canonicalize account_type in one place so filtering (supported_type?) and matching (type_matches?) agree on "credit card" vs "credit_card" variants. - ReplacementDetector: skip candidates with nil current_balance. nil is "unknown," not "zero" — previously fell back to 0 and passed the near- zero gate, allowing suggestions without balance evidence.
32 lines
1.2 KiB
Plaintext
32 lines
1.2 KiB
Plaintext
<%#
|
|
Renders a one-line activity summary for a SimpleFIN account on the setup card.
|
|
Helps users distinguish live accounts from dormant ones during setup, which is
|
|
essential when an institution has replaced a card (e.g., fraud replacement)
|
|
and returns both the old (dormant) and new (active) cards for a sync cycle.
|
|
|
|
Locals:
|
|
activity - SimplefinAccount::ActivitySummary
|
|
likely_closed - Boolean (dormant AND near-zero balance)
|
|
%>
|
|
<% count = activity.recent_transaction_count %>
|
|
<% last_at = activity.last_transacted_at %>
|
|
|
|
<% if likely_closed %>
|
|
<p class="mt-1 flex items-center gap-1.5 text-xs text-warning">
|
|
<%= icon "alert-triangle", size: "sm" %>
|
|
<%= t("simplefin_items.setup_accounts.activity.likely_closed") %>
|
|
</p>
|
|
<% elsif count.positive? %>
|
|
<p class="mt-1 text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.activity.recent", count: count, when: activity_when(last_at)) %>
|
|
</p>
|
|
<% elsif last_at.present? %>
|
|
<p class="mt-1 text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.activity.dormant", days: activity.days_since_last_activity) %>
|
|
</p>
|
|
<% else %>
|
|
<p class="mt-1 text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.activity.empty") %>
|
|
</p>
|
|
<% end %>
|