mirror of
https://github.com/we-promise/sure.git
synced 2026-05-08 21:25:00 +00:00
* fix(design-system): replace undefined utility classes and broken /N modifiers
Audit of class-name resolution in views surfaced two related silent
failures across ~17 files:
1. Class names that don't exist anywhere in the design system. Tailwind
silently drops them and the element renders with no CSS for that
property.
- bg-primary (and bg-primary/5, /10, /90): never defined as a
custom utility, no --color-primary in @theme. Used as a CTA bg
in 8 places, all rendered transparent.
- text-inverted: typo of text-inverse.
- text-primary-foreground: shadcn/Radix vocabulary, not in our
token system.
- bg-accent / border-accent / text-accent: same shadcn vocabulary;
not defined.
2. Slash modifier (/N) used on custom @utility blocks. Modifiers only
resolve on Tailwind theme colors (anything in tokens.json color.*).
Custom @utility blocks compile to static @apply statements and
silently drop the /N variant. Affected uses:
- border-surface-inset/50 across provider account selectors.
- border-secondary/30, /40 in admin SSO form and simplefin setup.
- bg-surface-inset/30, /40 in settings preferences and simplefin.
Fixes:
| From | To |
|---------------------------------------------------|------------------------------------------------------|
| bg-primary text-white (and similar primary CTAs) | button-bg-primary text-inverse |
| bg-primary text-primary-foreground (badges) | button-bg-primary text-inverse |
| bg-primary text-inverted (typo) | button-bg-primary text-inverse |
| bg-primary text-primary (broken active pill) | bg-inverse text-inverse |
| bg-primary (status dot) | bg-inverse |
| bg-primary/5, bg-primary/10 (subtle accent bg) | bg-gray-tint-5, bg-gray-tint-10 |
| hover:bg-primary/90 | hover:button-bg-primary-hover |
| border-accent bg-accent/10 text-accent (badges) | border-secondary bg-surface-inset text-secondary |
| border-surface-inset/50 | border-secondary |
| border-secondary/30, /40 | border-tertiary |
| bg-surface-inset/30 | bg-surface-inset (full strength) |
| bg-surface-inset/40 | bg-container-inset |
Also documents the alpha-modifier limitation in design/tokens/README.md
under a new "Alpha modifiers in views (/N syntax)" section, with the
opacity-N convention for custom utilities and a note that the
gray-tint-5 / gray-tint-10 family (and similar pre-resolved tints) are
theme colors and accept /N modifiers natively.
The accent-badge mapping uses neutral semantics for now. A dedicated
brand-accent token (text-link-tint-10 etc.) is worth considering as a
follow-up if the "highlighted metadata badge" pattern recurs.
* fix(design-system): replace undefined divide-primary / divide-secondary with alpha tokens
Same class of bug as the rest of this PR: divide-{name} requires the
name to be a theme color (i.e. expose --color-{name}), and our custom
@utility utilities (primary, secondary, etc.) do not. Tailwind silently
drops the unrecognized class and rows render with no separator.
Spotted six instances during the visual audit:
- admin/users/index.html.erb (×2): users table + pending invitations
- admin/sso_providers/index.html.erb (×2): configured + legacy lists
- transactions/categorizes/_transaction_list.html.erb: categorize sidebar
- settings/preferences/show.html.erb: divide-secondary/60 (also broken)
Swapped to the alpha-black/white pattern already used elsewhere in the
codebase (imports/cleans/show, transactions/_summary, etc.):
divide-y divide-primary
-> divide-y divide-alpha-black-200 theme-dark:divide-alpha-white-200
divide-y divide-secondary/60
-> divide-y divide-alpha-black-100 theme-dark:divide-alpha-white-100
The lighter (-100) variant on the preferences list matches the original
intent of /60 (more subtle).
165 lines
7.9 KiB
Plaintext
165 lines
7.9 KiB
Plaintext
<% content_for :title, "Set Up SimpleFin Accounts" %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: "Set Up Your SimpleFin Accounts") do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "building-2", class: "text-primary" %>
|
|
<span class="text-primary">Choose the correct account types for your imported accounts</span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<%= form_with url: complete_account_setup_simplefin_item_path(@simplefin_item),
|
|
method: :post,
|
|
local: true,
|
|
data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: "Creating Accounts...",
|
|
turbo_frame: "_top"
|
|
},
|
|
class: "space-y-6" do |form| %>
|
|
|
|
<div class="space-y-4">
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "info", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Choose the correct account type for each SimpleFin account:</strong>
|
|
</p>
|
|
<ul class="text-xs text-secondary space-y-1 list-disc list-inside">
|
|
<li><strong>Checking or Savings</strong> - Regular bank accounts</li>
|
|
<li><strong>Credit Card</strong> - Credit card accounts</li>
|
|
<li><strong>Investment</strong> - Brokerage, 401(k), IRA accounts</li>
|
|
<li><strong>Loan or Mortgage</strong> - Debt accounts</li>
|
|
<li><strong>Other Asset</strong> - Everything else</li>
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Sync Data Information -->
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "clock", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div class="flex-1">
|
|
<p class="text-sm text-primary mb-2">
|
|
<strong>Transaction History:</strong>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
SimpleFin typically provides <strong>60-90 days</strong> of transaction history, depending on your bank.
|
|
After initial setup, new transactions will sync automatically going forward.
|
|
Historical data availability varies by institution and account type.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @simplefin_accounts.each do |simplefin_account| %>
|
|
<% inferred = @inferred_map[simplefin_account.id] || {} %>
|
|
<% activity = simplefin_account.activity_summary %>
|
|
<% near_zero_balance = (simplefin_account.current_balance || 0).to_d.abs <= 1 %>
|
|
<%# "Likely closed" requires evidence of prior activity that has since stopped.
|
|
An empty payload carries no signal (could be a brand-new card) so it renders
|
|
the neutral "no transactions imported yet" badge instead. %>
|
|
<% likely_closed = activity.last_transacted_at.present? && activity.dormant? && near_zero_balance %>
|
|
<%# Default likely-closed accounts (dormant AND near-zero balance) to "skip" so
|
|
users don't accidentally create empty Sure accounts for closed/replaced cards. %>
|
|
<% selected_type = if likely_closed
|
|
"skip"
|
|
else
|
|
inferred[:confidence] == :high ? inferred[:type] : "skip"
|
|
end %>
|
|
<%# Check if this account needs user attention (type selected but subtype missing) %>
|
|
<% types_with_subtypes = %w[Depository Investment Loan] %>
|
|
<% needs_subtype_attention = selected_type != "skip" && types_with_subtypes.include?(selected_type) && inferred[:subtype].blank? %>
|
|
|
|
<% card_class = if needs_subtype_attention
|
|
"border-2 border-warning bg-warning/5"
|
|
elsif likely_closed
|
|
"border border-tertiary bg-surface-inset"
|
|
else
|
|
"border border-primary"
|
|
end %>
|
|
<div class="rounded-lg p-4 <%= card_class %>">
|
|
<div class="flex items-center justify-between mb-3">
|
|
<div class="flex-1">
|
|
<h3 class="font-medium <%= likely_closed ? "text-secondary" : "text-primary" %>">
|
|
<%= simplefin_account.name %>
|
|
<% if simplefin_account.org_data.present? && simplefin_account.org_data['name'].present? %>
|
|
<span class="text-secondary">• <%= simplefin_account.org_data["name"] %></span>
|
|
<% end %>
|
|
</h3>
|
|
<p class="text-sm text-secondary">
|
|
<%= t(".account_card.balance") %>: <%= number_to_currency(simplefin_account.current_balance || 0, unit: simplefin_account.currency) %>
|
|
</p>
|
|
<%= render "activity_badge", activity: activity, likely_closed: likely_closed %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="space-y-3" data-controller="account-type-selector" data-account-type-selector-account-id-value="<%= simplefin_account.id %>">
|
|
<div>
|
|
<%= label_tag "account_types[#{simplefin_account.id}]", "Account Type:",
|
|
class: "block text-sm font-medium text-primary mb-2" %>
|
|
<%= select_tag "account_types[#{simplefin_account.id}]",
|
|
options_for_select(@account_type_options, selected_type),
|
|
{ class: "appearance-none bg-container border border-primary rounded-md px-3 py-2 text-sm leading-6 text-primary focus:border-primary focus:ring-1 focus:ring-primary focus:outline-none w-full",
|
|
data: {
|
|
action: "change->account-type-selector#updateSubtype"
|
|
} } %>
|
|
</div>
|
|
|
|
<!-- Subtype dropdowns (shown/hidden based on account type) -->
|
|
<div data-account-type-selector-target="subtypeContainer">
|
|
<% @subtype_options.each do |account_type, subtype_config| %>
|
|
<%= render "subtype_select", account_type: account_type, subtype_config: subtype_config, simplefin_account: simplefin_account %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% if @stale_simplefin_accounts&.any? %>
|
|
<!-- Stale Accounts Section -->
|
|
<div class="border-t border-primary mt-6 pt-6">
|
|
<div class="bg-warning/10 border border-warning rounded-lg p-4 mb-4">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "alert-triangle", size: "sm", class: "text-warning mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary font-medium mb-1">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.title") %>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
<%= t("simplefin_items.setup_accounts.stale_accounts.description") %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<% @stale_simplefin_accounts.each do |simplefin_account| %>
|
|
<%= render "stale_account_row", simplefin_account: simplefin_account, target_accounts: @target_accounts %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-3">
|
|
<%= render DS::Button.new(
|
|
text: "Create Accounts",
|
|
variant: "primary",
|
|
icon: "plus",
|
|
type: "submit",
|
|
class: "flex-1",
|
|
data: { loading_button_target: "button" }
|
|
) %>
|
|
<%= render DS::Link.new(
|
|
text: "Cancel",
|
|
variant: "secondary",
|
|
href: accounts_path
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|