mirror of
https://github.com/we-promise/sure.git
synced 2026-05-09 21:54:58 +00:00
0b7fa732ae
* feat(splits): add excluded attribute support for split children and improve rendering of split transactions * address coderabbitai suggestions to improve code quality * Fix split excluded coercion, DRY helpers, and clean up view partials Fix boolean coercion bug where string "false" from form params was truthy in Ruby, causing all split children to be marked excluded. Use ActiveModel::Type::Boolean for explicit casting in Entry#split!. Additional changes addressing code review feedback: - Extract duplicated in_split_group logic from TransactionsController and TransactionCategoriesController into TransactionsHelper - Remove redundant local_assigns.fetch calls in partials that already declare defaults via the Rails 7.1 locals: magic comment - Simplify ternary in _transaction.html.erb to pass grouped directly - Guard hidden_field_tag :grouped to only emit when value is "true" - Add model tests for excluded on split children (boolean and string) - Add controller test for excluded param through full HTTP stack - Add test confirming excluded children are dropped from balance queries * fix(splits): simplify excluded attribute boolean check * refactor(splits): extract truthy values constant for excluded check Extract the array of truthy values used for excluded attribute check into a private constant to improve code maintainability and avoid duplication of the magic array. * refactor: simplify split grouping link generation and add test coverage for excluded split parameters
15 lines
702 B
Plaintext
15 lines
702 B
Plaintext
<%# locals: (transaction:, variant:, in_split_group: false) %>
|
|
|
|
<div id="<%= dom_id(transaction, "category_menu_#{variant}") %>" class="min-w-0 overflow-hidden">
|
|
<% if transaction.transfer&.categorizable? || transaction.transfer.nil? %>
|
|
<%= render "categories/menu", transaction: transaction, in_split_group: in_split_group %>
|
|
<% else %>
|
|
<div class="hidden lg:flex">
|
|
<%= render "categories/badge", category: transaction.transfer&.payment? ? payment_category : transfer_category %>
|
|
</div>
|
|
<div class="flex lg:hidden">
|
|
<%= render "categories/badge_mobile", category: transaction.transfer&.payment? ? payment_category : transfer_category %>
|
|
</div>
|
|
<% end %>
|
|
</div>
|