mirror of
https://github.com/we-promise/sure.git
synced 2026-07-20 16:55:25 +00:00
* feat(wise): add Wise integration with JAR savings account and activity support
- Add WiseItem/WiseAccount models with full sync pipeline (importer, syncer, processor)
- Detect income vs expense using targetAccount == recipientId from borderless accounts API
- Support JAR (SAVINGS) accounts with totalWorth balance and savings subtype
- Fetch JAR activity via profile activities API (INTERBALANCE, BALANCE_CASHBACK, BALANCE_ASSET_FEE)
- Route INTERBALANCE activities to both JAR and STANDARD accounts and link as Transfer records
- Add provider connection status registration, routes, views, and i18n
- Add migration for wise_items and wise_accounts tables
- Add tests for WiseAccount, WiseEntry::Processor, WiseActivity::Processor, WiseItem::Importer, and WiseItem#link_jar_transfers!
* chore(lint): add ignore to security scan (false positive)
* fix(wise): address PR review feedback on activity routing, HTML stripping, rate limiting, and scope extraction
- Replace title string matching in activity_for_account? with resource.id vs balance_id comparison to avoid breakage when users rename JAR accounts on Wise
- Replace gsub(/<[^>]+>/, "") with ActionController::Base.helpers.strip_tags to safely handle user-controlled HTML-like content
- Wrap paginated API calls in with_rate_limit_retry (up to 3 attempts, exponential backoff) to handle 429 responses during fetch_jar_activities and fetch_transfers
- Extract WiseAccount.unlinked scope and remove duplicated left_joins query from controller
* fix(wise): address PR #2433 review feedback
- Wire @wise_items into AccountsController#index so linked accounts appear on /accounts
- Fix find_wise_account_for_linking to preserve .active scope via .merge instead of .then
- Fix cross-currency incoming transfer amount to use targetValue instead of sourceValue
- Add missing select_profiles.session_expired locale key
- Add missing account_name interpolation to link_existing_account success notice
- Use i18n for profile type labels in profile_display_name
- Trigger wise_item.sync_later after account linking in all three linking actions
- Isolate fee transaction failure so it no longer aborts the main transfer import
- Use bare raise in WiseActivity/WiseEntry processors to preserve original backtrace
- Re-raise in WiseItem::Unlinking to prevent silently orphaned Holdings
- Fix avatar badge to use design system tokens (bg-container-inset, text-primary)
* fix(wise): fix INTERBALANCE routing and encrypt pending token in session
* fix(wise): replace hand-rolled buttons/links with DS::Button and DS::Link
Address repeated sure-design DS drift findings: migrate all manual
Tailwind button_to and link_to calls in Wise views to DS::Button
(outline/outline_destructive variants) and DS::Link (secondary variant).
Add missing provider_panel.disconnect locale key for the disconnect button text.
* fix(wise): use render_provider_panel_error in create instead of missing new template
* fix(wise): add missing comma in PROVIDERS array
CI failed with a SyntaxError because the questrade entry wasn't
comma-terminated before the wise entry.
* chore(wise): re-add pipelock:ignore for pending token param
Lost when the token source moved from session to an encrypted params
field in 0b5dc886, causing the CI secret scanner to flag a false positive.
* fix(test): widen random ticker suffix to avoid rare collision flake
hex(2) only yields 65536 possible tickers, so create_trade's 4 calls per
test run had a small but nonzero chance of colliding on the unique
ticker+exchange index. hex(8) makes collisions practically impossible.
116 lines
3.7 KiB
Ruby
116 lines
3.7 KiB
Ruby
require "test_helper"
|
|
|
|
class WiseItemTest < ActiveSupport::TestCase
|
|
setup do
|
|
@family = families(:empty)
|
|
@wise_item = WiseItem.create!(
|
|
family: @family,
|
|
name: "Test Wise",
|
|
token: "test_token",
|
|
profile_id: "123",
|
|
profile_type: :business
|
|
)
|
|
|
|
@standard_account = WiseAccount.create!(
|
|
wise_item: @wise_item,
|
|
balance_id: "10000001",
|
|
name: "Wise EUR",
|
|
currency: "EUR",
|
|
raw_payload: { "type" => "STANDARD", "recipient_id" => 99999001 }
|
|
)
|
|
@standard_sure_account = Account.create!(
|
|
family: @family,
|
|
name: "Wise EUR",
|
|
accountable: Depository.new(subtype: "checking"),
|
|
balance: 0,
|
|
currency: "EUR"
|
|
)
|
|
AccountProvider.create!(account: @standard_sure_account, provider: @standard_account)
|
|
|
|
@jar_account = WiseAccount.create!(
|
|
wise_item: @wise_item,
|
|
balance_id: "10000002",
|
|
name: "Jar",
|
|
currency: "EUR",
|
|
raw_payload: { "type" => "SAVINGS", "name" => "Jar" }
|
|
)
|
|
@jar_sure_account = Account.create!(
|
|
family: @family,
|
|
name: "Jar",
|
|
accountable: Depository.new(subtype: "savings"),
|
|
balance: 0,
|
|
currency: "EUR"
|
|
)
|
|
AccountProvider.create!(account: @jar_sure_account, provider: @jar_account)
|
|
end
|
|
|
|
# link_jar_transfers!
|
|
|
|
test "links matching interbalance inflow and outflow entries as a Transfer" do
|
|
inflow_entry = create_interbalance_entry(@jar_sure_account, "5001", side: :inflow, amount: -1000.0)
|
|
outflow_entry = create_interbalance_entry(@standard_sure_account, "5001", side: :outflow, amount: 1000.0)
|
|
|
|
assert_difference "Transfer.count", 1 do
|
|
@wise_item.link_jar_transfers!
|
|
end
|
|
|
|
transfer = Transfer.find_by(inflow_transaction_id: inflow_entry.entryable_id)
|
|
assert_not_nil transfer
|
|
assert_equal outflow_entry.entryable_id, transfer.outflow_transaction_id
|
|
assert_equal "confirmed", transfer.status
|
|
end
|
|
|
|
test "does not create duplicate Transfer for already-linked pair" do
|
|
inflow_entry = create_interbalance_entry(@jar_sure_account, "5002", side: :inflow, amount: -2000.0)
|
|
outflow_entry = create_interbalance_entry(@standard_sure_account, "5002", side: :outflow, amount: 2000.0)
|
|
|
|
@wise_item.link_jar_transfers!
|
|
|
|
assert_no_difference "Transfer.count" do
|
|
@wise_item.link_jar_transfers!
|
|
end
|
|
end
|
|
|
|
test "skips unmatched inflow entries with no corresponding outflow" do
|
|
create_interbalance_entry(@jar_sure_account, "5003", side: :inflow, amount: -500.0)
|
|
|
|
assert_no_difference "Transfer.count" do
|
|
@wise_item.link_jar_transfers!
|
|
end
|
|
end
|
|
|
|
test "links multiple interbalance pairs in one call" do
|
|
create_interbalance_entry(@jar_sure_account, "6001", side: :inflow, amount: -1000.0)
|
|
create_interbalance_entry(@standard_sure_account, "6001", side: :outflow, amount: 1000.0)
|
|
create_interbalance_entry(@jar_sure_account, "6002", side: :inflow, amount: -3000.0)
|
|
create_interbalance_entry(@standard_sure_account, "6002", side: :outflow, amount: 3000.0)
|
|
|
|
assert_difference "Transfer.count", 2 do
|
|
@wise_item.link_jar_transfers!
|
|
end
|
|
end
|
|
|
|
test "does nothing when no interbalance entries exist" do
|
|
assert_no_difference "Transfer.count" do
|
|
@wise_item.link_jar_transfers!
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def create_interbalance_entry(account, resource_id, side:, amount:)
|
|
external_id = "wise_interbalance_#{resource_id}_#{side}"
|
|
transaction = Transaction.create!(kind: "funds_movement")
|
|
entry = account.entries.create!(
|
|
external_id: external_id,
|
|
source: "wise",
|
|
amount: amount,
|
|
currency: "EUR",
|
|
date: Date.today,
|
|
name: "Transfer to Jar",
|
|
entryable: transaction
|
|
)
|
|
entry
|
|
end
|
|
end
|