mirror of
https://github.com/we-promise/sure.git
synced 2026-04-13 17:14:05 +00:00
cc20e2c19c
Balance sheet totals and accountable type summaries used a SQL JOIN on exchange_rates matching only today's date, which returned NULL (defaulting to 1:1) when no rate existed for that exact date. This caused foreign currency accounts to show incorrect totals. Changes: - Refactor BalanceSheet::AccountTotals to batch-fetch exchange rates via ExchangeRate.rates_for, with provider fallback, instead of a SQL join - Refactor Accountable.balance_money to use the same batch approach - Add ExchangeRate.rates_for helper for deduplicated rate lookups - Fix net worth chart query to fall back to the nearest future rate when no historical rate exists for a given date - Add composite index on accounts (family_id, status, accountable_type) - Reuse nearest cached exchange rate within a 5-day lookback window before calling the provider, preventing redundant API calls on weekends and holidays when providers return prior-day rates https://claude.ai/code/session_01GyssBJxQqdWnuYofQRjUu8 Co-authored-by: Claude <noreply@anthropic.com>
83 lines
2.9 KiB
Ruby
83 lines
2.9 KiB
Ruby
module ExchangeRate::Provided
|
|
extend ActiveSupport::Concern
|
|
|
|
class_methods do
|
|
def provider
|
|
provider = ENV["EXCHANGE_RATE_PROVIDER"].presence || Setting.exchange_rate_provider
|
|
registry = Provider::Registry.for_concept(:exchange_rates)
|
|
registry.get_provider(provider.to_sym)
|
|
end
|
|
|
|
# Maximum number of days to look back for a cached rate before calling the provider.
|
|
NEAREST_RATE_LOOKBACK_DAYS = 5
|
|
|
|
def find_or_fetch_rate(from:, to:, date: Date.current, cache: true)
|
|
rate = find_by(from_currency: from, to_currency: to, date: date)
|
|
return rate if rate.present?
|
|
|
|
# Reuse the nearest recently-cached rate before hitting the provider.
|
|
# Providers like Yahoo Finance return the most recent trading-day rate
|
|
# (e.g. Friday for a Saturday request) and save it under that date, so
|
|
# subsequent requests for the weekend date always miss the exact lookup
|
|
# and trigger redundant API calls.
|
|
nearest = where(from_currency: from, to_currency: to)
|
|
.where(date: (date - NEAREST_RATE_LOOKBACK_DAYS)..date)
|
|
.order(date: :desc)
|
|
.first
|
|
return nearest if nearest.present?
|
|
|
|
return nil unless provider.present? # No provider configured (some self-hosted apps)
|
|
|
|
response = provider.fetch_exchange_rate(from: from, to: to, date: date)
|
|
|
|
return nil unless response.success? # Provider error
|
|
|
|
rate = response.data
|
|
begin
|
|
ExchangeRate.find_or_create_by!(
|
|
from_currency: rate.from,
|
|
to_currency: rate.to,
|
|
date: rate.date
|
|
) do |exchange_rate|
|
|
exchange_rate.rate = rate.rate
|
|
end if cache
|
|
rescue ActiveRecord::RecordNotUnique
|
|
# Race condition: another process inserted between our SELECT and INSERT
|
|
# Retry by finding the existing record
|
|
ExchangeRate.find_by!(
|
|
from_currency: rate.from,
|
|
to_currency: rate.to,
|
|
date: rate.date
|
|
) if cache
|
|
end
|
|
rate
|
|
end
|
|
|
|
# Batch-fetches exchange rates for multiple source currencies.
|
|
# Returns a hash mapping each currency to its numeric rate, defaulting to 1 when unavailable.
|
|
def rates_for(currencies, to:, date: Date.current)
|
|
currencies.uniq.each_with_object({}) do |currency, map|
|
|
rate = find_or_fetch_rate(from: currency, to: to, date: date)
|
|
map[currency] = rate&.rate || 1
|
|
end
|
|
end
|
|
|
|
# @return [Integer] The number of exchange rates synced
|
|
def import_provider_rates(from:, to:, start_date:, end_date:, clear_cache: false)
|
|
unless provider.present?
|
|
Rails.logger.warn("No provider configured for ExchangeRate.import_provider_rates")
|
|
return 0
|
|
end
|
|
|
|
ExchangeRate::Importer.new(
|
|
exchange_rate_provider: provider,
|
|
from: from,
|
|
to: to,
|
|
start_date: start_date,
|
|
end_date: end_date,
|
|
clear_cache: clear_cache
|
|
).import_provider_rates
|
|
end
|
|
end
|
|
end
|