mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
ba442d5f26
* Add Indexa Capital provider scaffold
Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.
* Fix PR 926 lint and schema CI failures
* Implement Indexa Capital provider with real API integration
- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
via /accounts/{number}/fiscal-results, get_account_balance via
/accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file
* Add tests for Indexa Capital provider integration
- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)
52 tests, 98 assertions, 0 failures
* Address code review feedback from PR #933
- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage
61 tests, 107 assertions, 0 failures
* Address code review round 2: credentials validation, RuboCop, test quality
- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference
* Address code review round 3: JSON parse safety and test precision
- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
expected value (27093.01 = sum of holdings amounts)
* Include Indexa Capital in automatic family sync
Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.
---------
Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
37 lines
1.6 KiB
Ruby
37 lines
1.6 KiB
Ruby
class ProviderMerchant < Merchant
|
|
enum :source, { plaid: "plaid", simplefin: "simplefin", lunchflow: "lunchflow", synth: "synth", ai: "ai", enable_banking: "enable_banking", coinstats: "coinstats", mercury: "mercury", indexa_capital: "indexa_capital" }
|
|
|
|
validates :name, uniqueness: { scope: [ :source ] }
|
|
validates :source, presence: true
|
|
|
|
# Convert this ProviderMerchant to a FamilyMerchant for a specific family.
|
|
# Only affects transactions belonging to that family.
|
|
# Returns the newly created FamilyMerchant.
|
|
def convert_to_family_merchant_for(family, attributes = {})
|
|
transaction do
|
|
family_merchant = family.merchants.create!(
|
|
name: attributes[:name].presence || name,
|
|
color: attributes[:color].presence || FamilyMerchant::COLORS.sample,
|
|
logo_url: logo_url,
|
|
website_url: website_url
|
|
)
|
|
|
|
# Update only this family's transactions to point to new merchant
|
|
family.transactions.where(merchant_id: id).update_all(merchant_id: family_merchant.id)
|
|
|
|
family_merchant
|
|
end
|
|
end
|
|
|
|
# Unlink from family's transactions (set merchant_id to null).
|
|
# Does NOT delete the ProviderMerchant since it may be used by other families.
|
|
# Tracks the unlink in FamilyMerchantAssociation so it shows as "recently unlinked".
|
|
def unlink_from_family(family)
|
|
family.transactions.where(merchant_id: id).update_all(merchant_id: nil)
|
|
|
|
# Track that this merchant was unlinked from this family
|
|
association = FamilyMerchantAssociation.find_or_initialize_by(family: family, merchant: self)
|
|
association.update!(unlinked_at: Time.current)
|
|
end
|
|
end
|