mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
* Add `investment_activity_label` to trades and enhance activity label handling - Introduced `investment_activity_label` column to the `trades` table with a migration. - Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`). - Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels. - Updated views and controllers to display and manage activity labels for trades. - Added localized badge components for displaying and editing labels dynamically. - Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically. - Added investment flows section to reports for tracking contributions and withdrawals. - Refactored related tests and models for consistency and to ensure proper validation and filtering. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Add safeguard for `dropdownTarget` existence in quick edit controller - Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility. * Fix undefined method 'category' for Trade on mobile view Trade model uses investment_activity_label, not category. The upstream merge introduced a call to trade.category which doesn't exist. Use the activity label badge on mobile instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix activity label logic for zero/blank quantity and sell inference - Return `nil` for blank or zero quantity in `investment_activity_label_for`. - Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`. * Fix i18n key paths in transactions controller for convert_to_trade - Update flash message translations to use full i18n paths. - Use `BigDecimal` for quantity and price calculations to improve precision. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
109 lines
3.3 KiB
Ruby
109 lines
3.3 KiB
Ruby
require "test_helper"
|
|
require "ostruct"
|
|
|
|
class TradeImportTest < ActiveSupport::TestCase
|
|
include ActiveJob::TestHelper, ImportInterfaceTest
|
|
|
|
setup do
|
|
@subject = @import = imports(:trade)
|
|
@provider = mock
|
|
Security.stubs(:provider).returns(@provider)
|
|
end
|
|
|
|
test "imports trades and accounts" do
|
|
aapl_resolver = mock
|
|
googl_resolver = mock
|
|
|
|
Security::Resolver.expects(:new)
|
|
.with("AAPL", exchange_operating_mic: nil)
|
|
.returns(aapl_resolver)
|
|
.once
|
|
|
|
Security::Resolver.expects(:new)
|
|
.with("GOOGL", exchange_operating_mic: "XNAS")
|
|
.returns(googl_resolver)
|
|
.once
|
|
|
|
aapl = securities(:aapl)
|
|
googl = Security.create!(ticker: "GOOGL", exchange_operating_mic: "XNAS")
|
|
|
|
aapl_resolver.stubs(:resolve).returns(aapl)
|
|
googl_resolver.stubs(:resolve).returns(googl)
|
|
|
|
import = <<~CSV
|
|
date,ticker,qty,price,currency,account,name,exchange_operating_mic
|
|
01/01/2024,AAPL,10,150.00,USD,TestAccount1,Apple Purchase,
|
|
01/02/2024,GOOGL,5,2500.00,USD,TestAccount1,Google Purchase,XNAS
|
|
CSV
|
|
|
|
@import.update!(
|
|
account: accounts(:depository),
|
|
raw_file_str: import,
|
|
date_col_label: "date",
|
|
ticker_col_label: "ticker",
|
|
qty_col_label: "qty",
|
|
price_col_label: "price",
|
|
exchange_operating_mic_col_label: "exchange_operating_mic",
|
|
date_format: "%m/%d/%Y",
|
|
signage_convention: "inflows_positive"
|
|
)
|
|
|
|
@import.generate_rows_from_csv
|
|
|
|
@import.mappings.create! key: "TestAccount1", create_when_empty: true, type: "Import::AccountMapping"
|
|
|
|
@import.reload
|
|
|
|
assert_difference -> { Entry.count } => 2,
|
|
-> { Trade.count } => 2,
|
|
-> { Account.count } => 1 do
|
|
@import.publish
|
|
end
|
|
|
|
assert_equal "complete", @import.status
|
|
end
|
|
|
|
test "auto-assigns investment activity labels to buy and sell trades" do
|
|
aapl = securities(:aapl)
|
|
aapl_resolver = mock
|
|
aapl_resolver.stubs(:resolve).returns(aapl)
|
|
Security::Resolver.stubs(:new).returns(aapl_resolver)
|
|
|
|
account = accounts(:depository)
|
|
|
|
import = <<~CSV
|
|
date,ticker,qty,price,currency,name
|
|
01/01/2024,AAPL,10,150.00,USD,Apple Buy
|
|
01/02/2024,AAPL,-5,160.00,USD,Apple Sell
|
|
CSV
|
|
|
|
@import.update!(
|
|
account: account,
|
|
raw_file_str: import,
|
|
date_col_label: "date",
|
|
ticker_col_label: "ticker",
|
|
qty_col_label: "qty",
|
|
price_col_label: "price",
|
|
date_format: "%m/%d/%Y",
|
|
signage_convention: "inflows_positive"
|
|
)
|
|
|
|
@import.generate_rows_from_csv
|
|
@import.reload
|
|
|
|
assert_difference -> { Trade.count } => 2 do
|
|
@import.publish
|
|
end
|
|
|
|
# Find trades created by this import
|
|
imported_trades = Trade.joins(:entry).where(entries: { import_id: @import.id })
|
|
buy_trade = imported_trades.find { |t| t.qty.positive? }
|
|
sell_trade = imported_trades.find { |t| t.qty.negative? }
|
|
|
|
assert_not_nil buy_trade, "Buy trade should have been created"
|
|
assert_not_nil sell_trade, "Sell trade should have been created"
|
|
assert_equal "Buy", buy_trade.investment_activity_label, "Buy trade should have 'Buy' activity label"
|
|
assert_equal "Sell", sell_trade.investment_activity_label, "Sell trade should have 'Sell' activity label"
|
|
end
|
|
end
|