mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
* fix: Include investment_contribution in transfer? check and protect transfer entries from sync Transfer transactions with kind "investment_contribution" were not recognized as transfers by the UI, causing missing +/- indicators, "Transfer" labels, and showing regular transaction forms instead of transfer details. Also adds user_modified: true to entries created via TransferMatchesController and SetAsTransferOrPayment rule action to protect them from provider sync overwrites, matching the existing behavior in Transfer::Creator. https://claude.ai/code/session_019BZ5Z1aqKSK3cRdR81P5Jg * fix: Centralize transfer/budget kind constants for consistent investment_contribution handling Define TRANSFER_KINDS and BUDGET_EXCLUDED_KINDS on Transaction to eliminate hard-coded kind lists scattered across filters, rules, and analytics code. investment_contribution is now consistently treated as a transfer in search filters, rule conditions, and UI display (via TRANSFER_KINDS), while budget analytics correctly continue treating it as an expense (via BUDGET_EXCLUDED_KINDS). https://claude.ai/code/session_019BZ5Z1aqKSK3cRdR81P5Jg * fix: Update tests for consistent investment_contribution as transfer kind - search_test: loan_payment is now in TRANSFER_KINDS, so uncategorized filter correctly excludes it (same as funds_movement/cc_payment) - condition_test: investment_contribution is now a transfer kind, so it matches the transfer filter rather than expense filter https://claude.ai/code/session_019BZ5Z1aqKSK3cRdR81P5Jg * fix: Eliminate SQL injection warnings in Transaction::Search Replace string-interpolated SQL with parameterized queries: - totals: use sanitize_sql_array with ? placeholders - apply_category_filter: pass TRANSFER_KINDS as bind parameter - apply_type_filter: use where(kind:)/where.not(kind:) and parameterized IN (?) for compound OR conditions - Remove unused transfer_kinds_sql helper https://claude.ai/code/session_019BZ5Z1aqKSK3cRdR81P5Jg --------- Co-authored-by: Claude <noreply@anthropic.com>
79 lines
2.5 KiB
Ruby
79 lines
2.5 KiB
Ruby
require "test_helper"
|
|
|
|
class TransferMatchesControllerTest < ActionDispatch::IntegrationTest
|
|
include EntriesTestHelper
|
|
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
end
|
|
|
|
test "matches existing transaction and creates transfer" do
|
|
inflow_transaction = create_transaction(amount: 100, account: accounts(:depository))
|
|
outflow_transaction = create_transaction(amount: -100, account: accounts(:investment))
|
|
|
|
assert_difference "Transfer.count", 1 do
|
|
post transaction_transfer_match_path(inflow_transaction), params: {
|
|
transfer_match: {
|
|
method: "existing",
|
|
matched_entry_id: outflow_transaction.id
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert_equal "Transfer created", flash[:notice]
|
|
end
|
|
|
|
test "creates transfer for target account" do
|
|
inflow_transaction = create_transaction(amount: 100, account: accounts(:depository))
|
|
|
|
assert_difference [ "Transfer.count", "Entry.count", "Transaction.count" ], 1 do
|
|
post transaction_transfer_match_path(inflow_transaction), params: {
|
|
transfer_match: {
|
|
method: "new",
|
|
target_account_id: accounts(:investment).id
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert_equal "Transfer created", flash[:notice]
|
|
end
|
|
|
|
test "new transfer entry is protected from provider sync" do
|
|
outflow_entry = create_transaction(amount: 100, account: accounts(:depository))
|
|
|
|
post transaction_transfer_match_path(outflow_entry), params: {
|
|
transfer_match: {
|
|
method: "new",
|
|
target_account_id: accounts(:investment).id
|
|
}
|
|
}
|
|
|
|
transfer = Transfer.order(created_at: :desc).first
|
|
new_entry = transfer.inflow_transaction.entry
|
|
|
|
assert new_entry.user_modified?, "New transfer entry should be marked as user_modified to protect from provider sync"
|
|
end
|
|
|
|
test "assigns investment_contribution kind and category for investment destination" do
|
|
# Outflow from depository (positive amount), target is investment
|
|
outflow_entry = create_transaction(amount: 100, account: accounts(:depository))
|
|
|
|
post transaction_transfer_match_path(outflow_entry), params: {
|
|
transfer_match: {
|
|
method: "new",
|
|
target_account_id: accounts(:investment).id
|
|
}
|
|
}
|
|
|
|
outflow_entry.reload
|
|
outflow_txn = outflow_entry.entryable
|
|
|
|
assert_equal "investment_contribution", outflow_txn.kind
|
|
|
|
category = @user.family.investment_contributions_category
|
|
assert_equal category, outflow_txn.category
|
|
end
|
|
end
|