mirror of
https://github.com/we-promise/sure.git
synced 2026-04-09 15:24:48 +00:00
- Fix display issues on the settings -> merchants page. Currently it was showing only user created merchants, not provider created ones. - SimpleFin had its own MerchantDetector class that directly called ProviderMerchant.find_or_create_by! - This was inconsistent with Plaid and Lunchflow which use the centralized import_adapter.find_or_create_merchant method - Different unique keys: SimpleFin used source + name, others used source + provider_merchant_id
124 lines
3.6 KiB
Ruby
124 lines
3.6 KiB
Ruby
require "digest/md5"
|
|
|
|
class SimplefinEntry::Processor
|
|
# simplefin_transaction is the raw hash fetched from SimpleFin API and converted to JSONB
|
|
def initialize(simplefin_transaction, simplefin_account:)
|
|
@simplefin_transaction = simplefin_transaction
|
|
@simplefin_account = simplefin_account
|
|
end
|
|
|
|
def process
|
|
import_adapter.import_transaction(
|
|
external_id: external_id,
|
|
amount: amount,
|
|
currency: currency,
|
|
date: date,
|
|
name: name,
|
|
source: "simplefin",
|
|
merchant: merchant
|
|
)
|
|
end
|
|
|
|
private
|
|
attr_reader :simplefin_transaction, :simplefin_account
|
|
|
|
def import_adapter
|
|
@import_adapter ||= Account::ProviderImportAdapter.new(account)
|
|
end
|
|
|
|
def account
|
|
simplefin_account.current_account
|
|
end
|
|
|
|
def data
|
|
@data ||= simplefin_transaction.with_indifferent_access
|
|
end
|
|
|
|
def external_id
|
|
id = data[:id].presence
|
|
raise ArgumentError, "SimpleFin transaction missing id: #{data.inspect}" unless id
|
|
"simplefin_#{id}"
|
|
end
|
|
|
|
def name
|
|
# Use SimpleFin's rich, clean data to create informative transaction names
|
|
payee = data[:payee]
|
|
description = data[:description]
|
|
|
|
# Combine payee + description when both are present and different
|
|
if payee.present? && description.present? && payee != description
|
|
"#{payee} - #{description}"
|
|
elsif payee.present?
|
|
payee
|
|
elsif description.present?
|
|
description
|
|
else
|
|
data[:memo] || "Unknown transaction"
|
|
end
|
|
end
|
|
|
|
def amount
|
|
parsed_amount = case data[:amount]
|
|
when String
|
|
BigDecimal(data[:amount])
|
|
when Numeric
|
|
BigDecimal(data[:amount].to_s)
|
|
else
|
|
BigDecimal("0")
|
|
end
|
|
|
|
# SimpleFin uses banking convention (expenses negative, income positive)
|
|
# Maybe expects opposite convention (expenses positive, income negative)
|
|
# So we negate the amount to convert from SimpleFin to Maybe format
|
|
-parsed_amount
|
|
rescue ArgumentError => e
|
|
Rails.logger.error "Failed to parse SimpleFin transaction amount: #{data[:amount].inspect} - #{e.message}"
|
|
raise
|
|
end
|
|
|
|
def currency
|
|
data[:currency] || account.currency
|
|
end
|
|
|
|
def date
|
|
case data[:posted]
|
|
when String
|
|
Date.parse(data[:posted])
|
|
when Integer, Float
|
|
# Unix timestamp
|
|
Time.at(data[:posted]).to_date
|
|
when Time, DateTime
|
|
data[:posted].to_date
|
|
when Date
|
|
data[:posted]
|
|
else
|
|
Rails.logger.error("SimpleFin transaction has invalid date value: #{data[:posted].inspect}")
|
|
raise ArgumentError, "Invalid date format: #{data[:posted].inspect}"
|
|
end
|
|
rescue ArgumentError, TypeError => e
|
|
Rails.logger.error("Failed to parse SimpleFin transaction date '#{data[:posted]}': #{e.message}")
|
|
raise ArgumentError, "Unable to parse transaction date: #{data[:posted].inspect}"
|
|
end
|
|
|
|
|
|
def merchant
|
|
# Use SimpleFin's clean payee data for merchant detection
|
|
payee = data[:payee]&.strip
|
|
return nil unless payee.present?
|
|
|
|
@merchant ||= import_adapter.find_or_create_merchant(
|
|
provider_merchant_id: generate_merchant_id(payee),
|
|
name: payee,
|
|
source: "simplefin"
|
|
)
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
Rails.logger.error "SimplefinEntry::Processor - Failed to create merchant '#{payee}': #{e.message}"
|
|
nil
|
|
end
|
|
|
|
def generate_merchant_id(merchant_name)
|
|
# Generate a consistent ID for merchants without explicit IDs
|
|
"simplefin_#{Digest::MD5.hexdigest(merchant_name.downcase)}"
|
|
end
|
|
end
|