mirror of
https://github.com/we-promise/sure.git
synced 2026-07-12 04:45:19 +00:00
* chore(deps): upgrade Rails 7.2 → 8.1 Rails 7.2 reaches end of life on 2026-08-09. Bump the framework to the current 8.1.x line. - Gemfile: rails "~> 8.0" (resolves 8.1.3); bundle update rails pulls the Rails 8 framework gems plus the bumps it requires — ViewComponent 3.23 → 4.x (Rails 8 support), rails-i18n 7 → 8, rswag, and transitive deps. - app/models/transfer.rb: make Transfer#date nil-safe (inflow_transaction&.entry&.date). Rails 8's date_field evaluates the field default on a new/unpersisted Transfer (the new-transfer form), where the association is nil; without this, TransfersController#new raises "undefined method 'entry' for nil". Matches the &. pattern already used in Transfer#sync_account_later. Framework behavioral defaults are unchanged (config.load_defaults stays as-is). Validated on Rails 8.1.3: zeitwerk:check passes, full suite green (4904 runs, 0 failures, 0 errors), rubocop and brakeman clean. * fix(rails8): style textarea + deterministic property edit system test The Rails 8 gem bump kept config.load_defaults at 7.2, but Rails 8 renamed two ActionView::Helpers::FormBuilder field helpers regardless of defaults: :text_area → :textarea and :check_box → :checkbox. StyledFormBuilder builds its styled helpers from `field_helpers`, so `form.text_area` (e.g. the account "Notes" field) silently fell through to the unstyled base helper and rendered without a label — failing 8 system tests with `Unable to find field "Notes"`. - app/helpers/styled_form_builder.rb: exclude both spellings of the non-text helpers (:check_box and :checkbox) and alias the legacy `text_area` to the Rails 8 `textarea` so existing call sites stay styled. Harmless on Rails 7.2 (old names present instead). - test/system/property_test.rb: open the property edit dialog via the account menu with a retry. The account page issues a Turbo morph refresh shortly after load (turbo_refreshes_with :morph + a family-stream broadcast); opening the modal while that refresh is in flight let the morph re-render the page and wipe the just-loaded #modal turbo-frame. Rails 8 timing made the race deterministic. Retrying once the refresh has settled makes the test stable (confirmed via Turbo frame-load vs full-page morph event traces; 3x green in isolation). - config/brakeman.ignore: the added comment block shifted the pre-existing (already-ignored, Weak) class_eval Dangerous Eval warning from line 5 -> 10, changing its fingerprint. Re-point the existing suppression to the new fingerprint/line so scan_ruby stays green. Validated on Rails 8.1.3: full system suite green (92 runs, 355 assertions, 0 failures, 0 errors), rubocop clean, brakeman 0 warnings, CodeRabbit no findings. * chore(deps): pin rails to the 8.1 minor line (~> 8.1.0) Tighten the constraint from `~> 8.0` to `~> 8.1.0` (>= 8.1.0, < 8.2) so a future `bundle update rails` tracks the 8.1.x line rather than silently jumping to 8.2 when it ships. Matches the upgrade plan's stated intent (target 8.1.x for the EOL runway) and a review note on #2301. No resolved-version changes: bundle install keeps rails at 8.1.3 and every other locked gem unchanged — only the Gemfile.lock DEPENDENCIES constraint line moves. zeitwerk:check still passes; the already-green unit/system suites ran on this exact resolved tree. * chore(rails8): adopt Rails 8.1 framework defaults (config.load_defaults 8.1) The gem bump above kept config.load_defaults at 7.2 so the change set could be reasoned about in stages; this finalizes the upgrade by adopting the modern framework defaults now that the suite is green on Rails 8.1. Rails 8.0 added no new framework defaults (there is no new_framework_defaults_8_0 template), so 7.2 -> 8.1 is the single meaningful step. No incremental new_framework_defaults_8_1.rb opt-in file is needed: the full suites pass with all 8.1 defaults enabled at once. The 8.1 defaults this turns on include action_on_path_relative_redirect=:raise (open-redirect hardening), raise_on_missing_required_finder_order_columns, escape_json_responses=false / escape_js_separators_in_json=false (JSON perf), and Ruby-parser template-dependency tracking. Validated with no application code changes: bin/rails test 4904/0/0, bin/rails test:system 92/0/0, rubocop + brakeman clean. * chore(ci): restore brakeman CheckEOLRails now that the app is on Rails 8.1 config/brakeman.yml existed only to skip brakeman's CheckEOLRails. That check fires on the calendar (it warns 60 days before a framework's EOL and escalates as the date nears), so Rails 7.2's 2026-08-09 EOL turned `bin/brakeman` red (exit 3) on every branch and on main regardless of the diff. The skip carried a TODO to remove it once Sure upgraded off 7.2. This PR puts the app on Rails 8.1 (EOL well in the future), so the skip is obsolete; remove the file (its sole content was the skip) in the same change that makes it unnecessary -- no stale-config window. brakeman auto-loads the file when present and falls back to defaults when absent, and nothing references it explicitly. CheckEOLRuby was already enabled and is unchanged; config/brakeman.ignore is untouched. Validated on Rails 8.1: bin/brakeman runs EOLRails + EOLRuby, 0 warnings, 0 errors, exit 0.
152 lines
4.0 KiB
Ruby
152 lines
4.0 KiB
Ruby
class Transfer < ApplicationRecord
|
|
belongs_to :inflow_transaction, class_name: "Transaction"
|
|
belongs_to :outflow_transaction, class_name: "Transaction"
|
|
|
|
enum :status, { pending: "pending", confirmed: "confirmed" }
|
|
|
|
validates :inflow_transaction_id, uniqueness: true
|
|
validates :outflow_transaction_id, uniqueness: true
|
|
|
|
validate :transfer_has_different_accounts
|
|
validate :transfer_has_opposite_amounts
|
|
validate :transfer_within_date_range
|
|
validate :transfer_has_same_family
|
|
|
|
class << self
|
|
def kind_for_account(account)
|
|
if account.loan?
|
|
"loan_payment"
|
|
elsif account.credit_card?
|
|
"cc_payment"
|
|
elsif account.investment? || account.crypto?
|
|
"investment_contribution"
|
|
elsif account.liability?
|
|
"cc_payment"
|
|
else
|
|
"funds_movement"
|
|
end
|
|
end
|
|
end
|
|
|
|
def reject!
|
|
Transfer.transaction do
|
|
RejectedTransfer.find_or_create_by!(inflow_transaction_id: inflow_transaction_id, outflow_transaction_id: outflow_transaction_id)
|
|
destroy!
|
|
end
|
|
end
|
|
|
|
# Once transfer is destroyed, we need to mark the denormalized kind fields on the transactions
|
|
def destroy!
|
|
Transfer.transaction do
|
|
[ inflow_transaction, outflow_transaction ].each do |transaction|
|
|
next if transaction.nil?
|
|
next unless Transaction.exists?(transaction.id)
|
|
begin
|
|
transaction.update!(kind: "standard")
|
|
rescue ActiveRecord::RecordNotFound
|
|
rescue NoMethodError
|
|
next
|
|
end
|
|
end
|
|
super
|
|
end
|
|
end
|
|
|
|
def confirm!
|
|
update!(status: "confirmed")
|
|
end
|
|
|
|
def date
|
|
inflow_transaction&.entry&.date
|
|
end
|
|
|
|
def sync_account_later
|
|
inflow_transaction&.entry&.sync_account_later
|
|
outflow_transaction&.entry&.sync_account_later
|
|
end
|
|
|
|
def to_account
|
|
inflow_transaction&.entry&.account
|
|
end
|
|
|
|
def from_account
|
|
outflow_transaction&.entry&.account
|
|
end
|
|
|
|
def amount_abs
|
|
inflow_transaction&.entry&.amount_money&.abs
|
|
end
|
|
|
|
def name
|
|
acc = to_account
|
|
if payment?
|
|
acc ? "Payment to #{acc.name}" : "Payment"
|
|
else
|
|
acc ? "Transfer to #{acc.name}" : "Transfer"
|
|
end
|
|
end
|
|
|
|
def payment?
|
|
to_account&.liability?
|
|
end
|
|
|
|
def loan_payment?
|
|
outflow_transaction&.kind == "loan_payment"
|
|
end
|
|
|
|
def liability_payment?
|
|
outflow_transaction&.kind == "cc_payment"
|
|
end
|
|
|
|
def regular_transfer?
|
|
outflow_transaction&.kind == "funds_movement"
|
|
end
|
|
|
|
def transfer_type
|
|
return "loan_payment" if loan_payment?
|
|
return "liability_payment" if liability_payment?
|
|
"transfer"
|
|
end
|
|
|
|
def categorizable?
|
|
to_account&.accountable_type == "Loan"
|
|
end
|
|
|
|
private
|
|
def transfer_has_different_accounts
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
errors.add(:base, :different_accounts) if to_account == from_account
|
|
end
|
|
|
|
def transfer_has_same_family
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
errors.add(:base, :same_family) unless to_account&.family == from_account&.family
|
|
end
|
|
|
|
def transfer_has_opposite_amounts
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
|
|
inflow_entry = inflow_transaction.entry
|
|
outflow_entry = outflow_transaction.entry
|
|
|
|
inflow_amount = inflow_entry.amount
|
|
outflow_amount = outflow_entry.amount
|
|
|
|
if inflow_entry.currency == outflow_entry.currency
|
|
# For same currency, amounts must be exactly opposite
|
|
errors.add(:base, :opposite_amounts) if inflow_amount + outflow_amount != 0
|
|
else
|
|
# For different currencies, just check the signs are opposite
|
|
errors.add(:base, :opposite_amounts) unless inflow_amount.negative? && outflow_amount.positive?
|
|
end
|
|
end
|
|
|
|
def transfer_within_date_range
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
|
|
date_diff = (inflow_transaction.entry.date - outflow_transaction.entry.date).abs
|
|
max_days = status == "confirmed" ? 30 : 4
|
|
errors.add(:base, :within_days, count: max_days) if date_diff > max_days
|
|
end
|
|
end
|