mirror of
https://github.com/we-promise/sure.git
synced 2026-07-13 05:15:19 +00:00
9487e6cbfb
* feat(api): allow multiple active API keys per user Previously a user could hold only one active API key; creating a new one silently revoked the existing key, breaking any app using it. Allow multiple named active keys instead. - Drop the one-active-key-per-source validation; add name uniqueness among the user's active visible keys (revoked names are reusable, same name allowed across users). - Rewrite Settings::ApiKeysController as a RESTful collection (index/show/new/create/destroy); create no longer revokes existing keys, and key lookup is scoped to the current user's active keys. - resource :api_key -> resources :api_keys. - Add an API keys list view with per-key revoke and an empty state; rewrite the show page for a single key. - Update i18n (remove single-key copy, pluralise nav label) and tests. * refactor(api): address review on multiple API keys - Remove unreachable destroy branches (cannot_revoke is guarded by the .visible 404; revoke! raises rather than returning false) and document that .visible is the demo-key revocation guard. - Delete the orphaned created.html.erb / created.turbo_stream.erb templates (no action renders them) and their unused locale keys. - Extract shared partials (_scope_badges, _status_indicator, _key_meta, _key_reveal, _usage) to de-duplicate the index and show views; unify the active-status indicator on the standard dot. - Carry forward the @container / @lg:flex-row / min-w-0 responsive fixes from #2079 into the shared key-reveal partial. * test(api): cover newly-created API key confirmation render * refactor(api): harden demo-key guard and address review nits - Document the demo-key revocation guard on ApiKey's `visible` scope (the authoritative spot) and add a model test locking the invariant that `.visible` excludes the demo monitoring key. - _scope_badges: use an i18n lookup with a humanize fallback instead of bypassing translation for unknown scopes. - _key_reveal: drop the hard-coded `id` from the shared partial; the system test now locates the key via its data-clipboard-target. * refactor(api-keys): migrate hand-rolled badges to DS::Pill Replace raw span elements in scope badges and status indicator with DS::Pill to align with the design system migration convention. * fix(loans): opening anchor now uses current balance, not original principal When creating a loan manually, the opening anchor valuation was being set to `initial_balance` (the original loan principal) instead of `account.balance` (the current outstanding balance). After the sync job ran, `account.balance` was overwritten to match the anchor, making every manually-created loan show its original principal as the current balance. Fix by always using `account.balance` for the opening anchor in `create_and_sync`, and reading `Loan#original_balance` from the `loans.initial_balance` column directly (with a fallback to `first_valuation_amount` for provider-synced loans that may not have the column populated). * fix(api-keys): strip accidental loan changes; rescue revoke! failures The fix(loans) commit was accidentally committed into this branch. Remove the loan-related changes from account.rb, loan.rb, and both test files, restoring them to their pre-loan-commit state. Also fix the destroy action: revoke! uses update! internally which raises ActiveRecord::RecordInvalid on failure rather than returning false. Add rescue for RecordInvalid and RecordNotDestroyed so failures produce a flash alert instead of a 500. Re-adds the revoke_failed locale key that was dropped from settings.api_keys.destroy. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
54 lines
1.9 KiB
Plaintext
54 lines
1.9 KiB
Plaintext
<%= content_for :page_title, t(".create_new_api_key") %>
|
|
|
|
<%= settings_section title: nil, subtitle: t(".subtitle") do %>
|
|
<%= styled_form_with model: @api_key, url: settings_api_keys_path, class: "space-y-4" do |form| %>
|
|
<%= form.text_field :name,
|
|
placeholder: t(".name_placeholder"),
|
|
label: t(".name_label"),
|
|
help_text: t(".name_help_text") %>
|
|
|
|
<div>
|
|
<%= form.label :scopes, t(".permissions_label"), class: "block text-sm font-medium text-primary mb-2" %>
|
|
<p class="text-sm text-secondary mb-3"><%= t(".permissions_help") %></p>
|
|
|
|
<div class="space-y-2">
|
|
<% [
|
|
["read", t(".scope_read_only"), t(".scope_read_only_description")],
|
|
["read_write", t(".scope_read_write"), t(".scope_read_write_description")]
|
|
].each do |value, label, description| %>
|
|
<div class="bg-surface-inset rounded-lg p-3 border border-primary">
|
|
<label class="flex items-start gap-3 cursor-pointer">
|
|
<%= radio_button_tag "api_key[scopes]", value, (@api_key&.scopes || []).include?(value),
|
|
class: "mt-1" %>
|
|
<div class="flex-1">
|
|
<div class="font-medium text-primary"><%= label %></div>
|
|
<div class="text-sm text-secondary mt-1"><%= description %></div>
|
|
</div>
|
|
</label>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
|
|
<%= render DS::Alert.new(title: t(".security_warning_title"), variant: :warning) do %>
|
|
<p>
|
|
<%= t(".security_warning_body") %>
|
|
</p>
|
|
<% end %>
|
|
|
|
<div class="flex justify-end gap-3 pt-4 border-t border-primary">
|
|
<%= render DS::Link.new(
|
|
text: t(".cancel"),
|
|
href: settings_api_keys_path,
|
|
variant: "ghost"
|
|
) %>
|
|
|
|
<%= render DS::Button.new(
|
|
text: t(".save_api_key"),
|
|
variant: "primary",
|
|
type: "submit"
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|