mirror of
https://github.com/we-promise/sure.git
synced 2026-06-04 18:29:02 +00:00
* fix(transactions): include enable_banking in pending/confirmed status filter (#1668) The transaction status filter hardcoded only simplefin/plaid/lunchflow in its pending/confirmed SQL, even though Transaction::PENDING_PROVIDERS also includes enable_banking. As a result, Enable Banking pending transactions returned 0 results under the "Pending" filter and leaked into "Confirmed". Source the provider list from the existing constant-driven helpers instead: - Transaction::Search delegates to the `pending` / `excluding_pending` model scopes. - EntrySearch interpolates Transaction::PENDING_CHECK_SQL into its EXISTS subqueries. This keeps every status-filter path in sync with PENDING_PROVIDERS so adding a future provider can't reintroduce the bug. Fixes #1668 * test(entry): cover EntrySearch status filter across all pending providers Adds a regression test for the EntrySearch#apply_status_filter path, asserting pending transactions for every PENDING_PROVIDERS entry are matched by the "pending" filter and excluded from "confirmed". Mirrors the existing Transaction::Search coverage so both filter paths are exercised.