mirror of
https://github.com/we-promise/sure.git
synced 2026-09-09 08:34:26 +00:00
* feat(budgets): add per-user personal budgets with strict isolation Families can now opt into personal budgets (toggleable via family settings): each family member gets their own budget for a given period instead of sharing a single family-wide budget. - Add families.personal_budgets flag and budgets.user_id, with partial unique indexes so shared budgets (user_id IS NULL) and personal budgets (user_id IS NOT NULL) can't collide. - Budget.find_or_bootstrap scopes lookup/creation by user when the family has personal_budgets enabled. - Scope most_recent_initialized_budget (used to seed a new budget from the prior period) by user_id so one user's copy-forward never bleeds into another user's budget. - budgets.user_id cascades on user deletion so personal budgets don't outlive their owner. * feat(budgets): enforce user-specific budget ownership and cascade deletion * feat(budgets): display user name for personal budgets in budget card on the plan section * feat(budgets): enhance personal budgets display for admins with preview feature indication * feat(budgets): enforce user-specific budget and category visibility for personal budgets * feat(budgets): create budget section titles and add translations notice in preferences * feat(budgets): let household and personal budgets coexist with sharing Previously enabling personal_budgets made the shared household budget unreachable. Budget.find_or_bootstrap now takes an explicit household: flag so both can be resolved independently for the same period, with a new household_budget_enabled family setting to opt out of the household side and keep personal budgets only. Adds a BudgetShare model (read_only/read_write) so a member can grant another family member access to their personal budget, enforced via Budget#viewable_by?/editable_by? across BudgetsController, BudgetCategoriesController, PlansController, and the read-only API. Preferences gains a Budget sharing card (gated on preview access like the rest of the personal budgets UI) and an owner switcher pill ( Household / mine / shared-with-me) appears on the budget page and the Plan hub card. Also fixes personal budgets showing the same "actual spending" as the household budget: actual spending/income now scope to the budget owner's own accounts instead of the viewer's full accessible set, via a new accounts: override on IncomeStatement. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat(budgets): enhance budget switcher with icons and improved styling * feat(budgets): remove user name display from budget card and header * feat(budgets): remove unique index on taggable_type and taggable_id in taggings * feat(budgets): enhance budget sharing functionality and improve UI elements * Collapse personal budget migrations --------- Signed-off-by: JulienGourmet <69808509+jubbakka@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: sure-admin <sure-admin@splashblot.com>
184 lines
7.4 KiB
Ruby
184 lines
7.4 KiB
Ruby
require "test_helper"
|
|
|
|
class PersonalBudgetTest < ActiveSupport::TestCase
|
|
include EntriesTestHelper
|
|
|
|
setup do
|
|
@family = families(:empty)
|
|
@user1 = users(:josh)
|
|
@user2 = users(:ann)
|
|
@date = Date.current.beginning_of_month
|
|
end
|
|
|
|
test "shared budget by default" do
|
|
@family.update!(personal_budgets: false)
|
|
|
|
budget1 = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
budget2 = Budget.find_or_bootstrap(@family, start_date: @date, user: @user2)
|
|
|
|
assert_equal budget1.id, budget2.id
|
|
assert_nil budget1.user_id
|
|
end
|
|
|
|
test "separate budgets when personal_budgets is enabled" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
budget1 = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
budget2 = Budget.find_or_bootstrap(@family, start_date: @date, user: @user2)
|
|
|
|
assert_not_equal budget1.id, budget2.id
|
|
assert_equal @user1.id, budget1.user_id
|
|
assert_equal @user2.id, budget2.user_id
|
|
end
|
|
|
|
test "find_or_bootstrap handles transition from shared to personal" do
|
|
@family.update!(personal_budgets: false)
|
|
shared_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
|
|
@family.update!(personal_budgets: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
|
|
assert_not_equal shared_budget.id, personal_budget.id
|
|
assert_equal @user1.id, personal_budget.user_id
|
|
end
|
|
|
|
test "most_recent_initialized_budget does not bleed across users" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
past_date = 1.month.ago.beginning_of_month
|
|
|
|
# user1 has an initialized budget last month
|
|
user1_past = Budget.find_or_bootstrap(@family, start_date: past_date, user: @user1)
|
|
user1_past.update!(budgeted_spending: 3000, expected_income: 5000)
|
|
|
|
# user2 has no budget last month — creates a fresh one for this month
|
|
user2_current = Budget.find_or_bootstrap(@family, start_date: @date, user: @user2)
|
|
|
|
# user2's source should be nil, not user1's past budget
|
|
assert_nil user2_current.most_recent_initialized_budget
|
|
end
|
|
|
|
test "copy_previous does not copy another users budget" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
past_date = 1.month.ago.beginning_of_month
|
|
|
|
user1_past = Budget.find_or_bootstrap(@family, start_date: past_date, user: @user1)
|
|
user1_past.update!(budgeted_spending: 9999, expected_income: 9999)
|
|
|
|
user2_current = Budget.find_or_bootstrap(@family, start_date: @date, user: @user2)
|
|
|
|
# copy_from! should not find user1's budget as source
|
|
source = user2_current.most_recent_initialized_budget
|
|
assert_nil source
|
|
assert_nil user2_current.budgeted_spending
|
|
end
|
|
|
|
test "copy_from! rejects a source budget owned by another user" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
past_date = 1.month.ago.beginning_of_month
|
|
|
|
user1_past = Budget.find_or_bootstrap(@family, start_date: past_date, user: @user1)
|
|
user1_past.update!(budgeted_spending: 9999, expected_income: 9999)
|
|
|
|
user2_current = Budget.find_or_bootstrap(@family, start_date: @date, user: @user2)
|
|
|
|
assert_raises(ArgumentError) { user2_current.copy_from!(user1_past) }
|
|
end
|
|
|
|
test "deleting a user cascades through their personal budget and budget categories" do
|
|
@family.update!(personal_budgets: true)
|
|
category = @family.categories.create!(name: "Groceries", color: "#6172F3")
|
|
|
|
budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
budget.update!(budgeted_spending: 500, expected_income: 1000)
|
|
budget_category = budget.budget_categories.find_by!(category_id: category.id)
|
|
|
|
assert_nothing_raised { @user1.destroy! }
|
|
|
|
assert_nil Budget.find_by(id: budget.id)
|
|
assert_nil BudgetCategory.find_by(id: budget_category.id)
|
|
end
|
|
|
|
test "household and personal budgets coexist when household: true is explicitly requested" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
household_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1, household: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
|
|
assert_not_equal household_budget.id, personal_budget.id
|
|
assert_nil household_budget.user_id
|
|
assert_equal @user1.id, personal_budget.user_id
|
|
end
|
|
|
|
test "household: true returns nil when the family disabled household_budget_enabled" do
|
|
@family.update!(personal_budgets: true, household_budget_enabled: false)
|
|
|
|
assert_nil Budget.find_or_bootstrap(@family, start_date: @date, user: @user1, household: true)
|
|
end
|
|
|
|
test "household: true ignores household_budget_enabled when personal_budgets is off" do
|
|
@family.update!(personal_budgets: false, household_budget_enabled: false)
|
|
|
|
budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1, household: true)
|
|
|
|
assert budget.present?
|
|
assert_nil budget.user_id
|
|
end
|
|
|
|
test "viewable_by? and editable_by? allow every family member on the household budget" do
|
|
household_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1, household: true)
|
|
|
|
assert household_budget.viewable_by?(@user1)
|
|
assert household_budget.viewable_by?(@user2)
|
|
assert household_budget.editable_by?(@user1)
|
|
assert household_budget.editable_by?(@user2)
|
|
end
|
|
|
|
test "viewable_by? and editable_by? restrict a personal budget to its owner by default" do
|
|
@family.update!(personal_budgets: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
|
|
assert personal_budget.viewable_by?(@user1)
|
|
assert personal_budget.editable_by?(@user1)
|
|
assert_not personal_budget.viewable_by?(@user2)
|
|
assert_not personal_budget.editable_by?(@user2)
|
|
end
|
|
|
|
test "a read_only BudgetShare grants viewing but not editing" do
|
|
@family.update!(personal_budgets: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
BudgetShare.create!(owner: @user1, viewer: @user2, permission: "read_only")
|
|
|
|
assert personal_budget.viewable_by?(@user2)
|
|
assert_not personal_budget.editable_by?(@user2)
|
|
end
|
|
|
|
test "a read_write BudgetShare grants both viewing and editing" do
|
|
@family.update!(personal_budgets: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
BudgetShare.create!(owner: @user1, viewer: @user2, permission: "read_write")
|
|
|
|
assert personal_budget.viewable_by?(@user2)
|
|
assert personal_budget.editable_by?(@user2)
|
|
end
|
|
|
|
test "household actual spending reflects the viewer's accessible accounts, personal reflects only the owner's own" do
|
|
@family.update!(personal_budgets: true)
|
|
|
|
owned_account = Account.create!(family: @family, accountable: Depository.new, name: "Josh checking", status: "active", currency: "USD", balance: 0, owner: @user1)
|
|
joint_account = Account.create!(family: @family, accountable: Depository.new, name: "Joint savings", status: "active", currency: "USD", balance: 0, owner: @user2)
|
|
AccountShare.create!(account: joint_account, user: @user1, permission: "read_write", include_in_finances: true)
|
|
|
|
create_transaction(account: owned_account, amount: 50, date: @date)
|
|
create_transaction(account: joint_account, amount: 200, date: @date)
|
|
|
|
household_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1, household: true)
|
|
personal_budget = Budget.find_or_bootstrap(@family, start_date: @date, user: @user1)
|
|
|
|
assert_equal 250.0, household_budget.actual_spending.to_f
|
|
assert_equal 50.0, personal_budget.actual_spending.to_f
|
|
end
|
|
end
|