mirror of
https://github.com/we-promise/sure.git
synced 2026-05-30 07:49:01 +00:00
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
135 lines
5.5 KiB
Plaintext
135 lines
5.5 KiB
Plaintext
<%# locals: (binance_item:, unlinked_count: binance_item.unlinked_accounts_count) %>
|
|
|
|
<%= tag.div id: dom_id(binance_item) do %>
|
|
<%= render DS::Disclosure.new(variant: :card, open: true) do |disclosure| %>
|
|
<% disclosure.with_summary_content do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "chevron-right", class: "group-open:rotate-90 motion-safe:transition-transform motion-safe:duration-150" %>
|
|
|
|
<div class="flex items-center justify-center h-8 w-8 rounded-full" style="background-color: rgba(240, 185, 11, 0.15);">
|
|
<div class="flex items-center justify-center">
|
|
<%= icon "coins", size: "sm", class: "text-[#F0B90B]" %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="pl-1 text-sm flex-1">
|
|
<div class="flex items-center gap-2">
|
|
<%= tag.p binance_item.institution_display_name, class: "font-medium text-primary" %>
|
|
<% if binance_item.scheduled_for_deletion? %>
|
|
<p class="text-destructive text-sm animate-pulse"><%= t(".deletion_in_progress") %></p>
|
|
<% end %>
|
|
</div>
|
|
<p class="text-xs text-secondary"><%= t(".provider_name") %></p>
|
|
<% if binance_item.syncing? %>
|
|
<div class="text-secondary flex items-center gap-1">
|
|
<%= icon "loader", size: "sm", class: "animate-spin" %>
|
|
<%= tag.span t(".syncing") %>
|
|
</div>
|
|
<% elsif binance_item.requires_update? %>
|
|
<div class="text-warning flex items-center gap-1">
|
|
<%= icon "alert-triangle", size: "sm", color: "warning" %>
|
|
<%= tag.span t(".reconnect") %>
|
|
</div>
|
|
<% else %>
|
|
<p class="text-secondary">
|
|
<% if binance_item.last_synced_at %>
|
|
<% if binance_item.sync_status_summary %>
|
|
<%= t(".status_with_summary", timestamp: time_ago_in_words(binance_item.last_synced_at), summary: binance_item.sync_status_summary) %>
|
|
<% else %>
|
|
<%= t(".status", timestamp: time_ago_in_words(binance_item.last_synced_at)) %>
|
|
<% end %>
|
|
<% else %>
|
|
<%= t(".status_never") %>
|
|
<% end %>
|
|
</p>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% if Current.user&.admin? %>
|
|
<div class="flex items-center justify-end gap-2 mt-2">
|
|
<% if binance_item.requires_update? %>
|
|
<%= render DS::Link.new(
|
|
text: t(".update_credentials"),
|
|
icon: "refresh-cw",
|
|
variant: "secondary",
|
|
href: settings_providers_path,
|
|
frame: "_top"
|
|
) %>
|
|
<% else %>
|
|
<%= icon(
|
|
"refresh-cw",
|
|
as_button: true,
|
|
href: sync_binance_item_path(binance_item),
|
|
disabled: binance_item.syncing?
|
|
) %>
|
|
<% end %>
|
|
|
|
<%= render DS::Menu.new do |menu| %>
|
|
<% if binance_item.unlinked_accounts_count > 0 %>
|
|
<% menu.with_item(
|
|
variant: "link",
|
|
text: t(".import_accounts_menu"),
|
|
icon: "plus",
|
|
href: setup_accounts_binance_item_path(binance_item),
|
|
frame: :modal
|
|
) %>
|
|
<% end %>
|
|
<% menu.with_item(
|
|
variant: "button",
|
|
text: t(".delete"),
|
|
icon: "trash-2",
|
|
href: binance_item_path(binance_item),
|
|
method: :delete,
|
|
confirm: CustomConfirm.for_resource_deletion(binance_item.institution_display_name, high_severity: true)
|
|
) %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% unless binance_item.scheduled_for_deletion? %>
|
|
<div class="space-y-4 mt-4">
|
|
<% if binance_item.accounts.any? %>
|
|
<%= render "accounts/index/account_groups", accounts: binance_item.accounts %>
|
|
<% binance_item.stale_rate_accounts.each do |ba| %>
|
|
<div class="flex items-center gap-2 text-xs text-warning px-1">
|
|
<span class="font-mono">~</span>
|
|
<%= icon "triangle-alert", size: "sm" %>
|
|
<span>
|
|
<%= t("binance_items.binance_item.stale_rate_warning",
|
|
date: ba.extra.dig("binance", "rate_target_date")) %>
|
|
</span>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
|
|
<% stats = binance_item.syncs.ordered.first&.sync_stats || {} %>
|
|
<%= render ProviderSyncSummary.new(
|
|
stats: stats,
|
|
provider_item: binance_item
|
|
) %>
|
|
|
|
<% if binance_item.unlinked_accounts_count > 0 %>
|
|
<div class="p-4 flex flex-col gap-3 items-center justify-center bg-surface border border-primary rounded-xl">
|
|
<p class="text-primary font-medium text-sm"><%= t(".setup_needed") %></p>
|
|
<p class="text-secondary text-sm text-center"><%= t(".setup_description") %></p>
|
|
<%= render DS::Link.new(
|
|
text: t(".setup_action"),
|
|
icon: "plus",
|
|
variant: "primary",
|
|
href: setup_accounts_binance_item_path(binance_item),
|
|
frame: :modal
|
|
) %>
|
|
</div>
|
|
<% elsif binance_item.accounts.empty? && binance_item.binance_accounts.none? %>
|
|
<div class="p-4 flex flex-col gap-3 items-center justify-center">
|
|
<p class="text-primary font-medium text-sm"><%= t(".no_accounts_title") %></p>
|
|
<p class="text-secondary text-sm"><%= t(".no_accounts_message") %></p>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|