mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Add `investment_activity_label` to trades and enhance activity label handling - Introduced `investment_activity_label` column to the `trades` table with a migration. - Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`). - Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels. - Updated views and controllers to display and manage activity labels for trades. - Added localized badge components for displaying and editing labels dynamically. - Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically. - Added investment flows section to reports for tracking contributions and withdrawals. - Refactored related tests and models for consistency and to ensure proper validation and filtering. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Add safeguard for `dropdownTarget` existence in quick edit controller - Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility. * Fix undefined method 'category' for Trade on mobile view Trade model uses investment_activity_label, not category. The upstream merge introduced a call to trade.category which doesn't exist. Use the activity label badge on mobile instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix activity label logic for zero/blank quantity and sell inference - Return `nil` for blank or zero quantity in `investment_activity_label_for`. - Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`. * Fix i18n key paths in transactions controller for convert_to_trade - Update flash message translations to use full i18n paths. - Use `BigDecimal` for quantity and price calculations to improve precision. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
109 lines
3.0 KiB
JavaScript
109 lines
3.0 KiB
JavaScript
import { Controller } from "@hotwired/stimulus"
|
|
|
|
export default class extends Controller {
|
|
static targets = ["dropdown", "badge"]
|
|
static values = {
|
|
url: String,
|
|
entryableId: String,
|
|
currentLabel: String,
|
|
entryableType: String,
|
|
convertUrl: String
|
|
}
|
|
|
|
connect() {
|
|
// Close dropdown when clicking outside
|
|
this.boundCloseOnClickOutside = this.closeOnClickOutside.bind(this)
|
|
document.addEventListener("click", this.boundCloseOnClickOutside)
|
|
}
|
|
|
|
disconnect() {
|
|
document.removeEventListener("click", this.boundCloseOnClickOutside)
|
|
}
|
|
|
|
toggle(event) {
|
|
event.preventDefault()
|
|
event.stopPropagation()
|
|
|
|
if (this.hasDropdownTarget) {
|
|
this.dropdownTarget.classList.toggle("hidden")
|
|
}
|
|
}
|
|
|
|
closeOnClickOutside(event) {
|
|
if (!this.element.contains(event.target)) {
|
|
this.close()
|
|
}
|
|
}
|
|
|
|
close() {
|
|
if (this.hasDropdownTarget) {
|
|
this.dropdownTarget.classList.add("hidden")
|
|
}
|
|
}
|
|
|
|
async select(event) {
|
|
event.preventDefault()
|
|
event.stopPropagation()
|
|
|
|
const label = event.currentTarget.dataset.label
|
|
|
|
// Don't update if it's the same label
|
|
if (label === this.currentLabelValue) {
|
|
this.close()
|
|
return
|
|
}
|
|
|
|
// For Transactions: Buy/Sell should prompt to convert to trade
|
|
if (this.entryableTypeValue === "Transaction" && (label === "Buy" || label === "Sell") && this.hasConvertUrlValue) {
|
|
this.close()
|
|
// Navigate to convert-to-trade modal in a Turbo frame, passing the selected label
|
|
const url = new URL(this.convertUrlValue, window.location.origin)
|
|
url.searchParams.set("activity_label", label)
|
|
Turbo.visit(url.toString(), { frame: "modal" })
|
|
return
|
|
}
|
|
|
|
// For other labels (Dividend, Interest, Fee, etc.) or for Trades, just save the label
|
|
const csrfToken = document.querySelector('meta[name="csrf-token"]')?.content
|
|
if (!csrfToken) {
|
|
console.error("CSRF token not found")
|
|
return
|
|
}
|
|
|
|
try {
|
|
const response = await fetch(this.urlValue, {
|
|
method: "PATCH",
|
|
headers: {
|
|
"Content-Type": "application/json",
|
|
"X-CSRF-Token": csrfToken,
|
|
"Accept": "text/vnd.turbo-stream.html"
|
|
},
|
|
body: JSON.stringify({
|
|
entry: {
|
|
entryable_attributes: {
|
|
id: this.entryableIdValue,
|
|
investment_activity_label: label
|
|
}
|
|
}
|
|
})
|
|
})
|
|
|
|
if (response.ok) {
|
|
const contentType = response.headers.get("content-type")
|
|
if (contentType?.includes("text/vnd.turbo-stream.html")) {
|
|
// Let Turbo handle the stream response
|
|
const html = await response.text()
|
|
Turbo.renderStreamMessage(html)
|
|
}
|
|
// Update local state and badge
|
|
this.currentLabelValue = label
|
|
this.close()
|
|
} else {
|
|
console.error("Failed to update activity label:", response.status)
|
|
}
|
|
} catch (error) {
|
|
console.error("Error updating activity label:", error)
|
|
}
|
|
}
|
|
}
|