mirror of
https://github.com/we-promise/sure.git
synced 2026-05-25 13:34:58 +00:00
0d32bb70ec
* chore(design-system): swap raw gray classes for semantic tokens across remaining views Finalizes the raw-color sweep started in #1652 (settings) and continued in #1654 (holdings). Covers accounts, budgets, chats, pages, imports, provider integrations (mercury, lunchflow, sophtron, enable_banking, coinstats), auth flows (password reset, MFA, registrations), shared layouts, and selected DS component hover states. 35 files, ~56 line changes. Mappings (matching the patterns established in the prior sweeps): - text-white bg-gray-900 hover:bg-gray-800 (with optional focus:ring-gray-900) -> text-inverse button-bg-primary hover:button-bg-primary-hover -> focus:ring-button-bg-primary - text-gray-500 / 600 / 700 -> text-secondary - text-gray-800 -> text-primary - text-gray-400 -> text-subdued - hover:text-gray-700 / hover:text-gray-100 -> hover:text-primary - bg-gray-50 / 100 / 200 (standalone) -> bg-surface-inset - bg-gray-500/5 -> bg-gray-tint-5 - bg-gray-500/10 -> bg-gray-tint-10 - bg-gray-900 (decorative active states) -> bg-inverse - hover:bg-gray-50 / 100 (standalone) -> hover:bg-surface-inset - hover:bg-gray-300 -> hover:bg-surface-inset-hover - bg-white hover:bg-gray-100 -> bg-container hover:bg-container-hover - border-gray-300 -> border-secondary - focus:border-gray-200 -> focus:border-secondary - focus-within:border-gray-900 -> focus-within:border-primary - DS::Buttonish outline / ghost / icon hover: hover:bg-gray-100 theme-dark:hover:bg-gray-700 -> hover:bg-container-inset-hover Left intentionally raw, with rationale: - bg-gray-300 / bg-gray-400 decorative dots and avatar circles. The raw value reads OK against both bg-container variants; no semantic "neutral indicator" token exists. Same pattern as #1652 / #1654. - bg-gray-400/20 theme-dark:bg-gray-500/20 (onboardings/trial). Custom alpha tint with no equivalent token. - bg-white theme-dark:bg-gray-700 (DS::Tabs active pill, budgets tabs). Custom tab-pill pattern; gray-700 in dark mode (one shade lighter than page bg-gray-900) is intentional for visibility. - bg-gray-100 theme-dark:bg-gray-700 (DS::Toggle base bg). Closest match (bg-container-inset-hover) is semantically a hover state. - DS::Buttonish secondary variant gray-200/300/700/600 pattern. Same pattern as #1654 holdings; needs button-bg-secondary-strong from that PR. Will swap in a follow-up after #1654 merges. - disabled:bg-gray-500 theme-dark:disabled:bg-gray-400 on inverse buttons (DS::Buttonish primary, enable_banking, coinstats). Custom disabled state for the inverse pair; no token. - text-gray-300 SVG stroke (shared/_progress_circle). - bg-white text-gray-900 (layouts/print). Print contexts intentionally light regardless of theme. - bg-gray-800 / border-gray-700 / text-white / hover:text-gray-100 (impersonation_sessions/_super_admin_bar). Admin overlay styled to remain dark in both modes; not a theme-aware component. Files covered by other in-flight PRs were skipped to avoid rebase conflicts: chats/_ai_consent's fg-inverse swap (#1626), shared/_text_tooltip and shared/_money_field tooltip pills (#1626), investments/_value_tooltip (#1626), components/DS/tooltip (#1626). * fix(design-system): keep changelog avatar text raw to preserve dark-mode contrast The changelog avatar fallback (when @release_notes[:avatar] is missing) sits inside the "decorative + raw" exception list — bg-gray-300 stays fixed across themes since no semantic neutral-indicator token exists. The earlier sweep partially themed the pair: bg-gray-300 stayed raw but text-gray-600 became text-secondary. text-secondary resolves to gray-300 in dark mode, which matches the bg → text became invisible against its own background. Reverting only the text class to text-gray-600 restores the original fixed-light placeholder behavior. Both classes raw, both themes readable. * fix(design-system): address review feedback on raw-color-sweep-finalize Six issues caught by CodeRabbit + Codex review: 1. focus:ring-button-bg-primary silently emits no CSS (×6 files). button-bg-primary is a custom @utility, not a theme color, so Tailwind's ring-{name} resolution finds no --color-button-bg-primary. Replaces with focus:ring-gray-900 theme-dark:focus:ring-white — same color flip as the button bg, but resolved through theme colors so the ring actually renders. Files: lunchflow/mercury/sophtron _api_error + _setup_required, coinstats_items/new. 2. accounts/show/_activity.html.erb: focus-within:ring-gray-100 was dead (no ring-width on the parent). Removed. 3. import/confirms/show.html.erb: uniform hover:bg-surface-inset-hover applied to both active and inactive step indicators created a jarring dark-to-light flip on the active step (bg-inverse → bg-surface-inset-hover). Now hover follows the resting state: active uses hover:bg-inverse-hover, inactive uses hover:bg-surface-inset-hover. 4. password_resets/new.html.erb: bg-white left raw alongside the migrated hover:bg-surface-inset. Swapped to bg-container so dark mode flips properly. 5. registrations/new.html.erb + password_validator_controller.js: view now uses bg-surface-inset on password strength block lines, but the Stimulus controller still toggled bg-gray-200 on validate. Updated controller to add/remove bg-surface-inset matching the view, so unmet states reset to the tokenized class instead of leaving raw gray-200 stuck on the element.
105 lines
4.2 KiB
Plaintext
105 lines
4.2 KiB
Plaintext
<%# locals: (account:) %>
|
|
|
|
<%= turbo_frame_tag dom_id(account, "entries") do %>
|
|
<div class="bg-container px-3 py-4 lg:p-4 shadow-border-xs rounded-xl">
|
|
<div class="flex items-center justify-between mb-4" data-testid="activity-menu">
|
|
<%= tag.h2 t(".title"), class: "font-medium text-lg" %>
|
|
<% unless @account.linked? %>
|
|
<% if @account.permission_for(Current.user).in?([ :owner, :full_control ]) %>
|
|
<%= render DS::Menu.new(variant: "button") do |menu| %>
|
|
<% menu.with_button(text: "New", variant: "secondary", icon: "plus") %>
|
|
|
|
<% menu.with_item(
|
|
variant: "link",
|
|
text: "New balance",
|
|
icon: "circle-dollar-sign",
|
|
href: new_valuation_path(account_id: @account.id),
|
|
data: { turbo_frame: :modal }) %>
|
|
|
|
<% if @account.supports_trades? %>
|
|
<% menu.with_item(
|
|
variant: "link",
|
|
text: t(".new_trade"),
|
|
icon: "credit-card",
|
|
href: new_trade_path(account_id: @account.id),
|
|
data: { turbo_frame: :modal }) %>
|
|
<% elsif !@account.crypto? %>
|
|
<% menu.with_item(
|
|
variant: "link",
|
|
text: t(".new_transaction"),
|
|
icon: "credit-card",
|
|
href: new_transaction_path(account_id: @account.id),
|
|
data: { turbo_frame: :modal }) %>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div>
|
|
<%= form_with url: account_path(account),
|
|
id: "entries-search",
|
|
scope: :q,
|
|
method: :get,
|
|
data: { controller: "auto-submit-form" } do |form| %>
|
|
<div class="flex gap-2 mb-4">
|
|
<div class="grow">
|
|
<div class="flex items-center px-3 py-2 gap-2 border border-secondary rounded-lg focus-within:border-primary">
|
|
<%= icon("search") %>
|
|
<%= hidden_field_tag :account_id, @account.id %>
|
|
<%= form.search_field :search,
|
|
placeholder: "Search entries by name",
|
|
value: @q[:search],
|
|
class: "form-field__input placeholder:text-sm placeholder:text-secondary",
|
|
"data-auto-submit-form-target": "auto" %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<% if @entries.empty? %>
|
|
<p class="text-secondary text-sm p-4"><%= t(".no_entries") %></p>
|
|
<% else %>
|
|
<%= tag.div id: dom_id(@account, "entries_bulk_select"),
|
|
data: {
|
|
controller: "bulk-select checkbox-toggle",
|
|
bulk_select_singular_label_value: t(".entry"),
|
|
bulk_select_plural_label_value: t(".entries")
|
|
} do %>
|
|
<div id="entry-selection-bar" data-bulk-select-target="selectionBar" class="flex justify-center hidden">
|
|
<%= render "entries/selection_bar" %>
|
|
</div>
|
|
|
|
<div class="grid bg-container-inset rounded-xl grid-cols-12 items-center uppercase text-xs font-medium text-secondary px-5 py-3 mb-4">
|
|
<div class="pl-0.5 col-span-8 flex items-center gap-4">
|
|
<%= check_box_tag "selection_entry",
|
|
class: "checkbox checkbox--light hidden lg:block",
|
|
data: {
|
|
action: "bulk-select#togglePageSelection",
|
|
checkbox_toggle_target: "selectionEntry"
|
|
} %>
|
|
<p><%= t(".date") %></p>
|
|
</div>
|
|
<%= tag.p t(".amount"), class: "col-span-2 justify-self-end" %>
|
|
<%= tag.p t(".balance"), class: "col-span-2 justify-self-end" %>
|
|
</div>
|
|
|
|
<div>
|
|
<div class="space-y-4">
|
|
<%= entries_by_date(@entries) do |entries| %>
|
|
<% entries.each_with_index do |entry, index| %>
|
|
<%= render entry, view_ctx: "account" %>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="p-4 bg-container rounded-bl-lg rounded-br-lg">
|
|
<%= render "shared/pagination", pagy: @pagy %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|